From da00287a8e3fb012c449ebff524722b1ff48364b Mon Sep 17 00:00:00 2001
From: Daniel Supernault <danielsupernault@gmail.com>
Date: Mon, 5 Dec 2022 00:46:55 -0700
Subject: [PATCH] Update AP helpers

---
 app/Services/ActivityPubFetchService.php | 18 ++++++++++++++----
 app/Util/ActivityPub/Helpers.php         |  5 ++++-
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/app/Services/ActivityPubFetchService.php b/app/Services/ActivityPubFetchService.php
index c73e9613..b137e7bb 100644
--- a/app/Services/ActivityPubFetchService.php
+++ b/app/Services/ActivityPubFetchService.php
@@ -6,6 +6,7 @@ use Illuminate\Support\Facades\Http;
 use App\Profile;
 use App\Util\ActivityPub\Helpers;
 use App\Util\ActivityPub\HttpSignature;
+use Illuminate\Http\Client\ConnectionException;
 
 class ActivityPubFetchService
 {
@@ -19,9 +20,18 @@ class ActivityPubFetchService
 		$headers['Accept'] = 'application/activity+json, application/json';
 		$headers['User-Agent'] = '(Pixelfed/'.config('pixelfed.version').'; +'.config('app.url').')';
 
-		return Http::withHeaders($headers)
-			->timeout(30)
-			->get($url)
-			->body();
+		try {
+			$res = Http::withHeaders($headers)
+				->timeout(10)
+				->get($url);
+		} catch (ConnectionException $e) {
+			return;
+		} catch (Exception $e) {
+			return;
+		}
+		if(!$res->ok()) {
+			return;
+		}
+		return $res->body();
 	}
 }
diff --git a/app/Util/ActivityPub/Helpers.php b/app/Util/ActivityPub/Helpers.php
index d49ff0cd..1d09985f 100644
--- a/app/Util/ActivityPub/Helpers.php
+++ b/app/Util/ActivityPub/Helpers.php
@@ -248,10 +248,13 @@ class Helpers {
 
 		$hash = hash('sha256', $url);
 		$key = "helpers:url:fetcher:sha256-{$hash}";
-		$ttl = now()->addMinutes(5);
+		$ttl = now()->addMinutes(15);
 
 		return Cache::remember($key, $ttl, function() use($url) {
 			$res = ActivityPubFetchService::get($url);
+			if(!$res || empty($res)) {
+				return false;
+			}
 			$res = json_decode($res, true, 8);
 			if(json_last_error() == JSON_ERROR_NONE) {
 				return $res;