forked from mirror/pixelfed
Update CommentPipeline, replace expensive query and mark for refactor
This commit is contained in:
parent
8b007f9ee9
commit
764315666e
2 changed files with 12 additions and 8 deletions
|
@ -60,10 +60,12 @@ class CommentPipeline implements ShouldQueue
|
|||
$actor = $comment->profile;
|
||||
|
||||
if(config('database.default') === 'mysql') {
|
||||
$exp = DB::raw("select id, in_reply_to_id from statuses, (select @pv := :kid) initialisation where id > @pv and find_in_set(in_reply_to_id, @pv) > 0 and @pv := concat(@pv, ',', id)");
|
||||
$expQuery = $exp->getValue(DB::connection()->getQueryGrammar());
|
||||
$count = DB::select($expQuery, [ 'kid' => $status->id ]);
|
||||
$status->reply_count = count($count);
|
||||
// todo: refactor
|
||||
// $exp = DB::raw("select id, in_reply_to_id from statuses, (select @pv := :kid) initialisation where id > @pv and find_in_set(in_reply_to_id, @pv) > 0 and @pv := concat(@pv, ',', id)");
|
||||
// $expQuery = $exp->getValue(DB::connection()->getQueryGrammar());
|
||||
// $count = DB::select($expQuery, [ 'kid' => $status->id ]);
|
||||
// $status->reply_count = count($count);
|
||||
$status->reply_count = $status->reply_count + 1;
|
||||
$status->save();
|
||||
} else {
|
||||
$status->reply_count = $status->reply_count + 1;
|
||||
|
|
|
@ -70,10 +70,12 @@ class StatusReplyPipeline implements ShouldQueue
|
|||
}
|
||||
|
||||
if(config('database.default') === 'mysql') {
|
||||
$exp = DB::raw("select id, in_reply_to_id from statuses, (select @pv := :kid) initialisation where id > @pv and find_in_set(in_reply_to_id, @pv) > 0 and @pv := concat(@pv, ',', id)");
|
||||
$expQuery = $exp->getValue(DB::connection()->getQueryGrammar());
|
||||
$count = DB::select($expQuery, [ 'kid' => $reply->id ]);
|
||||
$reply->reply_count = count($count);
|
||||
// todo: refactor
|
||||
// $exp = DB::raw("select id, in_reply_to_id from statuses, (select @pv := :kid) initialisation where id > @pv and find_in_set(in_reply_to_id, @pv) > 0 and @pv := concat(@pv, ',', id)");
|
||||
// $expQuery = $exp->getValue(DB::connection()->getQueryGrammar());
|
||||
// $count = DB::select($expQuery, [ 'kid' => $reply->id ]);
|
||||
// $reply->reply_count = count($count);
|
||||
$reply->reply_count = $reply->reply_count + 1;
|
||||
$reply->save();
|
||||
} else {
|
||||
$reply->reply_count = $reply->reply_count + 1;
|
||||
|
|
Loading…
Reference in a new issue