From 7e78f63ff5846ead6694dc08211664c415a8e92d Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Mon, 20 Aug 2018 18:34:26 -0600 Subject: [PATCH 01/11] Update RegisterController --- app/Http/Controllers/Auth/RegisterController.php | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/Auth/RegisterController.php b/app/Http/Controllers/Auth/RegisterController.php index 1b9de0513..f9ba3b648 100644 --- a/app/Http/Controllers/Auth/RegisterController.php +++ b/app/Http/Controllers/Auth/RegisterController.php @@ -51,11 +51,22 @@ class RegisterController extends Controller protected function validator(array $data) { $this->validateUsername($data['username']); - + $usernameRules = [ + 'required', + 'alpha_dash', + 'min:2', + 'max:15', + 'unique:users', + function($attribute, $value, $fail) { + if(!ctype_alpha($value[0])) { + return $fail($attribute . ' is invalid. Username must be alpha-numeric and start with a letter.'); + } + } + ]; $rules = [ 'name' => 'required|string|max:255', - 'username' => 'required|alpha_dash|min:2|max:15|unique:users', + 'username' => $usernameRules, 'email' => 'required|string|email|max:255|unique:users', 'password' => 'required|string|min:6|confirmed', ]; From bde671657fe218795e4e5de8d3724a4fd7dc90d8 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Mon, 20 Aug 2018 20:33:07 -0600 Subject: [PATCH 02/11] Update SettingsController, fix bug that prevented instances without email validation to update settings --- app/Http/Controllers/SettingsController.php | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/app/Http/Controllers/SettingsController.php b/app/Http/Controllers/SettingsController.php index 95859efa7..0c706184e 100644 --- a/app/Http/Controllers/SettingsController.php +++ b/app/Http/Controllers/SettingsController.php @@ -44,29 +44,33 @@ class SettingsController extends Controller $user = Auth::user(); $profile = $user->profile; + $validate = config('pixelfed.enforce_email_verification'); if($user->email != $email) { $changes = true; $user->email = $email; - $user->email_verified_at = null; - // Prevent old verifications from working - EmailVerification::whereUserId($user->id)->delete(); + + if($validate) { + $user->email_verified_at = null; + // Prevent old verifications from working + EmailVerification::whereUserId($user->id)->delete(); + } } // Only allow email to be updated if not yet verified - if(!$changes && $user->email_verified_at) { + if(!$validate || !$changes && $user->email_verified_at) { if($profile->name != $name) { $changes = true; $user->name = $name; $profile->name = $name; } - if($profile->website != $website) { + if(!$profile->website || $profile->website != $website) { $changes = true; $profile->website = $website; } - if($profile->bio != $bio) { + if(!$profile->bio || !$profile->bio != $bio) { $changes = true; $profile->bio = $bio; } From c636aae3b779ff5aa2c6382386d2dee9bc4ee1bd Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Mon, 20 Aug 2018 20:34:58 -0600 Subject: [PATCH 03/11] Update profile partial, add website to profile --- resources/views/profile/partial/user-info.blade.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/resources/views/profile/partial/user-info.blade.php b/resources/views/profile/partial/user-info.blade.php index 14575f18a..8e801d522 100644 --- a/resources/views/profile/partial/user-info.blade.php +++ b/resources/views/profile/partial/user-info.blade.php @@ -70,13 +70,14 @@ -

+

{{$user->name}} @if($user->remote_url) REMOTE PROFILE @endif - {{$user->bio}}

+

{{$user->bio}}

+

{{str_limit($user->website, 30)}}

From f746299711b357f226424c06575af9064ab0864c Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Mon, 20 Aug 2018 20:46:13 -0600 Subject: [PATCH 04/11] Update ProfileController and partial, fix status count --- app/Http/Controllers/ProfileController.php | 8 +++++++- resources/views/profile/partial/user-info.blade.php | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php index 985df88ed..4e647caba 100644 --- a/app/Http/Controllers/ProfileController.php +++ b/app/Http/Controllers/ProfileController.php @@ -18,7 +18,12 @@ class ProfileController extends Controller public function show(Request $request, $username) { $user = Profile::whereUsername($username)->firstOrFail(); - $settings = User::whereUsername($username)->firstOrFail()->settings; + if($user->remote_url) { + $settings = new \StdClass; + $settings->crawlable = false; + } else { + $settings = User::whereUsername($username)->firstOrFail()->settings; + } if($request->wantsJson() && config('pixelfed.activitypub_enabled')) { return $this->showActivityPub($request, $user); @@ -37,6 +42,7 @@ class ProfileController extends Controller $timeline = $user->statuses() ->whereHas('media') ->whereNull('in_reply_to_id') + ->whereNull('reblog_of_id') ->orderBy('created_at','desc') ->withCount(['comments', 'likes']) ->simplePaginate(21); diff --git a/resources/views/profile/partial/user-info.blade.php b/resources/views/profile/partial/user-info.blade.php index 8e801d522..75326885f 100644 --- a/resources/views/profile/partial/user-info.blade.php +++ b/resources/views/profile/partial/user-info.blade.php @@ -53,7 +53,7 @@
- {{$user->statuses()->whereNull('in_reply_to_id')->count()}} + {{$user->statuses()->whereNull('reblog_of_id')->whereNull('in_reply_to_id')->count()}} Posts
From 526f67f84d4ded65dab737f539f666e15f2d7e64 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Mon, 20 Aug 2018 21:03:22 -0600 Subject: [PATCH 05/11] Update hashtag infinite scroll --- resources/views/discover/tags/show.blade.php | 39 ++++++++++---------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/resources/views/discover/tags/show.blade.php b/resources/views/discover/tags/show.blade.php index 542f134c2..a710ae365 100644 --- a/resources/views/discover/tags/show.blade.php +++ b/resources/views/discover/tags/show.blade.php @@ -21,27 +21,28 @@
- -
- @foreach($posts as $status) -
- -
-
-
-
- - {{$status->likes_count}} - - - {{$status->comments_count}} - -
+
+
+ @foreach($posts as $status) +
+ +
+
+
+
+ + {{$status->likes_count}} + + + {{$status->comments_count}} + +
+
-
- + +
+ @endforeach
- @endforeach
{{$posts->links()}} From 08f2a4be9e044d3a5ff118df1f15d7f2592b5d09 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Tue, 21 Aug 2018 21:17:22 -0600 Subject: [PATCH 06/11] Add update_settings_table migration to add optional profile following/follower counts --- ...018_08_22_022306_update_settings_table.php | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 database/migrations/2018_08_22_022306_update_settings_table.php diff --git a/database/migrations/2018_08_22_022306_update_settings_table.php b/database/migrations/2018_08_22_022306_update_settings_table.php new file mode 100644 index 000000000..500612903 --- /dev/null +++ b/database/migrations/2018_08_22_022306_update_settings_table.php @@ -0,0 +1,36 @@ +boolean('show_profile_followers')->default(true); + $table->boolean('show_profile_follower_count')->default(true); + $table->boolean('show_profile_following')->default(true); + $table->boolean('show_profile_following_count')->default(true); + }); + } + + /** + * Reverse the migrations. + * + * @return void + */ + public function down() + { + $table->dropColumn('show_profile_followers'); + $table->dropColumn('show_profile_follower_count'); + $table->dropColumn('show_profile_following'); + $table->dropColumn('show_profile_following_count'); + } +} From 3a5ac488c0ba50336a4c5338e0e4930d89712043 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Tue, 21 Aug 2018 21:18:14 -0600 Subject: [PATCH 07/11] Update SettingsController --- app/Http/Controllers/SettingsController.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/Http/Controllers/SettingsController.php b/app/Http/Controllers/SettingsController.php index 0c706184e..ab8f35ce9 100644 --- a/app/Http/Controllers/SettingsController.php +++ b/app/Http/Controllers/SettingsController.php @@ -171,6 +171,8 @@ class SettingsController extends Controller $fields = [ 'is_private', 'crawlable', + 'show_profile_follower_count', + 'show_profile_following_count' ]; foreach($fields as $field) { $form = $request->input($field); From 18cd857e90f62195c130cfa24b9b1165ca05dce2 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Wed, 22 Aug 2018 00:56:16 -0600 Subject: [PATCH 08/11] Update AccountController --- app/Http/Controllers/AccountController.php | 106 ++++++++++++++++++++- 1 file changed, 105 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/AccountController.php b/app/Http/Controllers/AccountController.php index d3abf4dc8..76a47e938 100644 --- a/app/Http/Controllers/AccountController.php +++ b/app/Http/Controllers/AccountController.php @@ -6,10 +6,21 @@ use Illuminate\Http\Request; use Carbon\Carbon; use App\Mail\ConfirmEmail; use Auth, DB, Cache, Mail, Redis; -use App\{EmailVerification, Notification, Profile, User}; +use App\{ + EmailVerification, + Notification, + Profile, + User, + UserFilter +}; class AccountController extends Controller { + protected $filters = [ + 'user.mute', + 'user.block' + ]; + public function __construct() { $this->middleware('auth'); @@ -134,4 +145,97 @@ class AccountController extends Controller return $notifications; } + public function messages() + { + return view('account.messages'); + } + + + public function showMessage(Request $request, $id) + { + return view('account.message'); + } + + public function mute(Request $request) + { + $this->validate($request, [ + 'type' => 'required|string', + 'item' => 'required|integer|min:1' + ]); + + $user = Auth::user()->profile; + $type = $request->input('type'); + $item = $request->input('item'); + $action = "{$type}.mute"; + + if(!in_array($action, $this->filters)) { + return abort(406); + } + $filterable = []; + switch ($type) { + case 'user': + $profile = Profile::findOrFail($item); + if($profile->id == $user->id) { + return abort(403); + } + $class = get_class($profile); + $filterable['id'] = $profile->id; + $filterable['type'] = $class; + break; + + default: + # code... + break; + } + + $filter = UserFilter::firstOrCreate([ + 'user_id' => $user->id, + 'filterable_id' => $filterable['id'], + 'filterable_type' => $filterable['type'], + 'filter_type' => 'mute' + ]); + + return redirect()->back(); + + } + + public function block(Request $request) + { + $this->validate($request, [ + 'type' => 'required|string', + 'item' => 'required|integer|min:1' + ]); + + $user = Auth::user()->profile; + $type = $request->input('type'); + $item = $request->input('item'); + $action = "{$type}.block"; + if(!in_array($action, $this->filters)) { + return abort(406); + } + $filterable = []; + switch ($type) { + case 'user': + $profile = Profile::findOrFail($item); + $class = get_class($profile); + $filterable['id'] = $profile->id; + $filterable['type'] = $class; + break; + + default: + # code... + break; + } + + $filter = UserFilter::firstOrCreate([ + 'user_id' => $user->id, + 'filterable_id' => $filterable['id'], + 'filterable_type' => $filterable['type'], + 'filter_type' => 'block' + ]); + + return redirect()->back(); + + } + } From c7489a46c9bb5773686848875485dec121232540 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Wed, 22 Aug 2018 22:23:19 -0600 Subject: [PATCH 09/11] Update UserFilter model --- app/UserFilter.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/UserFilter.php b/app/UserFilter.php index 071f2eeb4..41edd5398 100644 --- a/app/UserFilter.php +++ b/app/UserFilter.php @@ -6,5 +6,10 @@ use Illuminate\Database\Eloquent\Model; class UserFilter extends Model { - // + protected $fillable = [ + 'user_id', + 'filterable_id', + 'filterable_type', + 'filter_type' + ]; } From 814b959c3fd007e18432816a776861cb8685d75c Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Wed, 22 Aug 2018 22:28:26 -0600 Subject: [PATCH 10/11] Update navbar --- resources/views/layouts/partial/nav.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/layouts/partial/nav.blade.php b/resources/views/layouts/partial/nav.blade.php index ffe87c815..28e9c485a 100644 --- a/resources/views/layouts/partial/nav.blade.php +++ b/resources/views/layouts/partial/nav.blade.php @@ -30,7 +30,7 @@
    • From b3827566a28ef314235f84f420724e14bfd57926 Mon Sep 17 00:00:00 2001 From: Daniel Supernault Date: Wed, 22 Aug 2018 22:30:53 -0600 Subject: [PATCH 11/11] Update tests --- tests/Feature/ExampleTest.php | 21 --------------------- tests/Feature/InstalledTest.php | 29 +++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 21 deletions(-) delete mode 100644 tests/Feature/ExampleTest.php create mode 100644 tests/Feature/InstalledTest.php diff --git a/tests/Feature/ExampleTest.php b/tests/Feature/ExampleTest.php deleted file mode 100644 index f31e495ca..000000000 --- a/tests/Feature/ExampleTest.php +++ /dev/null @@ -1,21 +0,0 @@ -get('/'); - - $response->assertStatus(200); - } -} diff --git a/tests/Feature/InstalledTest.php b/tests/Feature/InstalledTest.php new file mode 100644 index 000000000..0f9aa6d6b --- /dev/null +++ b/tests/Feature/InstalledTest.php @@ -0,0 +1,29 @@ +get('/'); + $response + ->assertStatus(200) + ->assertSeeText('Image Sharing for Everyone'); + } + + public function testNodeinfoTest() + { + $response = $this->get('/.well-known/nodeinfo'); + $response + ->assertStatus(200) + ->assertJson([ + "links" => [ + ["rel" => "http://nodeinfo.diaspora.software/ns/schema/2.0"] + ]]); + } +}