diff --git a/app/Http/Controllers/FederationController.php b/app/Http/Controllers/FederationController.php index 5bf37aa6..9540d5db 100644 --- a/app/Http/Controllers/FederationController.php +++ b/app/Http/Controllers/FederationController.php @@ -2,7 +2,10 @@ namespace App\Http\Controllers; -use App\Jobs\InboxPipeline\InboxWorker; +use App\Jobs\InboxPipeline\{ + InboxWorker, + InboxValidator +}; use App\Jobs\RemoteFollowPipeline\RemoteFollowPipeline; use App\{ AccountLog, @@ -18,8 +21,10 @@ use Cache; use Carbon\Carbon; use Illuminate\Http\Request; use League\Fractal; -use App\Util\ActivityPub\Helpers; -use App\Util\ActivityPub\HttpSignature; +use App\Util\ActivityPub\{ + Helpers, + HttpSignature +}; use \Zttp\Zttp; class FederationController extends Controller @@ -204,19 +209,9 @@ class FederationController extends Controller abort_if(!config('federation.activitypub.enabled'), 404); abort_if(!config('federation.activitypub.inbox'), 404); - $profile = Profile::whereNull('domain')->whereUsername($username)->firstOrFail(); - if($profile->status != null) { - return ProfileController::accountCheck($profile); - } - $body = $request->getContent(); - $bodyDecoded = json_decode($body, true, 8); - if($this->verifySignature($request, $profile) == true) { - InboxWorker::dispatch($request->headers->all(), $profile, $bodyDecoded); - } else if($this->blindKeyRotation($request, $profile) == true) { - InboxWorker::dispatch($request->headers->all(), $profile, $bodyDecoded); - } else { - abort(400, 'Bad Signature'); - } + $headers = $request->headers->all(); + $payload = $request->getContent(); + InboxValidator::dispatch($username, $headers, $payload); return; } diff --git a/app/Jobs/InboxPipeline/InboxValidator.php b/app/Jobs/InboxPipeline/InboxValidator.php new file mode 100644 index 00000000..9032cd87 --- /dev/null +++ b/app/Jobs/InboxPipeline/InboxValidator.php @@ -0,0 +1,151 @@ +username = $username; + $this->headers = $headers; + $this->payload = $payload; + } + + /** + * Execute the job. + * + * @return void + */ + public function handle() + { + $username = $this->username; + $headers = $this->headers; + $payload = json_decode($this->payload, true, 8); + + $profile = Profile::whereNull('domain')->whereUsername($username)->first(); + + if(empty($profile)) { + return; + } + + if($profile->status != null) { + return; + } + + if($this->verifySignature($headers, $profile, $payload) == true) { + InboxWorker::dispatch($headers, $profile, $payload); + } else if($this->blindKeyRotation($headers, $profile) == true) { + InboxWorker::dispatch($headers, $profile, $payload); + } else { + return; + } + + } + + protected function verifySignature($headers, $profile, $payload) + { + $body = $this->payload; + $bodyDecoded = $payload; + $signature = $headers['signature']; + $date = $headers['date']; + if(!$signature) { + abort(400, 'Missing signature header'); + } + if(!$date) { + abort(400, 'Missing date header'); + } + if(!now()->parse($date)->gt(now()->subDays(1)) || !now()->parse($date)->lt(now()->addDays(1))) { + abort(400, 'Invalid date'); + } + $signatureData = HttpSignature::parseSignatureHeader($signature); + $keyId = Helpers::validateUrl($signatureData['keyId']); + $id = Helpers::validateUrl($bodyDecoded['id']); + $keyDomain = parse_url($keyId, PHP_URL_HOST); + $idDomain = parse_url($id, PHP_URL_HOST); + if(isset($bodyDecoded['object']) + && is_array($bodyDecoded['object']) + && isset($bodyDecoded['object']['attributedTo']) + ) { + if(parse_url($bodyDecoded['object']['attributedTo'], PHP_URL_HOST) !== $keyDomain) { + abort(400, 'Invalid request'); + } + } + if(!$keyDomain || !$idDomain || $keyDomain !== $idDomain) { + abort(400, 'Invalid request'); + } + $actor = Profile::whereKeyId($keyId)->first(); + if(!$actor) { + $actor = Helpers::profileFirstOrNew($bodyDecoded['actor']); + } + if(!$actor) { + return false; + } + $pkey = openssl_pkey_get_public($actor->public_key); + $inboxPath = "/users/{$profile->username}/inbox"; + list($verified, $headers) = HTTPSignature::verify($pkey, $signatureData, $headers, $inboxPath, $body); + if($verified == 1) { + return true; + } else { + return false; + } + } + + protected function blindKeyRotation($headers, $profile, $payload) + { + $signature = $headers['signature']; + $date = $headers['date']; + if(!$signature) { + return false; + } + if(!$date) { + return false; + } + if(!now()->parse($date)->gt(now()->subDays(1)) || !now()->parse($date)->lt(now()->addDays(1))) { + return false; + } + $signatureData = HttpSignature::parseSignatureHeader($signature); + $keyId = Helpers::validateUrl($signatureData['keyId']); + $actor = Profile::whereKeyId($keyId)->whereNotNull('remote_url')->first(); + if(!$actor) { + return false; + } + if(Helpers::validateUrl($actor->remote_url) == false) { + return false; + } + $res = Zttp::timeout(5)->withHeaders([ + 'Accept' => 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"', + 'User-Agent' => 'PixelfedBot v0.1 - https://pixelfed.org', + ])->get($actor->remote_url); + $res = json_decode($res->body(), true, 8); + if($res['publicKey']['id'] !== $actor->key_id) { + return false; + } + $actor->public_key = $res['publicKey']['publicKeyPem']; + $actor->save(); + return $this->verifySignature($headers, $profile, $payload); + } +}