From 004b37d16cbacef966618cf4684bba2193d5bf24 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Fri, 26 Jan 2024 21:35:59 +0100
Subject: [PATCH] Refactoring

---
 app/src/main/java/eu/faircode/email/AdapterMedia.java  |  3 +--
 .../main/java/eu/faircode/email/MediaPlayerHelper.java | 10 +++++++++-
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/AdapterMedia.java b/app/src/main/java/eu/faircode/email/AdapterMedia.java
index f4804ab221..b36644bc7c 100644
--- a/app/src/main/java/eu/faircode/email/AdapterMedia.java
+++ b/app/src/main/java/eu/faircode/email/AdapterMedia.java
@@ -282,7 +282,7 @@ public class AdapterMedia extends RecyclerView.Adapter<AdapterMedia.ViewHolder>
                         if (MediaPlayerHelper.isPlaying(uri))
                             MediaPlayerHelper.stopMusic(context);
                         else
-                            MediaPlayerHelper.startMusic(context, uri,
+                            MediaPlayerHelper.startMusic(context, owner, uri,
                                     new RunnableEx("player") {
                                         @Override
                                         public void delegate() {
@@ -390,7 +390,6 @@ public class AdapterMedia extends RecyclerView.Adapter<AdapterMedia.ViewHolder>
             @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
             public void onDestroyed() {
                 Log.d(AdapterMedia.this + " parent destroyed");
-                MediaPlayerHelper.stopMusic(context);
                 AdapterMedia.this.parentFragment = null;
                 owner.getLifecycle().removeObserver(this);
             }
diff --git a/app/src/main/java/eu/faircode/email/MediaPlayerHelper.java b/app/src/main/java/eu/faircode/email/MediaPlayerHelper.java
index c1df73b361..3ffd0c708a 100644
--- a/app/src/main/java/eu/faircode/email/MediaPlayerHelper.java
+++ b/app/src/main/java/eu/faircode/email/MediaPlayerHelper.java
@@ -161,7 +161,7 @@ public class MediaPlayerHelper {
         }
     }
 
-    static void startMusic(Context context, Uri uri, Runnable onCompleted) throws IOException {
+    static void startMusic(Context context, LifecycleOwner owner, Uri uri, Runnable onCompleted) throws IOException {
         synchronized (lock) {
             stopMusic(context);
 
@@ -192,6 +192,14 @@ public class MediaPlayerHelper {
             });
             MediaPlayerHelper.player.prepareAsync();
         }
+
+        owner.getLifecycle().addObserver(new LifecycleObserver() {
+            @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
+            public void onDestroyed() {
+                MediaPlayerHelper.stopMusic(context);
+                owner.getLifecycle().removeObserver(this);
+            }
+        });
     }
 
     static void stopMusic(Context context) {