From 9ca2edece5a38ac8b0d94bd95e4c0b8647951ae2 Mon Sep 17 00:00:00 2001 From: M66B Date: Sat, 10 Feb 2024 12:36:02 +0100 Subject: [PATCH 1/3] Sync-a-lot warnings --- app/src/main/res/layout/dialog_sync.xml | 1 + app/src/main/res/layout/fragment_folder.xml | 22 +++++++++++++++++---- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/app/src/main/res/layout/dialog_sync.xml b/app/src/main/res/layout/dialog_sync.xml index 92f8756361..4f5ee23971 100644 --- a/app/src/main/res/layout/dialog_sync.xml +++ b/app/src/main/res/layout/dialog_sync.xml @@ -93,6 +93,7 @@ android:layout_marginTop="12dp" android:text="@string/title_synchronize_more_hint3" android:textAppearance="@style/TextAppearance.AppCompat.Small" + android:textColor="?attr/colorWarning" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/tvRemark2" /> diff --git a/app/src/main/res/layout/fragment_folder.xml b/app/src/main/res/layout/fragment_folder.xml index 6d369e00e8..185937252c 100644 --- a/app/src/main/res/layout/fragment_folder.xml +++ b/app/src/main/res/layout/fragment_folder.xml @@ -278,9 +278,10 @@ android:id="@+id/tvSyncDays" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginTop="12dp" + android:layout_marginTop="24dp" android:text="@string/title_sync_days" android:textAppearance="@style/TextAppearance.AppCompat.Small" + android:textColor="?android:textColorPrimary" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/tvAutoClassifyPro" /> @@ -322,9 +323,10 @@ android:id="@+id/tvKeepDays" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginTop="12dp" + android:layout_marginTop="24dp" android:text="@string/title_keep_days" android:textAppearance="@style/TextAppearance.AppCompat.Small" + android:textColor="?android:textColorPrimary" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/etSyncDays" /> @@ -360,6 +362,18 @@ app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/etKeepDays" /> + + + app:layout_constraintTop_toBottomOf="@id/tvKeepRemark" /> Date: Sat, 10 Feb 2024 12:50:42 +0100 Subject: [PATCH 2/3] Updated FAQ --- FAQ.md | 2 ++ index.html | 1 + 2 files changed, 3 insertions(+) diff --git a/FAQ.md b/FAQ.md index 07a5b26229..b4f6c63c65 100644 --- a/FAQ.md +++ b/FAQ.md @@ -5775,6 +5775,8 @@ Requested features should: * comply with common standards (IMAP, SMTP, etc.) * comply with the [Core app quality guidelines](https://developer.android.com/docs/quality-guidelines/core-app-quality) +Features unrelated to email, including reading newsgroups and reading RSS feeds, fall outside the scope of the project. + The goal of the design is to be minimalistic (no unnecessary menus, buttons, etc) and non distracting (no fancy colors, animations, etc). All displayed things should be useful in one or another way and should be carefully positioned for easy usage. Fonts, sizes, colors, etc should be material design whenever possible. diff --git a/index.html b/index.html index 21017eac53..2a30ffa842 100644 --- a/index.html +++ b/index.html @@ -2825,6 +2825,7 @@ adb install /path/to/FairEmail-xxx.apk
  • comply with common standards (IMAP, SMTP, etc.)
  • comply with the Core app quality guidelines
    • +

    Features unrelated to email, including reading newsgroups and reading RSS feeds, fall outside the scope of the project.

    The goal of the design is to be minimalistic (no unnecessary menus, buttons, etc) and non distracting (no fancy colors, animations, etc). All displayed things should be useful in one or another way and should be carefully positioned for easy usage. Fonts, sizes, colors, etc should be material design whenever possible.

    There are requests daily to change the appearance in this or that way, but the problem is that these requests are more often than not conflicting. To prevent making other people unhappy, changes in the appearance always need to clearly and objectively contribute to the usability of the app to be considered.

    A feature will be considered useful to most people if more than 0.1% of the users request a feature, which in practice means about 500 people.

    From 95a4358b6a414c5da6e91c96b3ae07ce5cbe2b28 Mon Sep 17 00:00:00 2001 From: M66B Date: Sat, 10 Feb 2024 13:15:07 +0100 Subject: [PATCH 3/3] Printable barcode texts --- app/src/main/java/eu/faircode/email/AdapterMedia.java | 2 +- app/src/main/java/eu/faircode/email/Helper.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/eu/faircode/email/AdapterMedia.java b/app/src/main/java/eu/faircode/email/AdapterMedia.java index 46012753e6..6dd189f2a1 100644 --- a/app/src/main/java/eu/faircode/email/AdapterMedia.java +++ b/app/src/main/java/eu/faircode/email/AdapterMedia.java @@ -232,7 +232,7 @@ public class AdapterMedia extends RecyclerView.Adapter BinaryBitmap bBitmap = new BinaryBitmap(new HybridBinarizer(source)); MultiFormatReader reader = new MultiFormatReader(); Result result = reader.decode(bBitmap); - args.putString("barcode_text", result.getText()); + args.putString("barcode_text", Helper.getPrintableString(result.getText())); args.putString("barcode_format", result.getBarcodeFormat().name()); } catch (NotFoundException ex) { Log.w(ex); diff --git a/app/src/main/java/eu/faircode/email/Helper.java b/app/src/main/java/eu/faircode/email/Helper.java index 311043f7ef..a7f5f3c1bc 100644 --- a/app/src/main/java/eu/faircode/email/Helper.java +++ b/app/src/main/java/eu/faircode/email/Helper.java @@ -2186,6 +2186,8 @@ public class Helper { // https://issuetracker.google.com/issues/37054851 static String getPrintableString(String value) { + if (TextUtils.isEmpty(value)) + return value; StringBuilder result = new StringBuilder(); for (int i = 0; i < value.length(); i++) { char kar = value.charAt(i);