mirror/FairEmail
1
0
Fork 0
mirror of https://github.com/M66B/FairEmail.git synced 2025-02-24 23:12:55 +00:00
Code Issues Releases Wiki Activity

Simple task fixes

Browse source
This commit is contained in:
M66B 2018-08-16 11:23:30 +00:00
parent 1b7e79012b
commit 27683fda58
1 changed files with 39 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
app/src/main/java/eu/faircode/email/SimpleTask.java
View file

@ -36,15 +36,17 @@ import androidx.lifecycle.OnLifecycleEvent;
// //
// This simple task is simple to use, but it is also simple to cause bugs that can easily lead to crashes // This simple task is simple to use, but it is also simple to cause bugs that can easily lead to crashes
// Make sure to not access any member in any outer scope from onLoad // Make sure to not access any member in any outer scope from onLoad
// Results will not be delivered to destroyed fragments
// //
public abstract class SimpleTask<T> implements LifecycleObserver { public abstract class SimpleTask<T> implements LifecycleObserver {
private LifecycleOwner owner;
private boolean paused = false; private boolean paused = false;
private Bundle args = null; private Bundle args = null;
private Result stored = null; private Result stored = null;
static HandlerThread handlerThread; private static HandlerThread handlerThread;
static Handler handler; private static Handler handler;
static { static {
handlerThread = new HandlerThread("SimpleTask"); handlerThread = new HandlerThread("SimpleTask");
@ -64,14 +66,26 @@ public abstract class SimpleTask<T> implements LifecycleObserver {
run(activity, activity, args); run(activity, activity, args);
} }
public void load(Fragment fragment, Bundle args) { public void load(final Fragment fragment, Bundle args) {
run(fragment.getContext(), fragment.getViewLifecycleOwner(), args); run(fragment.getContext(), fragment.getViewLifecycleOwner(), args);
} }
@OnLifecycleEvent(Lifecycle.Event.ON_START)
public void onStart() {
Log.i(Helper.TAG, "Start task " + this);
}
@OnLifecycleEvent(Lifecycle.Event.ON_STOP)
public void onStop() {
Log.i(Helper.TAG, "Resume tak " + this);
}
@OnLifecycleEvent(Lifecycle.Event.ON_RESUME) @OnLifecycleEvent(Lifecycle.Event.ON_RESUME)
public void onResume() { public void onResume() {
Log.i(Helper.TAG, "Resume task " + this);
paused = false; paused = false;
if (stored != null) { if (stored != null) {
Log.i(Helper.TAG, "Deferred delivery task " + this);
deliver(args, stored); deliver(args, stored);
stored = null; stored = null;
} }
@ -79,17 +93,27 @@ public abstract class SimpleTask<T> implements LifecycleObserver {
@OnLifecycleEvent(Lifecycle.Event.ON_PAUSE) @OnLifecycleEvent(Lifecycle.Event.ON_PAUSE)
public void onPause() { public void onPause() {
Log.i(Helper.TAG, "Pause task " + this);
paused = true; paused = true;
} }
@OnLifecycleEvent(Lifecycle.Event.ON_CREATE)
public void onCreated() {
Log.i(Helper.TAG, "Created task " + this);
}
@OnLifecycleEvent(Lifecycle.Event.ON_DESTROY) @OnLifecycleEvent(Lifecycle.Event.ON_DESTROY)
public void onDestroyed() { public void onDestroyed() {
Log.i(Helper.TAG, "Destroy task " + this);
owner.getLifecycle().removeObserver(this);
owner = null;
paused = true; paused = true;
args = null; args = null;
stored = null; stored = null;
} }
private void run(final Context context, LifecycleOwner owner, final Bundle args) { private void run(final Context context, LifecycleOwner owner, final Bundle args) {
this.owner = owner;
owner.getLifecycle().addObserver(this); owner.getLifecycle().addObserver(this);
// Run in background thread // Run in background thread
@ -118,13 +142,21 @@ public abstract class SimpleTask<T> implements LifecycleObserver {
private void deliver(Bundle args, Result result) { private void deliver(Bundle args, Result result) {
if (paused) { if (paused) {
Log.i(Helper.TAG, "Deferring delivery task " + this);
this.args = args; this.args = args;
this.stored = result; this.stored = result;
} else { } else {
if (result.ex == null) Log.i(Helper.TAG, "Delivery task " + this);
onLoaded(args, (T) result.data); try {
else if (result.ex == null)
onException(args, result.ex); onLoaded(args, (T) result.data);
else
onException(args, result.ex);
} catch (Throwable ex) {
Log.e(Helper.TAG, ex + "\n" + Log.getStackTraceString(ex));
} finally {
onDestroyed();
}
} }
} }