Simplification

This commit is contained in:
M66B 2022-04-18 09:06:25 +02:00
parent bbe7184a55
commit 3cc9856daf
1 changed files with 29 additions and 56 deletions

View File

@ -40,60 +40,33 @@ public class CoalMine {
static void setup(boolean enabled) { static void setup(boolean enabled) {
List<ObjectInspector> inspectors = new ArrayList<>(LeakCanary.getConfig().getObjectInspectors()); List<ObjectInspector> inspectors = new ArrayList<>(LeakCanary.getConfig().getObjectInspectors());
// https://square.github.io/leakcanary/recipes/#identifying-leaking-objects-and-labeling-objects
for (Class<?> clazz : new Class<?>[]{SimpleTask.class, TwoStateOwner.class, RunnableEx.class})
inspectors.add(new ObjectInspector() { inspectors.add(new ObjectInspector() {
@Override @Override
public void inspect(@NonNull ObjectReporter reporter) { public void inspect(@NonNull ObjectReporter reporter) {
String clazz = SimpleTask.class.getName(); String className = clazz.getName();
reporter.whenInstanceOf(clazz, new Function2<ObjectReporter, HeapObject.HeapInstance, Unit>() { reporter.whenInstanceOf(className, new Function2<ObjectReporter, HeapObject.HeapInstance, Unit>() {
@Override @Override
public Unit invoke(ObjectReporter reporter, HeapObject.HeapInstance instance) { public Unit invoke(ObjectReporter reporter, HeapObject.HeapInstance instance) {
HeapField fname = instance.get(clazz, "name"); HeapField hfName = instance.get(className, "name");
if (fname != null) { if (hfName != null) {
String name = fname.getValue().readAsJavaString(); String label = hfName.getValue().readAsJavaString();
reporter.getNotLeakingReasons().add("name=" + name); reporter.getLabels().add("name=" + label);
} }
HeapField fstarted = instance.get(clazz, "started");
if (fstarted != null) {
Long started = fstarted.getValue().getAsLong();
if (started != null)
reporter.getNotLeakingReasons().add("started=" + new Date(started));
}
return null;
}
});
}
});
inspectors.add(new ObjectInspector() { // Could be different class loader
@Override if (className.equals(SimpleTask.class.getName())) {
public void inspect(@NonNull ObjectReporter reporter) { HeapField hfStarted = instance.get(className, "started");
String clazz = TwoStateOwner.class.getName(); if (hfStarted != null) {
reporter.whenInstanceOf(clazz, new Function2<ObjectReporter, HeapObject.HeapInstance, Unit>() { Long started = hfStarted.getValue().getAsLong();
@Override if (started != null) {
public Unit invoke(ObjectReporter reporter, HeapObject.HeapInstance instance) { String label = (started == 0 ? null : new Date(started).toString());
HeapField fname = instance.get(clazz, "name"); reporter.getLabels().add("started=" + label);
if (fname != null) {
String name = fname.getValue().readAsJavaString();
reporter.getNotLeakingReasons().add("name=" + name);
} }
return null;
} }
});
} }
});
inspectors.add(new ObjectInspector() {
@Override
public void inspect(@NonNull ObjectReporter reporter) {
String clazz = RunnableEx.class.getName();
reporter.whenInstanceOf(clazz, new Function2<ObjectReporter, HeapObject.HeapInstance, Unit>() {
@Override
public Unit invoke(ObjectReporter reporter, HeapObject.HeapInstance instance) {
HeapField fname = instance.get(clazz, "name");
if (fname != null) {
String name = fname.getValue().readAsJavaString();
reporter.getNotLeakingReasons().add("name=" + name);
}
return null; return null;
} }
}); });