mirror
/
FairEmail
mirror of https://github.com/M66B/FairEmail.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Improved error handling

This commit is contained in:
M66B 2018-12-29 16:10:21 +00:00
parent 2bebb4729d
commit 9538804ba0
2 changed files with 31 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
app/src/main/java/eu/faircode/email/FragmentAccount.java
View File

@ -447,13 +447,13 @@ public class FragmentAccount extends FragmentEx {
int auth_type = args.getInt("auth_type"); int auth_type = args.getInt("auth_type");
if (TextUtils.isEmpty(host)) if (TextUtils.isEmpty(host))
throw new Throwable(context.getString(R.string.title_no_host)); throw new IllegalArgumentException(context.getString(R.string.title_no_host));
if (TextUtils.isEmpty(port)) if (TextUtils.isEmpty(port))
port = (starttls ? "143" : "993"); port = (starttls ? "143" : "993");
if (TextUtils.isEmpty(user)) if (TextUtils.isEmpty(user))
throw new Throwable(context.getString(R.string.title_no_user)); throw new IllegalArgumentException(context.getString(R.string.title_no_user));
if (TextUtils.isEmpty(password) && !insecure) if (TextUtils.isEmpty(password) && !insecure)
throw new Throwable(context.getString(R.string.title_no_password)); throw new IllegalArgumentException(context.getString(R.string.title_no_password));
CheckResult result = new CheckResult(); CheckResult result = new CheckResult();
result.folders = new ArrayList<>(); result.folders = new ArrayList<>();
@ -550,11 +550,14 @@ public class FragmentAccount extends FragmentEx {
grpFolders.setVisibility(View.GONE); grpFolders.setVisibility(View.GONE);
btnSave.setVisibility(View.GONE); btnSave.setVisibility(View.GONE);
new DialogBuilderLifecycle(getContext(), getViewLifecycleOwner()) if (ex instanceof IllegalArgumentException)
.setMessage(Helper.formatThrowable(ex)) Snackbar.make(view, ex.getMessage(), Snackbar.LENGTH_LONG).show();
.setPositiveButton(android.R.string.cancel, null) else
.create() new DialogBuilderLifecycle(getContext(), getViewLifecycleOwner())
.show(); .setMessage(Helper.formatThrowable(ex))
.setPositiveButton(android.R.string.cancel, null)
.create()
.show();
} }
}.load(FragmentAccount.this, args); }.load(FragmentAccount.this, args);
} }
@ -645,17 +648,17 @@ public class FragmentAccount extends FragmentEx {
EntityFolder junk = (EntityFolder) args.getSerializable("junk"); EntityFolder junk = (EntityFolder) args.getSerializable("junk");
if (TextUtils.isEmpty(host)) if (TextUtils.isEmpty(host))
throw new Throwable(context.getString(R.string.title_no_host)); throw new IllegalArgumentException(context.getString(R.string.title_no_host));
if (TextUtils.isEmpty(port)) if (TextUtils.isEmpty(port))
port = (starttls ? "143" : "993"); port = (starttls ? "143" : "993");
if (TextUtils.isEmpty(user)) if (TextUtils.isEmpty(user))
throw new Throwable(context.getString(R.string.title_no_user)); throw new IllegalArgumentException(context.getString(R.string.title_no_user));
if (synchronize && TextUtils.isEmpty(password) && !insecure) if (synchronize && TextUtils.isEmpty(password) && !insecure)
throw new Throwable(context.getString(R.string.title_no_password)); throw new IllegalArgumentException(context.getString(R.string.title_no_password));
if (TextUtils.isEmpty(interval)) if (TextUtils.isEmpty(interval))
interval = "19"; interval = "19";
if (synchronize && drafts == null) if (synchronize && drafts == null)
throw new Throwable(context.getString(R.string.title_no_drafts)); throw new IllegalArgumentException(context.getString(R.string.title_no_drafts));
if (Color.TRANSPARENT == color) if (Color.TRANSPARENT == color)
color = null; color = null;
@ -837,11 +840,14 @@ public class FragmentAccount extends FragmentEx {
btnSave.setEnabled(true); btnSave.setEnabled(true);
pbSave.setVisibility(View.GONE); pbSave.setVisibility(View.GONE);
new DialogBuilderLifecycle(getContext(), getViewLifecycleOwner()) if (ex instanceof IllegalArgumentException)
.setMessage(Helper.formatThrowable(ex)) Snackbar.make(view, ex.getMessage(), Snackbar.LENGTH_LONG).show();
.setPositiveButton(android.R.string.cancel, null) else
.create() new DialogBuilderLifecycle(getContext(), getViewLifecycleOwner())
.show(); .setMessage(Helper.formatThrowable(ex))
.setPositiveButton(android.R.string.cancel, null)
.create()
.show();
} }
}.load(FragmentAccount.this, args); }.load(FragmentAccount.this, args);
} }

13
app/src/main/java/eu/faircode/email/FragmentIdentity.java
View File

@ -600,11 +600,14 @@ public class FragmentIdentity extends FragmentEx {
btnSave.setEnabled(true); btnSave.setEnabled(true);
pbSave.setVisibility(View.GONE); pbSave.setVisibility(View.GONE);
new DialogBuilderLifecycle(getContext(), getViewLifecycleOwner()) if (ex instanceof IllegalArgumentException)
.setMessage(Helper.formatThrowable(ex)) Snackbar.make(view, ex.getMessage(), Snackbar.LENGTH_LONG).show();
.setPositiveButton(android.R.string.cancel, null) else
.create() new DialogBuilderLifecycle(getContext(), getViewLifecycleOwner())
.show(); .setMessage(Helper.formatThrowable(ex))
.setPositiveButton(android.R.string.cancel, null)
.create()
.show();
} }
}.load(FragmentIdentity.this, args); }.load(FragmentIdentity.this, args);
} }