Simplified error reporting / review requests

This commit is contained in:
M66B 2020-01-07 08:51:30 +01:00
parent aff5437184
commit 971c2d1cd4
3 changed files with 14 additions and 40 deletions

View File

@ -5518,7 +5518,6 @@ public class FragmentMessages extends FragmentBase implements SharedPreferences.
public Dialog onCreateDialog(@Nullable Bundle savedInstanceState) {
View dview = LayoutInflater.from(getContext()).inflate(R.layout.dialog_error_reporting, null);
Button btnInfo = dview.findViewById(R.id.btnInfo);
CheckBox cbNotAgain = dview.findViewById(R.id.cbNotAgain);
btnInfo.setOnClickListener(new View.OnClickListener() {
@Override
@ -5527,14 +5526,6 @@ public class FragmentMessages extends FragmentBase implements SharedPreferences.
}
});
cbNotAgain.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
@Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(getContext());
prefs.edit().putBoolean("crash_reports_asked", isChecked).apply();
}
});
return new AlertDialog.Builder(getContext())
.setView(dview)
.setPositiveButton(android.R.string.yes, new DialogInterface.OnClickListener() {
@ -5545,7 +5536,13 @@ public class FragmentMessages extends FragmentBase implements SharedPreferences.
Log.setCrashReporting(true);
}
})
.setNegativeButton(android.R.string.no, null)
.setNegativeButton(android.R.string.no, new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(getContext());
prefs.edit().putBoolean("crash_reports_asked", true).apply();
}
})
.create();
}
}
@ -5555,15 +5552,6 @@ public class FragmentMessages extends FragmentBase implements SharedPreferences.
@Override
public Dialog onCreateDialog(@Nullable Bundle savedInstanceState) {
View dview = LayoutInflater.from(getContext()).inflate(R.layout.dialog_review, null);
CheckBox cbNotAgain = dview.findViewById(R.id.cbNotAgain);
cbNotAgain.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
@Override
public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(getContext());
prefs.edit().putBoolean("review_asked", isChecked).apply();
}
});
return new AlertDialog.Builder(getContext())
.setView(dview)
@ -5575,7 +5563,13 @@ public class FragmentMessages extends FragmentBase implements SharedPreferences.
startActivity(Helper.getIntentRate(getContext()));
}
})
.setNegativeButton(android.R.string.no, null)
.setNegativeButton(android.R.string.no, new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(getContext());
prefs.edit().putBoolean("review_asked", true).apply();
}
})
.setNeutralButton(R.string.title_later, new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {

View File

@ -52,15 +52,5 @@
app:layout_constraintStart_toEndOf="@id/btnInfo"
app:layout_constraintTop_toTopOf="@id/btnInfo"
app:srcCompat="@drawable/baseline_open_in_new_24" />
<CheckBox
android:id="@+id/cbNotAgain"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="12dp"
android:text="@string/title_no_ask_again"
android:textAppearance="@style/TextAppearance.AppCompat.Small"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/btnInfo" />
</androidx.constraintlayout.widget.ConstraintLayout>
</ScrollView>

View File

@ -30,15 +30,5 @@
android:textColor="?android:attr/textColorPrimary"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/tvMessage" />
<CheckBox
android:id="@+id/cbNotAgain"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginTop="12dp"
android:text="@string/title_no_ask_again"
android:textAppearance="@style/TextAppearance.AppCompat.Small"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/tvExplanation" />
</androidx.constraintlayout.widget.ConstraintLayout>
</ScrollView>