From 9ec206f150679a3a2a8707dd04d64280971aaae2 Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Mon, 20 Jan 2020 17:42:35 +0100
Subject: [PATCH] Moved edit as new to reply menu

---
 .../eu/faircode/email/AdapterMessage.java     | 30 +++++++++----------
 app/src/main/res/menu/popup_message_more.xml  |  4 ---
 app/src/main/res/menu/popup_reply.xml         | 12 +++++---
 3 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/AdapterMessage.java b/app/src/main/java/eu/faircode/email/AdapterMessage.java
index c672b13f3a..6c137d1afb 100644
--- a/app/src/main/java/eu/faircode/email/AdapterMessage.java
+++ b/app/src/main/java/eu/faircode/email/AdapterMessage.java
@@ -2889,8 +2889,8 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
                     popupMenu.getMenu().findItem(R.id.menu_reply_to_all).setVisible(recipients.length > 0);
                     popupMenu.getMenu().findItem(R.id.menu_reply_list).setVisible(message.list_post != null);
                     popupMenu.getMenu().findItem(R.id.menu_reply_receipt).setVisible(message.receipt_to != null);
-                    popupMenu.getMenu().findItem(R.id.menu_reply_answer).setVisible(answers != 0 || !ActivityBilling.isPro(context));
                     popupMenu.getMenu().findItem(R.id.menu_new_message).setVisible(to != null && to.length > 0);
+                    popupMenu.getMenu().findItem(R.id.menu_reply_answer).setVisible(answers != 0 || !ActivityBilling.isPro(context));
 
                     popupMenu.setOnMenuItemClickListener(new PopupMenu.OnMenuItemClickListener() {
                         @Override
@@ -2908,15 +2908,18 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
                                 case R.id.menu_reply_receipt:
                                     onMenuReply(message, "receipt");
                                     return true;
-                                case R.id.menu_reply_answer:
-                                    onMenuAnswer(message);
-                                    return true;
                                 case R.id.menu_forward:
                                     onMenuReply(message, "forward");
                                     return true;
+                                case R.id.menu_editasnew:
+                                    onMenuEditAsNew(message);
+                                    return true;
                                 case R.id.menu_new_message:
                                     onMenuNew(message, to);
                                     return true;
+                                case R.id.menu_reply_answer:
+                                    onMenuAnswer(message);
+                                    return true;
                                 default:
                                     return false;
                             }
@@ -2939,6 +2942,13 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
             context.startActivity(reply);
         }
 
+        private void onMenuEditAsNew(final TupleMessageEx message) {
+            Intent asnew = new Intent(context, ActivityCompose.class)
+                    .putExtra("action", "editasnew")
+                    .putExtra("reference", message.id);
+            context.startActivity(asnew);
+        }
+
         private void onMenuNew(TupleMessageEx message, Address[] to) {
             Intent reply = new Intent(context, ActivityCompose.class)
                     .putExtra("action", "new")
@@ -3114,8 +3124,6 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
             PopupMenuLifecycle popupMenu = new PopupMenuLifecycle(context, powner, anchor);
             popupMenu.inflate(R.menu.popup_message_more);
 
-            popupMenu.getMenu().findItem(R.id.menu_editasnew).setEnabled(message.content);
-
             popupMenu.getMenu().findItem(R.id.menu_unseen).setTitle(message.ui_seen ? R.string.title_unseen : R.string.title_seen);
             popupMenu.getMenu().findItem(R.id.menu_unseen).setEnabled(
                     (message.uid != null && !message.folderReadOnly) || message.accountProtocol != EntityAccount.TYPE_IMAP);
@@ -3157,9 +3165,6 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
                 @Override
                 public boolean onMenuItemClick(MenuItem target) {
                     switch (target.getItemId()) {
-                        case R.id.menu_editasnew:
-                            onMenuEditAsNew(message);
-                            return true;
                         case R.id.menu_unseen:
                             onMenuUnseen(message);
                             return true;
@@ -3323,13 +3328,6 @@ public class AdapterMessage extends RecyclerView.Adapter<AdapterMessage.ViewHold
             fragment.show(parentFragment.getParentFragmentManager(), "view:image");
         }
 
-        private void onMenuEditAsNew(final TupleMessageEx message) {
-            Intent asnew = new Intent(context, ActivityCompose.class)
-                    .putExtra("action", "editasnew")
-                    .putExtra("reference", message.id);
-            context.startActivity(asnew);
-        }
-
         private void onMenuUnseen(final TupleMessageEx message) {
             Bundle args = new Bundle();
             args.putLong("id", message.id);
diff --git a/app/src/main/res/menu/popup_message_more.xml b/app/src/main/res/menu/popup_message_more.xml
index 9ed1d03574..a25953c197 100644
--- a/app/src/main/res/menu/popup_message_more.xml
+++ b/app/src/main/res/menu/popup_message_more.xml
@@ -1,9 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <menu xmlns:android="http://schemas.android.com/apk/res/android">
-    <item
-        android:id="@+id/menu_editasnew"
-        android:title="@string/title_editasnew" />
-
     <item
         android:id="@+id/menu_unseen"
         android:title="@string/title_unseen" />
diff --git a/app/src/main/res/menu/popup_reply.xml b/app/src/main/res/menu/popup_reply.xml
index 8a0e0e0c5f..26e29bdcf2 100644
--- a/app/src/main/res/menu/popup_reply.xml
+++ b/app/src/main/res/menu/popup_reply.xml
@@ -16,15 +16,19 @@
         android:id="@+id/menu_reply_receipt"
         android:title="@string/title_reply_receipt" />
 
-    <item
-        android:id="@+id/menu_reply_answer"
-        android:title="@string/title_reply_template" />
-
     <item
         android:id="@+id/menu_forward"
         android:title="@string/title_forward" />
 
+    <item
+        android:id="@+id/menu_editasnew"
+        android:title="@string/title_editasnew" />
+
     <item
         android:id="@+id/menu_new_message"
         android:title="@string/title_new_message" />
+
+    <item
+        android:id="@+id/menu_reply_answer"
+        android:title="@string/title_reply_template" />
 </menu>
\ No newline at end of file