From b30a8d9b8a32a8449e3947c5ace5a609c6be37dc Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Tue, 22 Sep 2020 13:08:09 +0200
Subject: [PATCH] Simplify operation handling

---
 app/src/main/java/eu/faircode/email/Core.java | 63 ++-----------------
 .../eu/faircode/email/ServiceSynchronize.java |  5 +-
 2 files changed, 5 insertions(+), 63 deletions(-)

diff --git a/app/src/main/java/eu/faircode/email/Core.java b/app/src/main/java/eu/faircode/email/Core.java
index 0de4667716..110cc2de84 100644
--- a/app/src/main/java/eu/faircode/email/Core.java
+++ b/app/src/main/java/eu/faircode/email/Core.java
@@ -150,7 +150,7 @@ class Core {
             Context context,
             EntityAccount account, EntityFolder folder, List<TupleOperationEx> ops,
             Store istore, Folder ifolder,
-            State state, int priority, long sequence)
+            State state)
             throws JSONException {
         try {
             Log.i(folder.name + " start process");
@@ -160,9 +160,7 @@ class Core {
             int retry = 0;
             boolean group = true;
             Log.i(folder.name + " executing operations=" + ops.size());
-            while (retry < LOCAL_RETRY_MAX && ops.size() > 0 &&
-                    state.isRunning() &&
-                    state.batchCanRun(folder.id, priority, sequence)) {
+            while (retry < LOCAL_RETRY_MAX && ops.size() > 0 && state.isRunning()) {
                 TupleOperationEx op = ops.get(0);
 
                 try {
@@ -500,9 +498,7 @@ class Core {
                             ops.remove(op);
                         } else {
                             retry++;
-                            if (retry < LOCAL_RETRY_MAX &&
-                                    state.isRunning() &&
-                                    state.batchCanRun(folder.id, priority, sequence))
+                            if (retry < LOCAL_RETRY_MAX && state.isRunning())
                                 try {
                                     Thread.sleep(LOCAL_RETRY_DELAY);
                                 } catch (InterruptedException ex1) {
@@ -528,9 +524,7 @@ class Core {
                 }
             }
 
-            if (ops.size() == 0)
-                state.batchCompleted(folder.id, priority, sequence);
-            else
+            if (ops.size() > 0)
                 state.error(new OperationCanceledException("Processing"));
         } finally {
             Log.i(folder.name + " end process state=" + state + " pending=" + ops.size());
@@ -4064,9 +4058,6 @@ class Core {
         private boolean recoverable = true;
         private Long lastActivity = null;
 
-        private Map<FolderPriority, Long> sequence = new HashMap<>();
-        private Map<FolderPriority, Long> batch = new HashMap<>();
-
         State(ConnectionHelper.NetworkState networkState) {
             this.networkState = networkState;
         }
@@ -4146,17 +4137,6 @@ class Core {
         void reset() {
             recoverable = true;
             lastActivity = null;
-            resetBatches();
-        }
-
-        void resetBatches() {
-            synchronized (this) {
-                for (FolderPriority key : sequence.keySet()) {
-                    batch.put(key, sequence.get(key));
-                    if (BuildConfig.DEBUG)
-                        Log.i("=== Reset " + key.folder + ":" + key.priority + " batch=" + batch.get(key));
-                }
-            }
         }
 
         private void yield() {
@@ -4229,41 +4209,6 @@ class Core {
             return (last == null ? 0 : SystemClock.elapsedRealtime() - last);
         }
 
-        long getSequence(long folder, int priority) {
-            synchronized (this) {
-                FolderPriority key = new FolderPriority(folder, priority);
-                if (!sequence.containsKey(key)) {
-                    sequence.put(key, 0L);
-                    batch.put(key, 0L);
-                }
-                long result = sequence.get(key);
-                sequence.put(key, result + 1);
-                if (BuildConfig.DEBUG)
-                    Log.i("=== Get " + folder + ":" + priority + " sequence=" + result);
-                return result;
-            }
-        }
-
-        boolean batchCanRun(long folder, int priority, long current) {
-            synchronized (this) {
-                FolderPriority key = new FolderPriority(folder, priority);
-                boolean can = batch.get(key).equals(current);
-                if (BuildConfig.DEBUG)
-                    Log.i("=== Can " + folder + ":" + priority + " can=" + can);
-                return can;
-            }
-        }
-
-        void batchCompleted(long folder, int priority, long current) {
-            synchronized (this) {
-                FolderPriority key = new FolderPriority(folder, priority);
-                if (batch.get(key).equals(current))
-                    batch.put(key, batch.get(key) + 1);
-                if (BuildConfig.DEBUG)
-                    Log.i("=== Completed " + folder + ":" + priority + " next=" + batch.get(key));
-            }
-        }
-
         @NonNull
         @Override
         public String toString() {
diff --git a/app/src/main/java/eu/faircode/email/ServiceSynchronize.java b/app/src/main/java/eu/faircode/email/ServiceSynchronize.java
index 1ef11eb66d..031f4a7bb4 100644
--- a/app/src/main/java/eu/faircode/email/ServiceSynchronize.java
+++ b/app/src/main/java/eu/faircode/email/ServiceSynchronize.java
@@ -1296,8 +1296,6 @@ public class ServiceSynchronize extends ServiceBase implements SharedPreferences
                                                             " operations=" + partitions.get(key).size());
                                                 }
 
-                                                final long sequence = state.getSequence(folder.id, key.getPriority());
-
                                                 handler.post(new Helper.PriorityRunnable(key.getPriority(), key.getOrder()) {
                                                     @Override
                                                     public void run() {
@@ -1362,7 +1360,7 @@ public class ServiceSynchronize extends ServiceBase implements SharedPreferences
                                                                         account, folder,
                                                                         partition,
                                                                         iservice.getStore(), ifolder,
-                                                                        state, key.getPriority(), sequence);
+                                                                        state);
 
                                                             } catch (Throwable ex) {
                                                                 Log.e(folder.name, ex);
@@ -1613,7 +1611,6 @@ public class ServiceSynchronize extends ServiceBase implements SharedPreferences
                     });
 
                     // Cancel running operations
-                    state.resetBatches();
                     ht.quit();
 
                     // Close folders