mirror
/
FairEmail
mirror of https://github.com/M66B/FairEmail.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Make sure URL connection is closed

This commit is contained in:
M66B 2021-07-15 08:36:55 +02:00
parent 64e48fdc76
commit b8e04341ab
7 changed files with 30 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/eu/faircode/email/ContactInfo.java
View File

@ -354,7 +354,7 @@ public class ContactInfo {
emailGravatar.put(gkey, new Gravatar(false));
}
} else
throw new IOException("HTTP status=" + status);
throw new IOException("Error " + status + ": " + urlConnection.getResponseMessage());
} catch (Throwable ex) {
Log.w(ex);

7
app/src/main/java/eu/faircode/email/ImageHelper.java
View File

@ -639,6 +639,7 @@ class ImageHelper {
urlConnection.setRequestProperty("User-Agent", WebViewEx.getUserAgent(context));
urlConnection.connect();
try {
int status = urlConnection.getResponseCode();
if (status == HttpURLConnection.HTTP_MOVED_PERM ||
@ -662,7 +663,11 @@ class ImageHelper {
}
if (status != HttpURLConnection.HTTP_OK)
throw new IOException("HTTP status=" + status);
throw new IOException("Error " + status + ": " + urlConnection.getResponseMessage());
} catch (IOException ex) {
urlConnection.disconnect();
throw ex;
}
break;
}