From c8f6b77290421161a522df2716c5eb3e0a115309 Mon Sep 17 00:00:00 2001 From: M66B Date: Tue, 3 Mar 2020 19:22:45 +0100 Subject: [PATCH] Revert "Check if account thread is alive" This reverts commit f0b88c8d2c38c352ae44992d78c802f69ac651ba. --- app/src/main/java/eu/faircode/email/Core.java | 4 ---- .../main/java/eu/faircode/email/ServiceSynchronize.java | 9 ++++----- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/app/src/main/java/eu/faircode/email/Core.java b/app/src/main/java/eu/faircode/email/Core.java index b5f38d3a43..c3cdec386f 100644 --- a/app/src/main/java/eu/faircode/email/Core.java +++ b/app/src/main/java/eu/faircode/email/Core.java @@ -3501,10 +3501,6 @@ class Core { join(thread); } - boolean isAlive() { - return thread.isAlive(); - } - boolean isRunning() { return running; } diff --git a/app/src/main/java/eu/faircode/email/ServiceSynchronize.java b/app/src/main/java/eu/faircode/email/ServiceSynchronize.java index 75e15cd805..ba3a4f9e78 100644 --- a/app/src/main/java/eu/faircode/email/ServiceSynchronize.java +++ b/app/src/main/java/eu/faircode/email/ServiceSynchronize.java @@ -236,16 +236,15 @@ public class ServiceSynchronize extends ServiceBase implements SharedPreferences // Some networks disallow email server connections: // - reload on network type change when disconnected - boolean isRunning = (state != null && state.isAlive()); if (reload || - isRunning != current.canRun() || + prev.canRun() != current.canRun() || !prev.accountState.equals(current.accountState) || (!"connected".equals(current.accountState.state) && !Objects.equals(prev.networkState.getType(), current.networkState.getType()))) { - if (isRunning || current.canRun()) + if (prev.canRun() || current.canRun()) EntityLog.log(ServiceSynchronize.this, "### changed " + current + " reload=" + reload + - " stop=" + isRunning + + " stop=" + prev.canRun() + " start=" + current.canRun() + " sync=" + current.accountState.isEnabled(current.enabled) + "/" + sync + " changed=" + !prev.accountState.equals(current.accountState) + @@ -256,7 +255,7 @@ public class ServiceSynchronize extends ServiceBase implements SharedPreferences " tbd=" + current.accountState.tbd + " state=" + current.accountState.state + " type=" + prev.networkState.getType() + "/" + current.networkState.getType()); - if (isRunning) + if (prev.canRun()) stop(prev); if (current.canRun()) start(current, current.accountState.isEnabled(current.enabled) || sync);