From f5fa40f67816294408545b65c2db0ff1fc62d4f0 Mon Sep 17 00:00:00 2001 From: M66B Date: Sun, 15 Nov 2020 20:37:27 +0100 Subject: [PATCH] Always remove empty images --- app/src/main/java/eu/faircode/email/HtmlHelper.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/eu/faircode/email/HtmlHelper.java b/app/src/main/java/eu/faircode/email/HtmlHelper.java index 4e055d379e..c9bcd287f3 100644 --- a/app/src/main/java/eu/faircode/email/HtmlHelper.java +++ b/app/src/main/java/eu/faircode/email/HtmlHelper.java @@ -955,6 +955,11 @@ public class HtmlHelper { String src = img.attr("src"); String tracking = img.attr("x-tracking"); + if (TextUtils.isEmpty(src)) { + img.remove(); + continue; + } + if (alt.length() > MAX_ALT) alt = alt.substring(0, MAX_ALT) + "…"; @@ -1547,11 +1552,8 @@ public class HtmlHelper { img.removeAttr("x-tracking"); String src = img.attr("src"); - if (TextUtils.isEmpty(src)) { - if (!full) - img.remove(); + if (TextUtils.isEmpty(src)) continue; - } Uri uri = Uri.parse(src); String host = uri.getHost();