From f97a0a4b6c79b129a5131c9534333b8a585815de Mon Sep 17 00:00:00 2001
From: M66B <M66B@users.noreply.github.com>
Date: Fri, 3 Nov 2023 11:45:09 +0100
Subject: [PATCH] Added resize remark

---
 .../eu/faircode/email/FragmentDialogAddImage.java   |  2 ++
 app/src/main/res/layout/dialog_add_image.xml        | 13 ++++++++++++-
 app/src/main/res/values/strings.xml                 |  1 +
 3 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/eu/faircode/email/FragmentDialogAddImage.java b/app/src/main/java/eu/faircode/email/FragmentDialogAddImage.java
index 8ffebf3c6d..03020154b0 100644
--- a/app/src/main/java/eu/faircode/email/FragmentDialogAddImage.java
+++ b/app/src/main/java/eu/faircode/email/FragmentDialogAddImage.java
@@ -66,6 +66,7 @@ public class FragmentDialogAddImage extends FragmentDialogBase {
         final ImageButton ibResize = dview.findViewById(R.id.ibResize);
         final Spinner spResize = dview.findViewById(R.id.spResize);
         final TextView tvResize = dview.findViewById(R.id.tvResize);
+        final TextView tvResizeRemark = dview.findViewById(R.id.tvResizeRemark);
         final CheckBox cbPrivacy = dview.findViewById(R.id.cbPrivacy);
         final CheckBox cbNotAgain = dview.findViewById(R.id.cbNotAgain);
         final TextView tvNotAgain = dview.findViewById(R.id.tvNotAgain);
@@ -75,6 +76,7 @@ public class FragmentDialogAddImage extends FragmentDialogBase {
         rgAction.check(add_inline ? R.id.rbInline : R.id.rbAttach);
         cbResize.setChecked(resize_images);
         spResize.setEnabled(resize_images);
+        tvResizeRemark.setText(getString(R.string.title_add_image_resize_remark, "JPEG, PNG, WEBP"));
         cbPrivacy.setChecked(privacy_images);
 
         final int[] resizeValues = getResources().getIntArray(R.array.resizeValues);
diff --git a/app/src/main/res/layout/dialog_add_image.xml b/app/src/main/res/layout/dialog_add_image.xml
index 2782a4398f..87027c1fa6 100644
--- a/app/src/main/res/layout/dialog_add_image.xml
+++ b/app/src/main/res/layout/dialog_add_image.xml
@@ -115,6 +115,17 @@
             app:layout_constraintStart_toEndOf="@id/spResize"
             app:layout_constraintTop_toTopOf="@id/spResize" />
 
+        <TextView
+            android:id="@+id/tvResizeRemark"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_marginTop="12dp"
+            android:text="@string/title_add_image_resize_remark"
+            android:textAppearance="@style/TextAppearance.AppCompat.Small"
+            android:textStyle="italic"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toBottomOf="@id/spResize" />
+
         <CheckBox
             android:id="@+id/cbPrivacy"
             android:layout_width="wrap_content"
@@ -124,7 +135,7 @@
             android:text="@string/title_add_image_privacy"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/spResize" />
+            app:layout_constraintTop_toBottomOf="@id/tvResizeRemark" />
 
         <TextView
             android:id="@+id/tvPrivacy"
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 524301d5e7..07e04c49d9 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -1674,6 +1674,7 @@
     <string name="title_add_image_privacy">Remove privacy sensitive data</string>
     <string name="title_add_image_privacy_remark">Geographic location, serial numbers, file names, etc</string>
     <string name="title_add_resize_pixels">&lt; %1$d pixels</string>
+    <string name="title_add_image_resize_remark">Resizing is supported for: %1$s</string>
     <string name="title_add_image_select_remark">The Android photo picker no longer passes file names</string>
     <string name="title_add_image_select">Select file</string>
     <string name="title_add_attachment">Add attachment</string>