core: implement filters in cardigann json parser (#12922)

2022-02-07 21:54:17 +01:00 · 2022-02-07 21:54:17 +01:00 · 198a6d1f8c
parent 7a7144bd9d
commit 198a6d1f8c
25 changed files with 3326 additions and 31 deletions
--- a/src/Jackett.Common/Definitions/aither-api.yml
+++ b/src/Jackett.Common/Definitions/aither-api.yml
@ -74,10 +74,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/anilibria.yml
+++ b/src/Jackett.Common/Definitions/anilibria.yml
@ -24,8 +24,6 @@ search:
    - path: "https://api.anilibria.tv/v2/{{ if .Keywords }}searchTitles?filter=names,poster.url,code,torrents.list,season.year&limit=100&search={{ .Keywords }}{{ else }}getUpdates?filter=names,poster.url,code,torrents.list,season.year&limit=100{{ end }}"
      response:
        type: json
-        attribute: torrents.list
-        multiple: true

  keywordsfilters:
    # strip season and ep
@ -34,6 +32,8 @@ search:

  rows:
    selector: $
+    attribute: torrents.list
+    multiple: true

  fields:
    category:
--- a/src/Jackett.Common/Definitions/animeworld-api.yml
+++ b/src/Jackett.Common/Definitions/animeworld-api.yml
@ -79,10 +79,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/blutopia-api.yml
+++ b/src/Jackett.Common/Definitions/blutopia-api.yml
@ -66,7 +66,7 @@ search:
    - path: "/api/torrents/filter"
      response:
        type: json
-        attribute: attributes
+
  inputs:
  # if we have an id based search, add Season and Episode as query in name for UNIT3D < v6.  Else pass S/E Params for UNIT3D >= v6
    api_token: "{{ .Config.apikey }}"
@ -83,6 +83,7 @@ search:

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/brsociety-api.yml
+++ b/src/Jackett.Common/Definitions/brsociety-api.yml
@ -67,10 +67,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/datascene-api.yml
+++ b/src/Jackett.Common/Definitions/datascene-api.yml
@ -75,10 +75,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/desitorrents-api.yml
+++ b/src/Jackett.Common/Definitions/desitorrents-api.yml
@ -67,7 +67,6 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  keywordsfilters:
    - name: re_replace
@ -75,6 +74,7 @@ search:

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/hawke-uno.yml
+++ b/src/Jackett.Common/Definitions/hawke-uno.yml
@ -64,10 +64,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/hdolimpo-api.yml
+++ b/src/Jackett.Common/Definitions/hdolimpo-api.yml
@ -68,10 +68,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/internetarchive.yml
+++ b/src/Jackett.Common/Definitions/internetarchive.yml
@ -60,6 +60,7 @@ search:
    - path: advancedsearch.php
      response:
        type: json
+
  inputs:
    q: "{{ if and .Config.titleOnly .Keywords }}title:({{ else }}{{ end }}{{ if .Keywords }}{{ .Keywords }}{{ else }}{{ end }}{{ if and .Config.titleOnly .Keywords }}){{ else }}{{ end }}{{ if .Keywords }} AND {{ else }}{{ end }}format:(\"Archive BitTorrent\"){{ if .Categories }} AND mediatype:({{ join .Categories \" OR \" }}){{ else }}{{ end }}"
    fl[]: "identifier,title,mediatype,item_size,downloads,btih,publicdate"
--- a/src/Jackett.Common/Definitions/reelflix-api.yml
+++ b/src/Jackett.Common/Definitions/reelflix-api.yml
@ -67,10 +67,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/shareisland-api.yml
+++ b/src/Jackett.Common/Definitions/shareisland-api.yml
@ -75,7 +75,6 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  keywordsfilters:
    - name: diacritics
@ -87,6 +86,7 @@ search:

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/skipthecommercials-api.yml
+++ b/src/Jackett.Common/Definitions/skipthecommercials-api.yml
@ -63,7 +63,6 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  keywordsfilters:
    - name: re_replace
@ -71,6 +70,7 @@ search:

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/tellytorrent-api.yml
+++ b/src/Jackett.Common/Definitions/tellytorrent-api.yml
@ -75,10 +75,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/thepiratebay.yml
+++ b/src/Jackett.Common/Definitions/thepiratebay.yml
@ -127,6 +127,7 @@ search:
    - path: "https://apibay.org/{{ if .Keywords }}q.php?q={{ .Keywords }}&cat={{ join .Categories \",\" }}{{ else }}precompiled/data_top100_recent.json{{ end }}"
      response:
        type: json
+
  keywordsfilters:
    # remove it's #8829
    - name: re_replace
--- a/src/Jackett.Common/Definitions/torrentseeds-api.yml
+++ b/src/Jackett.Common/Definitions/torrentseeds-api.yml
@ -76,10 +76,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/trackeros-api.yml
+++ b/src/Jackett.Common/Definitions/trackeros-api.yml
@ -70,10 +70,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/uhd-heaven.yml
+++ b/src/Jackett.Common/Definitions/uhd-heaven.yml
@ -64,10 +64,10 @@ search:
    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
      response:
        type: json
-        attribute: attributes

  rows:
    selector: data
+    attribute: attributes
    count:
      selector: meta.total

--- a/src/Jackett.Common/Definitions/yts.yml
+++ b/src/Jackett.Common/Definitions/yts.yml
@ -53,8 +53,7 @@ search:
    - path: api/v2/list_movies.json
      response:
        type: json
-        attribute: torrents
-        multiple: true
+
  inputs:
    # ignore ' (e.g. search for america's Next Top Model)
    query_term: "{{ if .Query.IMDBID }}{{ .Query.IMDBID }}{{ else }}{{ re_replace .Keywords \"[']\" \"\" }}{{ end }}"
@ -64,6 +63,8 @@ search:

  rows:
    selector: data.movies
+    attribute: torrents
+    multiple: true
    count:
      selector: data.movie_count

--- a/src/Jackett.Common/Indexers/CardigannIndexer.cs
+++ b/src/Jackett.Common/Indexers/CardigannIndexer.cs
@ -58,6 +58,9 @@ namespace Jackett.Common.Indexers
        private static readonly Regex _LogicFunctionRegex = new Regex(
            @$"\b({string.Join("|", _SupportedLogicFunctions.Select(Regex.Escape))})(?:\s+(\(?\.[^\)\s]+\)?|""[^""]+"")){{2,}}");

+        // Matches CSS selectors for the JSON parser
+        private static readonly Regex _JsonSelectorRegex = new Regex(@"\:(?<filter>.+?)\((?<key>.+?)\)(?=:|\z)", RegexOptions.Compiled);
+
        public CardigannIndexer(IIndexerConfigurationService configService, Utils.Clients.WebClient wc, Logger l,
                                IProtectionService ps, ICacheService cs, IndexerDefinition Definition)
            : base(configService: configService,
@ -1212,12 +1215,17 @@ namespace Jackett.Common.Indexers

            if (Selector.Selector != null)
            {
-                var selector_Selector = applyGoTemplateText(Selector.Selector.TrimStart('.'), variables);
-                var selection = parentObj.SelectToken(selector_Selector);
+                var selectorSelector = applyGoTemplateText(Selector.Selector.TrimStart('.'), variables);
+                selectorSelector = JsonParseFieldSelector(parentObj, selectorSelector);
+
+                JToken selection = null;
+                if (selectorSelector != null)
+                    selection = parentObj.SelectToken(selectorSelector);
+
                if (selection == null)
                {
                    if (required)
-                        throw new Exception(string.Format("Selector \"{0}\" didn't match {1}", selector_Selector, parentObj.ToString()));
+                        throw new Exception(string.Format("Selector \"{0}\" didn't match {1}", selectorSelector, parentObj.ToString()));
                    return null;
                }
                value = selection.Value<string>();
@ -1398,14 +1406,14 @@ namespace Jackett.Common.Indexers
                                continue;
                    }

-                    var rowsObj = parsedJson.SelectToken(Search.Rows.Selector);
-                    if (rowsObj == null)
-                        throw new Exception("Error Parsing Rows Selector");
+                    var rowsArray = JsonParseRowsSelector(parsedJson, Search.Rows.Selector);
+                    if (rowsArray == null)
+                        throw new Exception("Error Parsing Rows Selector. There are 0 rows.");

-                    foreach (var Row in rowsObj.Value<JArray>())
+                    foreach (var Row in rowsArray)
                    {
-                        var selObj = SearchPath.Response.Attribute != null ? Row.SelectToken(SearchPath.Response.Attribute).Value<JToken>() : Row;
-                        var mulRows = SearchPath.Response.Multiple == true ? selObj.Values<JObject>() : new List<JObject> { selObj.Value<JObject>() };
+                        var selObj = Search.Rows.Attribute != null ? Row.SelectToken(Search.Rows.Attribute).Value<JToken>() : Row;
+                        var mulRows = Search.Rows.Multiple ? selObj.Values<JObject>() : new List<JObject> { selObj.Value<JObject>() };

                        foreach (var mulRow in mulRows)
                        {
@ -2088,6 +2096,71 @@ namespace Jackett.Common.Indexers
            }
            return SkipRelease;
        }
+
+        private JArray JsonParseRowsSelector(JToken parsedJson, string rowSelector)
+        {
+            var selector = rowSelector.Split(':')[0];
+            var rowsObj = parsedJson.SelectToken(selector).Value<JArray>();
+            return new JArray(rowsObj.Where(t =>
+                                                JsonParseFieldSelector(t.Value<JObject>(), rowSelector.Remove(0, selector.Length)) != null
+                                                ));
+        }
+
+        private string JsonParseFieldSelector(JToken parsedJson, string rowSelector)
+        {
+            var selector = rowSelector.Split(':')[0];
+            JToken parsedObject;
+            if (string.IsNullOrWhiteSpace(selector))
+                parsedObject = parsedJson;
+            else if (parsedJson.SelectToken(selector) != null)
+                parsedObject = parsedJson.SelectToken(selector);
+            else
+                return null;
+
+            foreach (Match match in _JsonSelectorRegex.Matches(rowSelector))
+            {
+                var filter = match.Result("${filter}");
+                var key = match.Result("${key}");
+                Match innerMatch;
+                switch (filter)
+                {
+                    case "has":
+                        innerMatch = _JsonSelectorRegex.Match(key);
+                        if (innerMatch.Success)
+                        {
+                            if (JsonParseFieldSelector(parsedObject, key) == null)
+                                return null;
+                        }
+                        else
+                        {
+                            if (parsedObject.SelectToken(key) == null)
+                                return null;
+                        }
+                        break;
+                    case "not":
+                        innerMatch = _JsonSelectorRegex.Match(key);
+                        if (innerMatch.Success)
+                        {
+                            if (JsonParseFieldSelector(parsedObject, key) != null)
+                                return null;
+                        }
+                        else
+                        {
+                            if (parsedObject.SelectToken(key) != null)
+                                return null;
+                        }
+                        break;
+                    case "contains":
+                        if (!parsedObject.ToString().Contains(key))
+                            return null;
+                        break;
+                    default:
+                        logger.Error(string.Format("CardigannIndexer ({0}): Unsupported selector: {1}", Id, rowSelector));
+                        continue;
+                }
+            }
+            return selector;
+        }
    }
 }

--- a/src/Jackett.Common/Models/IndexerDefinition.cs
+++ b/src/Jackett.Common/Models/IndexerDefinition.cs
@ -151,6 +151,7 @@ namespace Jackett.Common.Models
        //public string Remove { get; set; } // already inherited
        public selectorBlock Dateheaders { get; set; }
        public selectorBlock Count { get; set; }
+        public bool Multiple { get; set; } = false;
    }

    public class searchPathBlock : requestBlock
@ -200,8 +201,6 @@ namespace Jackett.Common.Models
    public class responseBlock
    {
        public string Type { get; set; }
-        public string Attribute { get; set; }
        public string NoResultsMessage { get; set; }
-        public bool Multiple { get; set; } = false;
    }
 }
--- a/src/Jackett.Test/Common/Indexers/CardigannIndexerHtmlTests.cs
+++ b/src/Jackett.Test/Common/Indexers/CardigannIndexerHtmlTests.cs
@ -1,5 +1,4 @@
 using System;
-using System.Globalization;
 using System.Linq;
 using System.Threading.Tasks;
 using Jackett.Common.Indexers;
--- a/src/Jackett.Test/Common/Indexers/CardigannIndexerJsonTests.cs
+++ b/src/Jackett.Test/Common/Indexers/CardigannIndexerJsonTests.cs
@ -0,0 +1,82 @@
+using System.Linq;
+using System.Threading.Tasks;
+using Jackett.Common.Indexers;
+using Jackett.Common.Models;
+using Jackett.Test.TestHelpers;
+using NLog;
+using NUnit.Framework;
+using YamlDotNet.Serialization;
+using YamlDotNet.Serialization.NamingConventions;
+
+// todo: test download block
+// todo: test login block
+// todo: test settings block
+// todo: test other search modes
+// todo: review coverage, too many things missing (headers, encoding, ...)
+namespace Jackett.Test.Common.Indexers
+{
+    [TestFixture]
+    public class CardigannIndexerJsonTests
+    {
+        private readonly TestWebClient _webClient = new TestWebClient();
+        private readonly Logger _logger = LogManager.GetCurrentClassLogger();
+        private readonly TestCacheService _cacheService = new TestCacheService();
+
+        [Test]
+        public async Task TestCardigannJsonAsync()
+        {
+            _webClient.RegisterRequestCallback("https://jsondefinition1.com/api/torrents/filter?api_token=&name=1080p&sortField=created_at&sortDirection=desc&perPage=100&page=1",
+                                               "json-response1.json");
+            var definition = LoadTestDefinition("json-definition1.yml");
+            var indexer = new CardigannIndexer(null, _webClient, _logger, null, _cacheService, definition);
+
+            var query = new TorznabQuery
+            {
+                QueryType = "search",
+                SearchTerm = "1080p",
+            };
+
+            var result = await indexer.ResultsForQuery(query, false);
+            Assert.AreEqual(false, result.IsFromCache);
+
+            var releases = result.Releases.ToList();
+            Assert.AreEqual(78, releases.Count);
+
+            var firstRelease = releases.First();
+            Assert.AreEqual(2, firstRelease.Category.Count);
+            Assert.AreEqual(2000, firstRelease.Category.First());
+            Assert.AreEqual(100001, firstRelease.Category.Last());
+            Assert.AreEqual("The Eyes of Tammy Faye (2021)  BDRip 1080p AVC ES DD+ 5.1 EN DTSSS 5.1 Subs] HDO", firstRelease.Title);
+            Assert.AreEqual("https://jsondefinition1.com/torrents/24804", firstRelease.Details.ToString());
+            Assert.AreEqual("https://jsondefinition1.com/torrent/download/24804.01c887e14d0845f195bc12b31ea27d38", firstRelease.Link.ToString());
+            Assert.AreEqual("https://jsondefinition1.com/torrent/download/24804.01c887e14d0845f195bc12b31ea27d38", firstRelease.Guid.ToString());
+            Assert.AreEqual(null, firstRelease.MagnetUri);
+            Assert.AreEqual(null, firstRelease.InfoHash);
+            Assert.AreEqual("https://image.tmdb.org/t/p/w92/iBjkm6oxTPrvNkzr63cmnrpsQPR.jpg", firstRelease.Poster.ToString());
+            Assert.AreEqual(2021, firstRelease.PublishDate.Year);
+            Assert.AreEqual(17964744704, firstRelease.Size);
+            Assert.AreEqual(27, firstRelease.Seeders);
+            Assert.AreEqual(30, firstRelease.Peers);
+            Assert.AreEqual(1, firstRelease.Files);
+            Assert.AreEqual(29, firstRelease.Grabs);
+            Assert.AreEqual(1, firstRelease.DownloadVolumeFactor);
+            Assert.AreEqual(1, firstRelease.UploadVolumeFactor);
+            Assert.AreEqual(null, firstRelease.MinimumRatio);
+            Assert.AreEqual(345600, firstRelease.MinimumSeedTime);
+            Assert.AreEqual(451.73625183105469, firstRelease.Gain);
+            Assert.AreEqual(9115530, firstRelease.Imdb);
+            Assert.AreEqual(null, firstRelease.RageID);
+            Assert.AreEqual(601470, firstRelease.TMDb);
+            Assert.AreEqual(0, firstRelease.TVDBId);
+        }
+
+        private static IndexerDefinition LoadTestDefinition(string fileName)
+        {
+            var definitionString = TestUtil.LoadTestFile(fileName);
+            var deserializer = new DeserializerBuilder()
+                               .WithNamingConvention(CamelCaseNamingConvention.Instance)
+                               .Build();
+            return deserializer.Deserialize<IndexerDefinition>(definitionString);
+        }
+    }
+}
--- a/src/Jackett.Test/Resources/json-definition1.yml
+++ b/src/Jackett.Test/Resources/json-definition1.yml
@ -0,0 +1,141 @@
+---
+id: jsondefinition1
+name: jsondefinition1
+description: "jsondefinition1"
+language: es-ES
+type: private
+encoding: UTF-8
+links:
+  - https://jsondefinition1.com/
+
+caps:
+  categorymappings:
+    - {id: 1, cat: Movies, desc: "Películas"}
+    - {id: 2, cat: TV, desc: "Series"}
+    - {id: 3, cat: Audio, desc: "Música"}
+    - {id: 4, cat: TV/Documentary, desc: "Documentales"}
+
+  modes:
+    search: [q]
+    tv-search: [q, season, ep, imdbid, tvdbid]
+    movie-search: [q, imdbid, tmdbid]
+    music-search: [q]
+    book-search: [q]
+
+settings:
+  - name: apikey
+    type: text
+    label: APIKey
+  - name: info_key
+    type: info
+    label: About your API key
+    default: "Find or Generate a new API Token by accessing your account <i>My configuration / Mi configuración => Secutiy / Seguridad</i> page and clicking on the <b>API Token</b> tab."
+  - name: freeleech
+    type: checkbox
+    label: Search freeleech only
+    default: false
+  - name: sort
+    type: select
+    label: Sort requested from site
+    default: created_at
+    options:
+      created_at: created
+      seeders: seeders
+      size: size
+      name: title
+  - name: type
+    type: select
+    label: Order requested from site
+    default: desc
+    options:
+      desc: desc
+      asc: asc
+
+login:
+  path: /api/torrents
+  method: get
+  inputs:
+    api_token: "{{ .Config.apikey }}"
+  error:
+    - selector: a[href*="/login"]
+
+search:
+  paths:
+    # https://hdinnovations.github.io/UNIT3D-Community-Edition-Docs/api_endpoints.html
+    # https://github.com/HDInnovations/UNIT3D-Community-Edition/blob/master/app/Http/Controllers/API/TorrentController.php
+    - path: "/api/torrents/filter?api_token={{ .Config.apikey }}&name={{ if .Query.IMDBID }}{{ else }}{{ .Keywords }}{{ end }}{{ if .Query.TMDBID }}&tmdbId={{ .Query.TMDBID }}{{ else }}{{ end }}{{ if .Query.IMDBIDShort }}&imdbId={{ .Query.IMDBIDShort }}{{ else }}{{ end }}{{ if  .Query.TVDBID }}&tvdbId={{ .Query.TVDBID }}{{ else }}{{ end }}&sortField={{ .Config.sort }}&sortDirection={{ .Config.type }}&perPage=100&page=1{{ range .Categories }}&categories[]={{.}}{{end}}{{ if .Config.freeleech }}&free=1{{ else }}{{ end }}"
+      response:
+        type: json
+
+  rows:
+    selector: data:has(attributes.size):has(attributes.name:contains(1080)):has(attributes.poster:contains(.jpg)):not(attributes.fake_att):not(attributes.uploader:contains(DarkSwan2001))
+    attribute: attributes
+    count:
+      selector: meta.total
+
+  fields:
+    categorydesc:
+      selector: category
+#    title:
+#      selector: name
+#      filters:
+#        - name: re_replace
+#          args: ["\\[", " "]
+    title_dts:
+      selector: name:contains(DTS)
+      optional: true
+      filters:
+        - name: re_replace
+          args: ["DTS", "DTSSS"]
+    title_notdts:
+      selector: name:not(:contains(DTS))
+      optional: true
+    title:
+      text: "{{ if .Result.title_dts }}{{ .Result.title_dts }}{{ else }}{{ .Result.title_notdts }}{{ end }}"
+      filters:
+        - name: re_replace
+          args: ["\\[", " "]
+    details:
+      selector: details_link
+    download:
+      selector: download_link
+    poster:
+      selector: poster
+      filters:
+        - name: replace
+          args: ["https://via.placeholder.com/90x135", ""]
+    imdbid:
+      selector: imdb_id
+    tmdbid:
+      selector: tmdb_id
+    tvdbid:
+      selector: tvdb_id
+    files:
+      selector: num_file
+    seeders:
+      selector: seeders
+    leechers:
+      selector: leechers
+    grabs:
+      selector: times_completed
+    date:
+      # 2021-10-18T00:34:50.000000Z"
+      selector: created_at
+    size:
+      selector: size
+    downloadvolumefactor:
+      # api returns 0=false, 1=true
+      selector: freeleech
+      case:
+        0: 1 # not free
+        1: 0 # freeleech
+    uploadvolumefactor:
+      # api returns 0=false, 1=true
+      selector: double_upload
+      case:
+        0: 1 # normal
+        1: 2 # double
+    minimumseedtime:
+      # 4 days (as seconds = 4 x 24 x 60 x 60)
+      text: 345600
+# json UNIT3D ???
--- a/src/Jackett.Test/Resources/json-response1.json
+++ b/src/Jackett.Test/Resources/json-response1.json