From 0f5002338bd7caf88e39eb5ea4386a7c6df49be5 Mon Sep 17 00:00:00 2001 From: Mark McDowall Date: Mon, 10 Apr 2023 22:54:05 -0700 Subject: [PATCH] Fixed: Artists selection unselecting on mobile browsers (cherry picked from commit 513b746fc3ff285f617389483401cb99c05c3359) Closes #3513 --- .../src/Artist/Index/Select/ArtistIndexSelectFooter.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/frontend/src/Artist/Index/Select/ArtistIndexSelectFooter.tsx b/frontend/src/Artist/Index/Select/ArtistIndexSelectFooter.tsx index 85a957bfd..ffa017a78 100644 --- a/frontend/src/Artist/Index/Select/ArtistIndexSelectFooter.tsx +++ b/frontend/src/Artist/Index/Select/ArtistIndexSelectFooter.tsx @@ -6,6 +6,7 @@ import AppState from 'App/State/AppState'; import { RENAME_ARTIST, RETAG_ARTIST } from 'Commands/commandNames'; import SpinnerButton from 'Components/Link/SpinnerButton'; import PageContentFooter from 'Components/Page/PageContentFooter'; +import usePrevious from 'Helpers/Hooks/usePrevious'; import { kinds } from 'Helpers/Props'; import { saveArtistEditor, @@ -58,6 +59,7 @@ function ArtistIndexSelectFooter() { const [isSavingArtist, setIsSavingArtist] = useState(false); const [isSavingTags, setIsSavingTags] = useState(false); const [isSavingMonitoring, setIsSavingMonitoring] = useState(false); + const previousIsDeleting = usePrevious(isDeleting); const [selectState, selectDispatch] = useSelect(); const { selectedState } = selectState; @@ -171,10 +173,10 @@ function ArtistIndexSelectFooter() { }, [isSaving]); useEffect(() => { - if (!isDeleting && !deleteError) { + if (previousIsDeleting && !isDeleting && !deleteError) { selectDispatch({ type: 'unselectAll' }); } - }, [isDeleting, deleteError, selectDispatch]); + }, [previousIsDeleting, isDeleting, deleteError, selectDispatch]); useEffect(() => { dispatch(fetchRootFolders());