Fixed some aria violations

(cherry picked from commit 7aa846343815105e3576e6aa20eac64fcb0edf8d)

Closes #3589
This commit is contained in:
Benjamin Staneck 2023-04-30 06:05:21 +02:00 committed by Bogdan
parent dec6c32719
commit 4782922a47
5 changed files with 9 additions and 4 deletions

View File

@ -17,7 +17,7 @@ class DescriptionListItem extends Component {
} = this.props; } = this.props;
return ( return (
<span> <div>
<DescriptionListItemTitle <DescriptionListItemTitle
className={titleClassName} className={titleClassName}
> >
@ -29,7 +29,7 @@ class DescriptionListItem extends Component {
> >
{data} {data}
</DescriptionListItemDescription> </DescriptionListItemDescription>
</span> </div>
); );
} }
} }

View File

@ -23,6 +23,7 @@ function IconButton(props) {
className, className,
isDisabled && styles.isDisabled isDisabled && styles.isDisabled
)} )}
aria-label="Table Options Button"
isDisabled={isDisabled} isDisabled={isDisabled}
{...otherProps} {...otherProps}
> >

View File

@ -61,6 +61,7 @@ class PageHeader extends Component {
<img <img
className={styles.logo} className={styles.logo}
src={`${window.Lidarr.urlBase}/Content/Images/logo.svg`} src={`${window.Lidarr.urlBase}/Content/Images/logo.svg`}
alt="Lidarr Logo"
/> />
</Link> </Link>
</div> </div>
@ -79,6 +80,7 @@ class PageHeader extends Component {
<IconButton <IconButton
className={styles.donate} className={styles.donate}
name={icons.HEART} name={icons.HEART}
aria-label="Donate"
to="https://lidarr.audio/donate" to="https://lidarr.audio/donate"
size={14} size={14}
/> />

View File

@ -20,7 +20,7 @@ function PageHeaderActionsMenu(props) {
return ( return (
<div> <div>
<Menu alignMenu={align.RIGHT}> <Menu alignMenu={align.RIGHT}>
<MenuButton className={styles.menuButton}> <MenuButton className={styles.menuButton} aria-label="Menu Button">
<Icon <Icon
name={icons.INTERACTIVE} name={icons.INTERACTIVE}
/> />

View File

@ -56,7 +56,9 @@ function ProgressBar(props) {
styles[kind], styles[kind],
enableColorImpairedMode && 'colorImpaired' enableColorImpairedMode && 'colorImpaired'
)} )}
aria-valuenow={progress} role="meter"
aria-label={`Progress Bar at ${progress.toFixed(0)}%`}
aria-valuenow={progress.toFixed(0)}
aria-valuemin="0" aria-valuemin="0"
aria-valuemax="100" aria-valuemax="100"
style={{ width: progressPercent }} style={{ width: progressPercent }}