From 49883d0e30e65dbd0ac28547864ca685e6f9ce34 Mon Sep 17 00:00:00 2001
From: Bogdan <mynameisbogdan@users.noreply.github.com>
Date: Mon, 5 Feb 2024 14:15:10 +0200
Subject: [PATCH] Add some translations for artist table index

---
 .../src/Artist/Index/Table/ArtistIndexRow.tsx | 18 +++-------
 .../MonitorNewItemsFilterBuilderRowValue.js   | 19 -----------
 .../MonitorNewItemsFilterBuilderRowValue.tsx  | 33 +++++++++++++++++++
 .../src/Utilities/String/firstCharToUpper.js  |  9 +++++
 4 files changed, 47 insertions(+), 32 deletions(-)
 delete mode 100644 frontend/src/Components/Filter/Builder/MonitorNewItemsFilterBuilderRowValue.js
 create mode 100644 frontend/src/Components/Filter/Builder/MonitorNewItemsFilterBuilderRowValue.tsx
 create mode 100644 frontend/src/Utilities/String/firstCharToUpper.js

diff --git a/frontend/src/Artist/Index/Table/ArtistIndexRow.tsx b/frontend/src/Artist/Index/Table/ArtistIndexRow.tsx
index bff0eb24f..376fdb359 100644
--- a/frontend/src/Artist/Index/Table/ArtistIndexRow.tsx
+++ b/frontend/src/Artist/Index/Table/ArtistIndexRow.tsx
@@ -24,7 +24,7 @@ import TagListConnector from 'Components/TagListConnector';
 import { icons } from 'Helpers/Props';
 import { executeCommand } from 'Store/Actions/commandActions';
 import formatBytes from 'Utilities/Number/formatBytes';
-import titleCase from 'Utilities/String/titleCase';
+import firstCharToUpper from 'Utilities/String/firstCharToUpper';
 import translate from 'Utilities/String/translate';
 import AlbumsCell from './AlbumsCell';
 import hasGrowableColumns from './hasGrowableColumns';
@@ -224,14 +224,6 @@ function ArtistIndexRow(props: ArtistIndexRowProps) {
           );
         }
 
-        if (name === 'qualityProfileId') {
-          return (
-            <VirtualTableRowCell key={name} className={styles[name]}>
-              {qualityProfile.name}
-            </VirtualTableRowCell>
-          );
-        }
-
         if (name === 'metadataProfileId') {
           return (
             <VirtualTableRowCell key={name} className={styles[name]}>
@@ -243,7 +235,7 @@ function ArtistIndexRow(props: ArtistIndexRowProps) {
         if (name === 'monitorNewItems') {
           return (
             <VirtualTableRowCell key={name} className={styles[name]}>
-              {titleCase(monitorNewItems)}
+              {translate(firstCharToUpper(monitorNewItems))}
             </VirtualTableRowCell>
           );
         }
@@ -262,7 +254,7 @@ function ArtistIndexRow(props: ArtistIndexRowProps) {
           }
           return (
             <VirtualTableRowCell key={name} className={styles[name]}>
-              None
+              {translate('None')}
             </VirtualTableRowCell>
           );
         }
@@ -281,7 +273,7 @@ function ArtistIndexRow(props: ArtistIndexRowProps) {
           }
           return (
             <VirtualTableRowCell key={name} className={styles[name]}>
-              None
+              {translate('None')}
             </VirtualTableRowCell>
           );
         }
@@ -338,7 +330,7 @@ function ArtistIndexRow(props: ArtistIndexRowProps) {
         if (name === 'path') {
           return (
             <VirtualTableRowCell key={name} className={styles[name]}>
-              {path}
+              <span title={path}>{path}</span>
             </VirtualTableRowCell>
           );
         }
diff --git a/frontend/src/Components/Filter/Builder/MonitorNewItemsFilterBuilderRowValue.js b/frontend/src/Components/Filter/Builder/MonitorNewItemsFilterBuilderRowValue.js
deleted file mode 100644
index 3b178da06..000000000
--- a/frontend/src/Components/Filter/Builder/MonitorNewItemsFilterBuilderRowValue.js
+++ /dev/null
@@ -1,19 +0,0 @@
-import React from 'react';
-import FilterBuilderRowValue from './FilterBuilderRowValue';
-
-const options = [
-  { id: 'all', name: 'All Albums' },
-  { id: 'new', name: 'New' },
-  { id: 'none', name: 'None' }
-];
-
-function MonitorNewItemsFilterBuilderRowValue(props) {
-  return (
-    <FilterBuilderRowValue
-      tagList={options}
-      {...props}
-    />
-  );
-}
-
-export default MonitorNewItemsFilterBuilderRowValue;
diff --git a/frontend/src/Components/Filter/Builder/MonitorNewItemsFilterBuilderRowValue.tsx b/frontend/src/Components/Filter/Builder/MonitorNewItemsFilterBuilderRowValue.tsx
new file mode 100644
index 000000000..812d8c5b1
--- /dev/null
+++ b/frontend/src/Components/Filter/Builder/MonitorNewItemsFilterBuilderRowValue.tsx
@@ -0,0 +1,33 @@
+import React from 'react';
+import FilterBuilderRowValueProps from 'Components/Filter/Builder/FilterBuilderRowValueProps';
+import translate from 'Utilities/String/translate';
+import FilterBuilderRowValue from './FilterBuilderRowValue';
+
+const options = [
+  {
+    id: 'all',
+    get name() {
+      return translate('AllAlbums');
+    },
+  },
+  {
+    id: 'new',
+    get name() {
+      return translate('New');
+    },
+  },
+  {
+    id: 'none',
+    get name() {
+      return translate('None');
+    },
+  },
+];
+
+function MonitorNewItemsFilterBuilderRowValue(
+  props: FilterBuilderRowValueProps
+) {
+  return <FilterBuilderRowValue tagList={options} {...props} />;
+}
+
+export default MonitorNewItemsFilterBuilderRowValue;
diff --git a/frontend/src/Utilities/String/firstCharToUpper.js b/frontend/src/Utilities/String/firstCharToUpper.js
new file mode 100644
index 000000000..1ce64831c
--- /dev/null
+++ b/frontend/src/Utilities/String/firstCharToUpper.js
@@ -0,0 +1,9 @@
+function firstCharToUpper(input) {
+  if (!input) {
+    return '';
+  }
+
+  return [].map.call(input, (char, i) => (i ? char : char.toUpperCase())).join('');
+}
+
+export default firstCharToUpper;