mirror of https://github.com/lidarr/Lidarr
Fixed: FolderWritable check for CIFS shares mounted in Unix
See https://github.com/dotnet/runtime/issues/42790 Implemented workaround in https://github.com/dotnet/runtime/issues/42790#issuecomment-700362617
This commit is contained in:
parent
0d00dbb517
commit
8063a32acd
|
@ -10,6 +10,16 @@ namespace NzbDrone.Common.Test.DiskTests
|
|||
public abstract class DiskProviderFixtureBase<TSubject> : TestBase<TSubject>
|
||||
where TSubject : class, IDiskProvider
|
||||
{
|
||||
[Test]
|
||||
public void writealltext_should_truncate_existing()
|
||||
{
|
||||
var file = GetTempFilePath();
|
||||
|
||||
Subject.WriteAllText(file, "A pretty long string");
|
||||
Subject.WriteAllText(file, "A short string");
|
||||
Subject.ReadAllText(file).Should().Be("A short string");
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void directory_exist_should_be_able_to_find_existing_folder()
|
||||
{
|
||||
|
|
|
@ -138,7 +138,7 @@ namespace NzbDrone.Common.Disk
|
|||
{
|
||||
var testPath = Path.Combine(path, "lidarr_write_test.txt");
|
||||
var testContent = $"This file was created to verify if '{path}' is writable. It should've been automatically deleted. Feel free to delete it.";
|
||||
_fileSystem.File.WriteAllText(testPath, testContent);
|
||||
WriteAllText(testPath, testContent);
|
||||
_fileSystem.File.Delete(testPath);
|
||||
return true;
|
||||
}
|
||||
|
@ -314,7 +314,16 @@ namespace NzbDrone.Common.Disk
|
|||
{
|
||||
Ensure.That(filename, () => filename).IsValidPath();
|
||||
RemoveReadOnly(filename);
|
||||
_fileSystem.File.WriteAllText(filename, contents);
|
||||
|
||||
// File.WriteAllText is broken on net core when writing to some CIFS mounts
|
||||
// This workaround from https://github.com/dotnet/runtime/issues/42790#issuecomment-700362617
|
||||
using (var fs = new FileStream(filename, FileMode.Create, FileAccess.Write, FileShare.None))
|
||||
{
|
||||
using (var writer = new StreamWriter(fs))
|
||||
{
|
||||
writer.Write(contents);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
public void FolderSetLastWriteTime(string path, DateTime dateTime)
|
||||
|
|
Loading…
Reference in New Issue