mirror/Lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/Lidarr synced 2025-01-03 05:25:10 +00:00
Code Issues Releases Wiki Activity

New: Show health warning if system time is off expected time

Browse source 
Closes #1422
This commit is contained in:
Mark McDowall 2019-04-28 11:50:18 -07:00 committed by Qstick
parent e4d5e17cf0
commit c3af687442
3 changed files with 97 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/NzbDrone.Common/Cloud/LidarrCloudRequestBuilder.cs
View file

@ -13,7 +13,7 @@ public class LidarrCloudRequestBuilder : ILidarrCloudRequestBuilder
{
public LidarrCloudRequestBuilder()
{
Services = new HttpRequestBuilder("https://services.lidarr.audio/v1/")
Services = new HttpRequestBuilder("https://lidarr.servarr.com/v1/")
.CreateFactory();
Search = new HttpRequestBuilder("https://api.lidarr.audio/api/v0.4/{route}")

49
src/NzbDrone.Core.Test/HealthCheck/Checks/SystemTimeCheckFixture.cs Normal file
View file

@ -0,0 +1,49 @@
using System;
using System.Text;
using Moq;
using NUnit.Framework;
using NzbDrone.Common.Cloud;
using NzbDrone.Common.Http;
using NzbDrone.Common.Serializer;
using NzbDrone.Core.HealthCheck.Checks;
using NzbDrone.Core.Test.Framework;
using NzbDrone.Test.Common;
namespace NzbDrone.Core.Test.HealthCheck.Checks
{
[TestFixture]
public class SystemTimeCheckFixture : CoreTest<SystemTimeCheck>
{
[SetUp]
public void Setup()
{
Mocker.SetConstant<ISonarrCloudRequestBuilder>(new SonarrCloudRequestBuilder());
}
private void GivenServerTime(DateTime dateTime)
{
var json = new ServiceTimeResponse {DateTimeUtc = dateTime}.ToJson();
Mocker.GetMock<IHttpClient>()
.Setup(s => s.Execute(It.IsAny<HttpRequest>()))
.Returns<HttpRequest>(r => new HttpResponse(r, new HttpHeader(), Encoding.ASCII.GetBytes(json)));
}
[Test]
public void should_not_return_error_when_system_time_is_close_to_server_time()
{
GivenServerTime(DateTime.UtcNow);
Subject.Check().ShouldBeOk();
}
[Test]
public void should_return_error_when_system_time_is_more_than_one_day_from_server_time()
{
GivenServerTime(DateTime.UtcNow.AddDays(2));
Subject.Check().ShouldBeError();
ExceptionVerification.ExpectedErrors(1);
}
}
}

47
src/NzbDrone.Core/HealthCheck/Checks/SystemTimeCheck.cs Normal file
View file

@ -0,0 +1,47 @@
using System;
using NLog;
using NzbDrone.Common.Cloud;
using NzbDrone.Common.Http;
using NzbDrone.Common.Serializer;
namespace NzbDrone.Core.HealthCheck.Checks
{
public class SystemTimeCheck : HealthCheckBase
{
private readonly IHttpClient _client;
private readonly IHttpRequestBuilderFactory _cloudRequestBuilder;
private readonly Logger _logger;
public SystemTimeCheck(IHttpClient client, ILidarrCloudRequestBuilder cloudRequestBuilder, Logger logger)
{
_client = client;
_cloudRequestBuilder = cloudRequestBuilder.Services;
_logger = logger;
}
public override HealthCheck Check()
{
var request = _cloudRequestBuilder.Create()
.Resource("/time")
.Build();
var response = _client.Execute(request);
var result = Json.Deserialize<ServiceTimeResponse>(response.Content);
var systemTime = DateTime.UtcNow;
// +/- more than 1 day
if (Math.Abs(result.DateTimeUtc.Subtract(systemTime).TotalDays) >= 1)
{
_logger.Error("System time mismatch. SystemTime: {0} Expected Time: {1}. Update system time", systemTime, result.DateTimeUtc);
return new HealthCheck(GetType(), HealthCheckResult.Error, $"System time is off by more than 1 day. Scheduled tasks may not run correctly until the time is corrected");
}
return new HealthCheck(GetType());
}
}
public class ServiceTimeResponse
{
public DateTime DateTimeUtc { get; set; }
}
}