From dec241e6b659e871223151f6ecddf4d6b5e2149a Mon Sep 17 00:00:00 2001 From: bakerboy448 <55419169+bakerboy448@users.noreply.github.com> Date: Sat, 27 Jan 2024 11:56:08 -0600 Subject: [PATCH] Improve Release Grabbing & Failure Logging (cherry picked from commit d7aea82e45a7c5fec9e72b534fc4c9fb8654c519) Closes #4534 --- .../Download/ProcessDownloadDecisions.cs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/NzbDrone.Core/Download/ProcessDownloadDecisions.cs b/src/NzbDrone.Core/Download/ProcessDownloadDecisions.cs index e9eb025c2..23712e766 100644 --- a/src/NzbDrone.Core/Download/ProcessDownloadDecisions.cs +++ b/src/NzbDrone.Core/Download/ProcessDownloadDecisions.cs @@ -195,31 +195,30 @@ namespace NzbDrone.Core.Download private async Task ProcessDecisionInternal(DownloadDecision decision, int? downloadClientId = null) { var remoteAlbum = decision.RemoteAlbum; + var remoteIndexer = remoteAlbum.Release.Indexer; try { - _logger.Trace("Grabbing from Indexer {0} at priority {1}.", remoteAlbum.Release.Indexer, remoteAlbum.Release.IndexerPriority); + _logger.Trace("Grabbing release '{0}' from Indexer {1} at priority {2}.", remoteAlbum, remoteIndexer, remoteAlbum.Release.IndexerPriority); await _downloadService.DownloadReport(remoteAlbum, downloadClientId); return ProcessedDecisionResult.Grabbed; } catch (ReleaseUnavailableException) { - _logger.Warn("Failed to download release from indexer, no longer available. " + remoteAlbum); + _logger.Warn("Failed to download release '{0}' from Indexer {1}. Release not available", remoteAlbum, remoteIndexer); return ProcessedDecisionResult.Rejected; } catch (Exception ex) { if (ex is DownloadClientUnavailableException || ex is DownloadClientAuthenticationException) { - _logger.Debug(ex, - "Failed to send release to download client, storing until later. " + remoteAlbum); - + _logger.Debug(ex, "Failed to send release '{0}' from Indexer {1} to download client, storing until later.", remoteAlbum, remoteIndexer); return ProcessedDecisionResult.Failed; } else { - _logger.Warn(ex, "Couldn't add report to download queue. " + remoteAlbum); + _logger.Warn(ex, "Couldn't add release '{0}' from Indexer {1} to download queue.", remoteAlbum, remoteIndexer); return ProcessedDecisionResult.Skipped; } }