mirror/Lidarr
1
0
Fork 0
mirror of https://github.com/lidarr/Lidarr synced 2025-02-24 15:00:54 +00:00
Code Issues Releases Wiki Activity

Switch to Parallel.ForEach for list processing with MaxParallelism

Browse source 
(cherry picked from commit 0f93e04186f24abdb0cf0b3ba6a3505fda834e06)
This commit is contained in:
Qstick 2023-08-20 16:46:55 -05:00 committed by Bogdan
parent c5400cb4b0
commit fb025d9f68
1 changed files with 29 additions and 50 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

79
src/NzbDrone.Core/ImportLists/FetchAndParseImportListService.cs
View file

@ -3,7 +3,6 @@
using System.Linq;
using System.Threading.Tasks;
using NLog;
using NzbDrone.Common.TPL;
using NzbDrone.Core.Parser.Model;
namespace NzbDrone.Core.ImportLists
@ -41,10 +40,7 @@ public List<ImportListItemInfo> Fetch()
_logger.Debug("Available import lists {0}", importLists.Count);
var taskList = new List<Task>();
var taskFactory = new TaskFactory(TaskCreationOptions.LongRunning, TaskContinuationOptions.None);
foreach (var importList in importLists)
Parallel.ForEach(importLists, new ParallelOptions { MaxDegreeOfParallelism = 5 }, importList =>
{
var importListLocal = importList;
var importListStatus = _importListStatusService.GetLastSyncListInfo(importListLocal.Definition.Id);
@ -56,35 +52,28 @@ public List<ImportListItemInfo> Fetch()
if (DateTime.UtcNow < importListNextSync)
{
_logger.Trace("Skipping refresh of Import List {0} ({1}) due to minimum refresh interval. Next sync after {2}", importList.Name, importListLocal.Definition.Name, importListNextSync);
continue;
return;
}
}
var task = taskFactory.StartNew(() =>
{
try
{
var importListReports = importListLocal.Fetch();
try
{
var importListReports = importListLocal.Fetch();
lock (result)
{
_logger.Debug("Found {0} reports from {1} ({2})", importListReports.Count, importList.Name, importListLocal.Definition.Name);
lock (result)
{
_logger.Debug("Found {0} reports from {1} ({2})", importListReports.Count, importList.Name, importListLocal.Definition.Name);
result.AddRange(importListReports);
}
result.AddRange(importListReports);
}
_importListStatusService.UpdateListSyncStatus(importList.Definition.Id);
}
catch (Exception e)
{
_logger.Error(e, "Error during Import List Sync of {0} ({1})", importList.Name, importListLocal.Definition.Name);
}
}).LogExceptions();
taskList.Add(task);
}
Task.WaitAll(taskList.ToArray());
_importListStatusService.UpdateListSyncStatus(importList.Definition.Id);
}
catch (Exception e)
{
_logger.Error(e, "Error during Import List Sync of {0} ({1})", importList.Name, importListLocal.Definition.Name);
}
});
result = result.DistinctBy(r => new { r.Artist, r.Album }).ToList();
@ -105,35 +94,25 @@ public List<ImportListItemInfo> FetchSingleList(ImportListDefinition definition)
return result;
}
var taskList = new List<Task>();
var taskFactory = new TaskFactory(TaskCreationOptions.LongRunning, TaskContinuationOptions.None);
var importListLocal = importList;
var task = taskFactory.StartNew(() =>
try
{
try
var importListReports = importListLocal.Fetch();
lock (result)
{
var importListReports = importListLocal.Fetch();
_logger.Debug("Found {0} reports from {1} ({2})", importListReports.Count, importList.Name, importListLocal.Definition.Name);
lock (result)
{
_logger.Debug("Found {0} reports from {1} ({2})", importListReports.Count, importList.Name, importListLocal.Definition.Name);
result.AddRange(importListReports);
}
_importListStatusService.UpdateListSyncStatus(importList.Definition.Id);
result.AddRange(importListReports);
}
catch (Exception e)
{
_logger.Error(e, "Error during Import List Sync of {0} ({1})", importList.Name, importListLocal.Definition.Name);
}
}).LogExceptions();
taskList.Add(task);
Task.WaitAll(taskList.ToArray());
_importListStatusService.UpdateListSyncStatus(importList.Definition.Id);
}
catch (Exception e)
{
_logger.Error(e, "Error during Import List Sync of {0} ({1})", importList.Name, importListLocal.Definition.Name);
}
result = result.DistinctBy(r => new { r.Artist, r.Album }).ToList();