From 336c5d67d984032549b3b9d67a8d4e8cac395f75 Mon Sep 17 00:00:00 2001 From: M66B Date: Thu, 2 Nov 2023 14:18:34 +0100 Subject: [PATCH] Skip new app notifications without names --- app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java | 4 +++- app/src/main/java/eu/faircode/netguard/Util.java | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java b/app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java index 230e80b2..b00bb5f7 100644 --- a/app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java +++ b/app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java @@ -2398,7 +2398,9 @@ public class ServiceSinkhole extends VpnService implements SharedPreferences.OnS try { // Get application name List names = Util.getApplicationNames(uid, this); - String name = (names.size() == 0 ? Integer.toString(uid) : TextUtils.join(", ", names)); + if (names.size() == 0) + return; + String name = TextUtils.join(", ", names); // Get application info PackageManager pm = getPackageManager(); diff --git a/app/src/main/java/eu/faircode/netguard/Util.java b/app/src/main/java/eu/faircode/netguard/Util.java index 48576108..865a6636 100644 --- a/app/src/main/java/eu/faircode/netguard/Util.java +++ b/app/src/main/java/eu/faircode/netguard/Util.java @@ -402,7 +402,8 @@ public class Util { try { ApplicationInfo info = pm.getApplicationInfo(pkg, 0); String name = pm.getApplicationLabel(info).toString(); - listResult.add(TextUtils.isEmpty(name) ? pkg : name); + if (!TextUtils.isEmpty(name)) + listResult.add(name); } catch (PackageManager.NameNotFoundException ignored) { } Collections.sort(listResult);