From 55e35cacbbf8357c0b6cabc82a34ab4f7bd9b703 Mon Sep 17 00:00:00 2001 From: M66B Date: Tue, 25 Jul 2017 18:29:09 +0200 Subject: [PATCH] Always notify for unknown (new) uids --- .../main/java/eu/faircode/netguard/ServiceSinkhole.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java b/app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java index 2b1c0e28..db023ba7 100644 --- a/app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java +++ b/app/src/main/java/eu/faircode/netguard/ServiceSinkhole.java @@ -713,7 +713,7 @@ public class ServiceSinkhole extends VpnService implements SharedPreferences.OnS packet.dport = 0; if (dh.updateAccess(packet, dname, -1)) { lock.readLock().lock(); - if (mapNotify.containsKey(packet.uid) && mapNotify.get(packet.uid)) + if (!mapNotify.containsKey(packet.uid) || mapNotify.get(packet.uid)) showAccessNotification(packet.uid); lock.readLock().unlock(); } @@ -1587,10 +1587,8 @@ public class ServiceSinkhole extends VpnService implements SharedPreferences.OnS lock.writeLock().lock(); mapNotify.clear(); - if (notify) - for (Rule rule : listRule) - if (rule.notify && (system || !rule.system)) - mapNotify.put(rule.info.applicationInfo.uid, true); + for (Rule rule : listRule) + mapNotify.put(rule.info.applicationInfo.uid, notify && rule.notify && (system || !rule.system)); lock.writeLock().unlock(); }