From 570e573f0d53266eeb14292add66dc61148001cf Mon Sep 17 00:00:00 2001 From: M66B Date: Fri, 10 Jan 2020 08:49:54 +0100 Subject: [PATCH] Fixed off-by-one --- app/src/main/jni/netguard/dns.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/jni/netguard/dns.c b/app/src/main/jni/netguard/dns.c index 84990be7..585e2856 100644 --- a/app/src/main/jni/netguard/dns.c +++ b/app/src/main/jni/netguard/dns.c @@ -136,12 +136,12 @@ void parse_dns_response(const struct arguments *args, const struct ng_session *s char rd[INET6_ADDRSTRLEN + 1]; if (qtype == DNS_QTYPE_A) { - if (off + sizeof(__be32) < *datalen) + if (off + sizeof(__be32) <= *datalen) inet_ntop(AF_INET, data + off, rd, sizeof(rd)); else return; } else if (qclass == DNS_QCLASS_IN && qtype == DNS_QTYPE_AAAA) { - if (off + sizeof(struct in6_addr) < *datalen) + if (off + sizeof(struct in6_addr) <= *datalen) inet_ntop(AF_INET6, data + off, rd, sizeof(rd)); else return;