mirror/NetGuard
1
0
Fork 0
mirror of https://github.com/M66B/NetGuard.git synced 2025-01-03 05:44:14 +00:00
Code Issues Releases Wiki Activity

Prevent buffer overflow

Browse source
This commit is contained in:
M66B 2020-01-07 09:52:04 +01:00
parent e90a8440f5
commit e0bd3eff49
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/src/main/jni/netguard/dns.c
View file

@ -135,10 +135,17 @@ void parse_dns_response(const struct arguments *args, const struct ng_session *s
(qtype == DNS_QTYPE_A || qtype == DNS_QTYPE_AAAA)) { (qtype == DNS_QTYPE_A || qtype == DNS_QTYPE_AAAA)) {
char rd[INET6_ADDRSTRLEN + 1]; char rd[INET6_ADDRSTRLEN + 1];
if (qtype == DNS_QTYPE_A) if (qtype == DNS_QTYPE_A) {
if (off + sizeof(__be32) < *datalen)
inet_ntop(AF_INET, data + off, rd, sizeof(rd)); inet_ntop(AF_INET, data + off, rd, sizeof(rd));
else if (qclass == DNS_QCLASS_IN && qtype == DNS_QTYPE_AAAA) else
return;
} else if (qclass == DNS_QCLASS_IN && qtype == DNS_QTYPE_AAAA) {
if (off + sizeof(struct in6_addr) < *datalen)
inet_ntop(AF_INET6, data + off, rd, sizeof(rd)); inet_ntop(AF_INET6, data + off, rd, sizeof(rd));
else
return;
}
dns_resolved(args, qname, name, rd, ttl); dns_resolved(args, qname, name, rd, ttl);
log_android(ANDROID_LOG_DEBUG, log_android(ANDROID_LOG_DEBUG,