ICMP has no real port numbers

2016-02-05 22:10:12 +01:00 · 2016-02-05 22:10:12 +01:00 · fd022f4065
parent dc93dc4ad2
commit fd022f4065
1 changed files with 3 additions and 0 deletions
--- a/app/src/main/java/eu/faircode/netguard/SinkholeService.java
+++ b/app/src/main/java/eu/faircode/netguard/SinkholeService.java
@ -1102,6 +1102,9 @@ public class SinkholeService extends VpnService implements SharedPreferences.OnS
        if (packet.uid == Process.myUid())
            return true;

+        if (packet.protocol == 1 || packet.protocol == 58) // ICMP
+            packet.dport = 0;
+
        packet.allowed = false;
        if (prefs.getBoolean("filter", false)) {
            if (packet.uid < 0) // unknown