mirror/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2025-02-24 23:23:21 +00:00
Code Issues Releases Wiki Activity

Sentry logging exceptions and some trace logging

Browse source 
Co-authored-by: Taloth Saldono <Taloth@users.noreply.github.com>
This commit is contained in:
Robin Dadswell 2021-04-12 12:19:51 +01:00 committed by GitHub
parent 19d533b50a
commit 0a18898e36
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/NzbDrone.Common/Instrumentation/GlobalExceptionHandlers.cs
View file

@ -18,6 +18,12 @@ private static void HandleTaskException(object sender, UnobservedTaskExceptionEv
{
var exception = e.Exception;
if (exception.InnerException is ObjectDisposedException disposedException && disposedException.ObjectName == "System.Net.HttpListenerRequest")
{
// We don't care about web connections
return;
}
Console.WriteLine("Task Error: {0}", exception);
Logger.Error(exception, "Task Error");
}

6
src/NzbDrone.Common/Instrumentation/Sentry/SentryTarget.cs
View file

@ -217,7 +217,11 @@ private static List<string> GetFingerPrint(LogEventInfo logEvent)
if (ex != null)
{
fingerPrint.Add(ex.GetType().FullName);
fingerPrint.Add(ex.TargetSite.ToString());
if (ex.TargetSite != null)
{
fingerPrint.Add(ex.TargetSite.ToString());
}
if (ex.InnerException != null)
{
fingerPrint.Add(ex.InnerException.GetType().FullName);

2
src/NzbDrone.Core/MediaFiles/MediaInfo/VideoFileInfoReader.cs
View file

@ -78,6 +78,7 @@ public MediaInfoModel GetMediaInfo(string filename)
if (audioRuntime == 0 && videoRuntime == 0 && generalRuntime == 0)
{
// No runtime, ask mediainfo to scan the whole file
_logger.Trace("No runtime value found, rescanning at 1.0 scan depth");
mediaInfo.Option("ParseSpeed", "1.0");
using (var stream = _diskProvider.OpenReadStream(filename))
@ -88,6 +89,7 @@ public MediaInfoModel GetMediaInfo(string filename)
else if (audioChannels > 2 && audioChannelPositions.IsNullOrWhiteSpace())
{
// Some files with DTS don't have ChannelPositions unless more of the file is scanned
_logger.Trace("DTS audio without expected channel information, rescanning at 0.3 scan depth");
mediaInfo.Option("ParseSpeed", "0.3");
using (var stream = _diskProvider.OpenReadStream(filename))