mirror/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2025-02-27 08:33:21 +00:00
Code Issues Releases Wiki Activity

Fixed thread concurrency issue on http cookie handling.

Browse source
This commit is contained in:
Taloth Saldono 2015-07-08 20:05:03 +02:00
parent bf3d0ed2d1
commit 103de770c3
2 changed files with 76 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/NzbDrone.Common.Test/Http/HttpClientFixture.cs
View file

@ -226,6 +226,29 @@ public void should_store_response_cookie()
ExceptionVerification.IgnoreErrors(); ExceptionVerification.IgnoreErrors();
} }
[Test]
public void should_overwrite_response_cookie()
{
var requestSet = new HttpRequest("http://eu.httpbin.org/cookies/set?my=cookie");
requestSet.AllowAutoRedirect = false;
requestSet.StoreResponseCookie = true;
requestSet.AddCookie("my", "oldcookie");
var responseSet = Subject.Get(requestSet);
var request = new HttpRequest("http://eu.httpbin.org/get");
var response = Subject.Get<HttpBinResource>(request);
response.Resource.Headers.Should().ContainKey("Cookie");
var cookie = response.Resource.Headers["Cookie"].ToString();
cookie.Should().Contain("my=cookie");
ExceptionVerification.IgnoreErrors();
}
} }
public class HttpBinResource public class HttpBinResource

75
src/NzbDrone.Common/Http/HttpClient.cs
View file

@ -73,31 +73,12 @@ public HttpResponse Execute(HttpRequest request)
AddRequestHeaders(webRequest, request.Headers); AddRequestHeaders(webRequest, request.Headers);
} }
var cookieContainer = _cookieContainerCache.Get("container", () => new CookieContainer()); PrepareRequestCookies(request, webRequest);
if (request.Cookies.Count != 0)
{
foreach (var pair in request.Cookies)
{
cookieContainer.Add(new Cookie(pair.Key, pair.Value, "/", request.Url.Host)
{
Expires = DateTime.UtcNow.AddHours(1)
});
}
}
if (request.StoreResponseCookie)
{
webRequest.CookieContainer = cookieContainer;
}
else
{
webRequest.CookieContainer = new CookieContainer();
webRequest.CookieContainer.Add(cookieContainer.GetCookies(request.Url));
}
var response = ExecuteRequest(request, webRequest); var response = ExecuteRequest(request, webRequest);
HandleResponseCookies(request, webRequest);
stopWatch.Stop(); stopWatch.Stop();
_logger.Trace("{0} ({1:n0} ms)", response, stopWatch.ElapsedMilliseconds); _logger.Trace("{0} ({1:n0} ms)", response, stopWatch.ElapsedMilliseconds);
@ -119,6 +100,56 @@ public HttpResponse Execute(HttpRequest request)
return response; return response;
} }
private void PrepareRequestCookies(HttpRequest request, HttpWebRequest webRequest)
{
lock (_cookieContainerCache)
{
var persistentCookieContainer = _cookieContainerCache.Get("container", () => new CookieContainer());
if (request.Cookies.Count != 0)
{
foreach (var pair in request.Cookies)
{
persistentCookieContainer.Add(new Cookie(pair.Key, pair.Value, "/", request.Url.Host)
{
Expires = DateTime.UtcNow.AddHours(1)
});
}
}
var requestCookies = persistentCookieContainer.GetCookies(request.Url);
if (requestCookies.Count == 0 && !request.StoreResponseCookie)
{
return;
}
if (webRequest.CookieContainer == null)
{
webRequest.CookieContainer = new CookieContainer();
}
webRequest.CookieContainer.Add(requestCookies);
}
}
private void HandleResponseCookies(HttpRequest request, HttpWebRequest webRequest)
{
if (!request.StoreResponseCookie)
{
return;
}
lock (_cookieContainerCache)
{
var persistentCookieContainer = _cookieContainerCache.Get("container", () => new CookieContainer());
var cookies = webRequest.CookieContainer.GetCookies(request.Url);
persistentCookieContainer.Add(cookies);
}
}
private HttpResponse ExecuteRequest(HttpRequest request, HttpWebRequest webRequest) private HttpResponse ExecuteRequest(HttpRequest request, HttpWebRequest webRequest)
{ {
if (OsInfo.IsMonoRuntime && webRequest.RequestUri.Scheme == "https") if (OsInfo.IsMonoRuntime && webRequest.RequestUri.Scheme == "https")