mirror/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2024-12-30 20:05:41 +00:00
Code Issues Releases Wiki Activity

Fixed: Queue/History take two clicks to load, We don't wait on Episode Fetch

Browse source
This commit is contained in:
Qstick 2019-07-25 22:52:03 -04:00
parent b6c1c81152
commit 2758adcc8c
2 changed files with 0 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
frontend/src/Activity/History/History.js
View file

@ -1,7 +1,6 @@
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import React, { Component } from 'react'; import React, { Component } from 'react';
import { align, icons } from 'Helpers/Props'; import { align, icons } from 'Helpers/Props';
import hasDifferentItems from 'Utilities/Object/hasDifferentItems';
import LoadingIndicator from 'Components/Loading/LoadingIndicator'; import LoadingIndicator from 'Components/Loading/LoadingIndicator';
import Table from 'Components/Table/Table'; import Table from 'Components/Table/Table';
import TableBody from 'Components/Table/TableBody'; import TableBody from 'Components/Table/TableBody';
@ -17,26 +16,6 @@ import HistoryRowConnector from './HistoryRowConnector';
class History extends Component { class History extends Component {
//
// Lifecycle
shouldComponentUpdate(nextProps) {
// Don't update when fetching has completed if items have changed,
// before episodes start fetching or when episodes start fetching.
if (
(
this.props.isFetching &&
nextProps.isPopulated &&
hasDifferentItems(this.props.items, nextProps.items)
)
) {
return false;
}
return true;
}
// //
// Render // Render

16
frontend/src/Activity/Queue/Queue.js
View file

@ -40,22 +40,6 @@ class Queue extends Component {
}; };
} }
shouldComponentUpdate(nextProps) {
// Don't update when fetching has completed if items have changed,
// before movies start fetching or when movies start fetching.
if (
this.props.isFetching &&
nextProps.isPopulated &&
hasDifferentItems(this.props.items, nextProps.items) &&
nextProps.items.some((e) => e.movieId)
) {
return false;
}
return true;
}
componentDidUpdate(prevProps) { componentDidUpdate(prevProps) {
if (hasDifferentItems(prevProps.items, this.props.items)) { if (hasDifferentItems(prevProps.items, this.props.items)) {
this.setState((state) => { this.setState((state) => {