mirror/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2024-12-26 17:59:14 +00:00
Code Issues Releases Wiki Activity

Fixed: Email connection test reporting success incorrectly

Browse source 
Fixes #1524
This commit is contained in:
Mark McDowall 2016-10-28 11:02:36 -07:00
parent 25a3f83ebc
commit 2ece05cd1e
1 changed files with 5 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/NzbDrone.Core/Notifications/Email/EmailService.cs
View file

@ -45,12 +45,11 @@ public void SendEmail(EmailSettings settings, string subject, string body, bool
{ {
_logger.Error("Error sending email. Subject: {0}", email.Subject); _logger.Error("Error sending email. Subject: {0}", email.Subject);
_logger.Debug(ex, ex.Message); _logger.Debug(ex, ex.Message);
throw;
} }
} }
private void Send(MailMessage email, string server, int port, bool ssl, NetworkCredential credentials) private void Send(MailMessage email, string server, int port, bool ssl, NetworkCredential credentials)
{
try
{ {
var smtp = new SmtpClient(server, port); var smtp = new SmtpClient(server, port);
smtp.EnableSsl = ssl; smtp.EnableSsl = ssl;
@ -59,13 +58,6 @@ private void Send(MailMessage email, string server, int port, bool ssl, NetworkC
smtp.Send(email); smtp.Send(email);
} }
catch (Exception ex)
{
_logger.Error(ex, "There was an error sending an email.");
throw;
}
}
public ValidationFailure Test(EmailSettings settings) public ValidationFailure Test(EmailSettings settings)
{ {
const string body = "Success! You have properly configured your email notification settings"; const string body = "Success! You have properly configured your email notification settings";