Fixed XBMC JSON requests.

NzbDrone.Core.Test/XbmcProviderTest.cs

@@ -22,7 +22,7 @@ namespace NzbDrone.Core.Test
     public class XbmcProviderTest : TestBase
     {
         [Test]
-        public void JsonEror_true()
+        public void JsonError_true()
         {
             //Setup
             var mocker = new AutoMoqer();
@@ -36,7 +36,21 @@ public void JsonEror_true()
         }
 
         [Test]
-        public void JsonEror_false()
+        public void JsonError_true_empty_response()
+        {
+            //Setup
+            var mocker = new AutoMoqer();
+            var response = String.Empty;
+
+            //Act
+            var result = mocker.Resolve<XbmcProvider>().CheckForJsonError(response);
+
+            //Assert
+            Assert.AreEqual(true, result);
+        }
+
+        [Test]
+        public void JsonError_false()
         {
             //Setup
             var mocker = new AutoMoqer();

NzbDrone.Core/Providers/Core/HttpProvider.cs

@@ -74,24 +74,31 @@ public virtual string PostCommand(string address, string username, string passwo
 
             byte[] byteArray = Encoding.ASCII.GetBytes(command);
 
-            var request = WebRequest.Create(address);
+            var request = (HttpWebRequest)WebRequest.Create(address);
             request.Method = "POST";
             request.Credentials = new NetworkCredential(username, password);
-            request.ContentLength = byteArray.Length;
+            request.ContentType = "application/json";
-            request.ContentType = "application/x-www-form-urlencoded";
+            request.Timeout = 2000;
-            var dataStream = request.GetRequestStream();
+            request.KeepAlive = false;
-            dataStream.Write(byteArray, 0, byteArray.Length);
-            dataStream.Close();
 
-            var response = request.GetResponse();
+            //Used to hold the JSON response
-            dataStream = response.GetResponseStream();
+            string responseFromServer;
-            var reader = new StreamReader(dataStream);
-            // Read the content.
-            string responseFromServer = reader.ReadToEnd();
 
-            reader.Close();
+            using (var requestStream = request.GetRequestStream())
-            dataStream.Close();
+            {
-            response.Close();
+                requestStream.Write(byteArray, 0, byteArray.Length);
+
+                using (var response = request.GetResponse())
+                {
+                    using (var responseStream = response.GetResponseStream())
+                    {
+                        using (var reader = new StreamReader(responseStream))
+                        {
+                            responseFromServer = reader.ReadToEnd();
+                        }
+                    }
+                }
+            }
 
             return responseFromServer.Replace(" ", " ");
         }

NzbDrone.Core/Providers/XbmcProvider.cs

@@ -300,6 +300,12 @@ public virtual bool CheckForJsonError(string response)
                 return true;
             }
 
+            if (String.IsNullOrWhiteSpace(response))
+            {
+                Logger.Debug("Invalid response from XBMC, the response is not valid JSON");
+                return true;
+            }
+
             return false;
         }