Simplify label translations in columns

Closes #8922

frontend/src/AddMovie/ImportMovie/SelectFolder/ImportMovieSelectFolder.js

@@ -18,23 +18,17 @@ import styles from './ImportMovieSelectFolder.css';
 const rootFolderColumns = [
   {
     name: 'path',
-    get label() {
+    label: () => translate('Path'),
-      return translate('Path');
-    },
     isVisible: true
   },
   {
     name: 'freeSpace',
-    get label() {
+    label: () => translate('FreeSpace'),
-      return translate('FreeSpace');
-    },
     isVisible: true
   },
   {
     name: 'unmappedFolders',
-    get label() {
+    label: () => translate('UnmappedFolders'),
-      return translate('UnmappedFolders');
-    },
     isVisible: true
   },
   {

frontend/src/Components/FileBrowser/FileBrowserModalContent.js

@@ -20,16 +20,12 @@ import styles from './FileBrowserModalContent.css';
 const columns = [
   {
     name: 'type',
-    get label() {
+    label: () => translate('Type'),
-      return translate('Type');
-    },
     isVisible: true
   },
   {
     name: 'name',
-    get label() {
+    label: () => translate('Name'),
-      return translate('Name');
-    },
     isVisible: true
   }
 ];

frontend/src/DiscoverMovie/Table/DiscoverMovieHeader.js

@@ -111,7 +111,7 @@ class DiscoverMovieHeader extends Component {
                 isSortable={isSortable}
                 {...otherProps}
               >
-                {label}
+                {typeof label === 'function' ? label() : label}
               </VirtualTableHeaderCell>
             );
           })

frontend/src/InteractiveImport/Folder/InteractiveImportSelectFolderModalContent.tsx

@@ -25,15 +25,11 @@ import styles from './InteractiveImportSelectFolderModalContent.css';
 const recentFoldersColumns = [
   {
     name: 'folder',
-    get label() {
+    label: () => translate('Folder'),
-      return translate('Folder');
-    },
   },
   {
     name: 'lastUsed',
-    get label() {
+    label: () => translate('LastUsed'),
-      return translate('LastUsed');
-    },
   },
   {
     name: 'actions',

frontend/src/InteractiveImport/Interactive/InteractiveImportModalContent.tsx

@@ -71,48 +71,36 @@ type OnSelectedChangeCallback = React.ComponentProps<
 const COLUMNS = [
   {
     name: 'relativePath',
-    get label() {
+    label: () => translate('RelativePath'),
-      return translate('RelativePath');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'movie',
-    get label() {
+    label: () => translate('Movie'),
-      return translate('Movie');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'releaseGroup',
-    get label() {
+    label: () => translate('ReleaseGroup'),
-      return translate('ReleaseGroup');
-    },
     isVisible: true,
   },
   {
     name: 'quality',
-    get label() {
+    label: () => translate('Quality'),
-      return translate('Quality');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'languages',
-    get label() {
+    label: () => translate('Languages'),
-      return translate('Languages');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'size',
-    get label() {
+    label: () => translate('Size'),
-      return translate('Size');
-    },
     isSortable: true,
     isVisible: true,
   },
@@ -139,22 +127,16 @@ const COLUMNS = [
 const importModeOptions = [
   {
     key: 'chooseImportMode',
-    get value() {
+    value: () => translate('ChooseImportMode'),
-      return translate('ChooseImportMode');
-    },
     disabled: true,
   },
   {
     key: 'move',
-    get value() {
+    value: () => translate('MoveFiles'),
-      return translate('MoveFiles');
-    },
   },
   {
     key: 'copy',
-    get value() {
+    value: () => translate('HardlinkCopyFiles'),
-      return translate('HardlinkCopyFiles');
-    },
   },
 ];
 

frontend/src/InteractiveImport/Movie/SelectMovieModalContent.tsx

@@ -29,30 +29,22 @@ import styles from './SelectMovieModalContent.css';
 const columns = [
   {
     name: 'title',
-    get label() {
+    label: () => translate('Title'),
-      return translate('Title');
-    },
     isVisible: true,
   },
   {
     name: 'year',
-    get label() {
+    label: () => translate('Year'),
-      return translate('Year');
-    },
     isVisible: true,
   },
   {
     name: 'imdbId',
-    get label() {
+    label: () => translate('ImdbId'),
-      return translate('ImdbId');
-    },
     isVisible: true,
   },
   {
     name: 'tmdbId',
-    get label() {
+    label: () => translate('TmdbId'),
-      return translate('TmdbId');
-    },
     isVisible: true,
   },
 ];

frontend/src/InteractiveImport/Movie/SelectMovieModalTableHeader.tsx

@@ -30,7 +30,7 @@ function SelectMovieModalTableHeader(props: SelectMovieModalTableHeaderProps) {
             }
             name={name}
           >
-            {label}
+            {typeof label === 'function' ? label() : label}
           </VirtualTableHeaderCell>
         );
       })}

frontend/src/InteractiveSearch/InteractiveSearchContent.js

@@ -13,17 +13,13 @@ import styles from './InteractiveSearchContent.css';
 const columns = [
   {
     name: 'protocol',
-    get label() {
+    label: () => translate('Source'),
-      return translate('Source');
-    },
     isSortable: true,
     isVisible: true
   },
   {
     name: 'age',
-    get label() {
+    label: () => translate('Age'),
-      return translate('Age');
-    },
     isSortable: true,
     isVisible: true
   },
@@ -43,66 +39,50 @@ const columns = [
   },
   {
     name: 'title',
-    get label() {
+    label: () => translate('Title'),
-      return translate('Title');
-    },
     isSortable: true,
     isVisible: true
   },
   {
     name: 'indexer',
-    get label() {
+    label: () => translate('Indexer'),
-      return translate('Indexer');
-    },
     isSortable: true,
     isVisible: true
   },
   {
     name: 'history',
-    get label() {
+    label: () => translate('History'),
-      return translate('History');
-    },
     isSortable: true,
     fixedSortDirection: sortDirections.ASCENDING,
     isVisible: true
   },
   {
     name: 'size',
-    get label() {
+    label: () => translate('Size'),
-      return translate('Size');
-    },
     isSortable: true,
     isVisible: true
   },
   {
     name: 'peers',
-    get label() {
+    label: () => translate('Peers'),
-      return translate('Peers');
-    },
     isSortable: true,
     isVisible: true
   },
   {
     name: 'languages',
-    get label() {
+    label: () => translate('Language'),
-      return translate('Language');
-    },
     isSortable: true,
     isVisible: true
   },
   {
     name: 'qualityWeight',
-    get label() {
+    label: () => translate('Quality'),
-      return translate('Quality');
-    },
     isSortable: true,
     isVisible: true
   },
   {
     name: 'customFormat',
-    get label() {
+    label: () => translate('Formats'),
-      return translate('Formats');
-    },
     isSortable: true,
     isVisible: true
   },

frontend/src/Movie/Details/Titles/MovieTitlesTableContent.js

@@ -10,23 +10,17 @@ import styles from './MovieTitlesTableContent.css';
 const columns = [
   {
     name: 'altTitle',
-    get label() {
+    label: () => translate('AlternativeTitle'),
-      return translate('AlternativeTitle');
-    },
     isVisible: true
   },
   {
     name: 'language',
-    get label() {
+    label: () => translate('Language'),
-      return translate('Language');
-    },
     isVisible: true
   },
   {
     name: 'sourceType',
-    get label() {
+    label: () => translate('Type'),
-      return translate('Type');
-    },
     isVisible: true
   }
 ];

frontend/src/Movie/History/MovieHistoryTableContent.js

@@ -17,30 +17,22 @@ const columns = [
   },
   {
     name: 'sourceTitle',
-    get label() {
+    label: () => translate('SourceTitle'),
-      return translate('SourceTitle');
-    },
     isVisible: true
   },
   {
     name: 'languages',
-    get label() {
+    label: () => translate('Languages'),
-      return translate('Languages');
-    },
     isVisible: true
   },
   {
     name: 'quality',
-    get label() {
+    label: () => translate('Quality'),
-      return translate('Quality');
-    },
     isVisible: true
   },
   {
     name: 'customFormats',
-    get label() {
+    label: () => translate('CustomFormats'),
-      return translate('CustomFormats');
-    },
     isSortable: false,
     isVisible: true
   },
@@ -55,9 +47,7 @@ const columns = [
   },
   {
     name: 'date',
-    get label() {
+    label: () => translate('Date'),
-      return translate('Date');
-    },
     isVisible: true
   },
   {

frontend/src/Movie/Index/Select/MovieIndexSelectFooter.tsx

@@ -166,7 +166,7 @@ function MovieIndexSelectFooter() {
             isDisabled={!anySelected || isOrganizingMovies}
             onPress={onOrganizePress}
           >
-            {translate('Rename Files')}
+            {translate('RenameFiles')}
           </SpinnerButton>
 
           <SpinnerButton

frontend/src/MovieFile/Editor/MovieFileEditorTableContent.js

@@ -11,58 +11,42 @@ import styles from './MovieFileEditorTableContent.css';
 const columns = [
   {
     name: 'title',
-    get label() {
+    label: () => translate('RelativePath'),
-      return translate('RelativePath');
-    },
     isVisible: true
   },
   {
     name: 'videoCodec',
-    get label() {
+    label: () => translate('VideoCodec'),
-      return translate('VideoCodec');
-    },
     isVisible: true
   },
   {
     name: 'audioInfo',
-    get label() {
+    label: () => translate('AudioInfo'),
-      return translate('AudioInfo');
-    },
     isVisible: true
   },
   {
     name: 'size',
-    get label() {
+    label: () => translate('Size'),
-      return translate('Size');
-    },
     isVisible: true
   },
   {
     name: 'languages',
-    get label() {
+    label: () => translate('Languages'),
-      return translate('Languages');
-    },
     isVisible: true
   },
   {
     name: 'quality',
-    get label() {
+    label: () => translate('Quality'),
-      return translate('Quality');
-    },
     isVisible: true
   },
   {
     name: 'releaseGroup',
-    get label() {
+    label: () => translate('ReleaseGroup'),
-      return translate('ReleaseGroup');
-    },
     isVisible: true
   },
   {
     name: 'quality.customFormats',
-    get label() {
+    label: () => translate('Formats'),
-      return translate('Formats');
-    },
     isVisible: true
   },
   {

frontend/src/MovieFile/Extras/ExtraFileTableContent.js

@@ -11,23 +11,17 @@ import styles from './ExtraFileTableContent.css';
 const columns = [
   {
     name: 'relativePath',
-    get label() {
+    label: () => translate('RelativePath'),
-      return translate('RelativePath');
-    },
     isVisible: true
   },
   {
     name: 'extension',
-    get label() {
+    label: () => translate('Extension'),
-      return translate('Extension');
-    },
     isVisible: true
   },
   {
     name: 'type',
-    get label() {
+    label: () => translate('Type'),
-      return translate('Type');
-    },
     isVisible: true
   },
   {

frontend/src/RootFolder/RootFolders.tsx

@@ -13,23 +13,17 @@ import RootFolderRow from './RootFolderRow';
 const rootFolderColumns = [
   {
     name: 'path',
-    get label() {
+    label: () => translate('Path'),
-      return translate('Path');
-    },
     isVisible: true,
   },
   {
     name: 'freeSpace',
-    get label() {
+    label: () => translate('FreeSpace'),
-      return translate('FreeSpace');
-    },
     isVisible: true,
   },
   {
     name: 'unmappedFolders',
-    get label() {
+    label: () => translate('UnmappedFolders'),
-      return translate('UnmappedFolders');
-    },
     isVisible: true,
   },
   {

frontend/src/Settings/DownloadClients/DownloadClients/Manage/ManageDownloadClientsModalContent.tsx

@@ -36,49 +36,37 @@ type OnSelectedChangeCallback = React.ComponentProps<
 const COLUMNS = [
   {
     name: 'name',
-    get label() {
+    label: () => translate('Name'),
-      return translate('Name');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'implementation',
-    get label() {
+    label: () => translate('Implementation'),
-      return translate('Implementation');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'enable',
-    get label() {
+    label: () => translate('Enabled'),
-      return translate('Enabled');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'priority',
-    get label() {
+    label: () => translate('Priority'),
-      return translate('Priority');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'removeCompletedDownloads',
-    get label() {
+    label: () => translate('RemoveCompleted'),
-      return translate('RemoveCompleted');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'removeFailedDownloads',
-    get label() {
+    label: () => translate('RemoveFailed'),
-      return translate('RemoveFailed');
-    },
     isSortable: true,
     isVisible: true,
   },

frontend/src/Settings/ImportLists/ImportLists/Manage/ManageImportListsModalContent.tsx

@@ -36,49 +36,37 @@ type OnSelectedChangeCallback = React.ComponentProps<
 const COLUMNS = [
   {
     name: 'name',
-    get label() {
+    label: () => translate('Name'),
-      return translate('Name');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'implementation',
-    get label() {
+    label: () => translate('Implementation'),
-      return translate('Implementation');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'qualityProfileId',
-    get label() {
+    label: () => translate('QualityProfile'),
-      return translate('QualityProfile');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'rootFolderPath',
-    get label() {
+    label: () => translate('RootFolder'),
-      return translate('RootFolder');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'enableAuto',
-    get label() {
+    label: () => translate('AutomaticAdd'),
-      return translate('AutomaticAdd');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'tags',
-    get label() {
+    label: () => translate('Tags'),
-      return translate('Tags');
-    },
     isSortable: true,
     isVisible: true,
   },

frontend/src/Settings/Indexers/Indexers/Manage/ManageIndexersModalContent.tsx

@@ -36,57 +36,43 @@ type OnSelectedChangeCallback = React.ComponentProps<
 const COLUMNS = [
   {
     name: 'name',
-    get label() {
+    label: () => translate('Name'),
-      return translate('Name');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'implementation',
-    get label() {
+    label: () => translate('Implementation'),
-      return translate('Implementation');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'enableRss',
-    get label() {
+    label: () => translate('EnableRSS'),
-      return translate('EnableRSS');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'enableAutomaticSearch',
-    get label() {
+    label: () => translate('EnableAutomaticSearch'),
-      return translate('EnableAutomaticSearch');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'enableInteractiveSearch',
-    get label() {
+    label: () => translate('EnableInteractiveSearch'),
-      return translate('EnableInteractiveSearch');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'priority',
-    get label() {
+    label: () => translate('Priority'),
-      return translate('Priority');
-    },
     isSortable: true,
     isVisible: true,
   },
   {
     name: 'tags',
-    get label() {
+    label: () => translate('Tags'),
-      return translate('Tags');
-    },
     isSortable: true,
     isVisible: true,
   },

frontend/src/System/Backup/Backups.js

@@ -21,21 +21,17 @@ const columns = [
   },
   {
     name: 'name',
-    get label() {
+    label: () => translate('Name'),
-      return translate('Name');
-    },
     isVisible: true
   },
   {
     name: 'size',
-    label: 'Size',
+    label: () => translate('Size'),
     isVisible: true
   },
   {
     name: 'time',
-    get label() {
+    label: () => translate('Time'),
-      return translate('Time');
-    },
     isVisible: true
   },
   {

frontend/src/System/Logs/Files/LogFiles.js

@@ -19,16 +19,12 @@ import LogFilesTableRow from './LogFilesTableRow';
 const columns = [
   {
     name: 'filename',
-    get label() {
+    label: () => translate('Filename'),
-      return translate('Filename');
-    },
     isVisible: true
   },
   {
     name: 'lastWriteTime',
-    get label() {
+    label: () => translate('LastWriteTime'),
-      return translate('LastWriteTime');
-    },
     isVisible: true
   },
   {

frontend/src/System/Status/DiskSpace/DiskSpace.js

@@ -15,23 +15,17 @@ import styles from './DiskSpace.css';
 const columns = [
   {
     name: 'path',
-    get label() {
+    label: () => translate('Location'),
-      return translate('Location');
-    },
     isVisible: true
   },
   {
     name: 'freeSpace',
-    get label() {
+    label: () => translate('FreeSpace'),
-      return translate('FreeSpace');
-    },
     isVisible: true
   },
   {
     name: 'totalSpace',
-    get label() {
+    label: () => translate('TotalSpace'),
-      return translate('TotalSpace');
-    },
     isVisible: true
   },
   {

frontend/src/System/Status/Health/Health.js

@@ -94,16 +94,12 @@ const columns = [
   },
   {
     name: 'message',
-    get label() {
+    label: () => translate('Message'),
-      return translate('Message');
-    },
     isVisible: true
   },
   {
     name: 'actions',
-    get label() {
+    label: () => translate('Actions'),
-      return translate('Actions');
-    },
     isVisible: true
   }
 ];

frontend/src/System/Tasks/Queued/QueuedTasks.js

@@ -10,44 +10,32 @@ import QueuedTaskRowConnector from './QueuedTaskRowConnector';
 const columns = [
   {
     name: 'trigger',
-    get label() {
+    label: () => translate('Trigger'),
-      return translate('Trigger');
-    },
     isVisible: true
   },
   {
     name: 'commandName',
-    get label() {
+    label: () => translate('Name'),
-      return translate('Name');
-    },
     isVisible: true
   },
   {
     name: 'queued',
-    get label() {
+    label: () => translate('Queued'),
-      return translate('Queued');
-    },
     isVisible: true
   },
   {
     name: 'started',
-    get label() {
+    label: () => translate('Started'),
-      return translate('Started');
-    },
     isVisible: true
   },
   {
     name: 'ended',
-    get label() {
+    label: () => translate('Ended'),
-      return translate('Ended');
-    },
     isVisible: true
   },
   {
     name: 'duration',
-    get label() {
+    label: () => translate('Duration'),
-      return translate('Duration');
-    },
     isVisible: true
   },
   {

frontend/src/System/Tasks/Scheduled/ScheduledTasks.js

@@ -10,37 +10,27 @@ import ScheduledTaskRowConnector from './ScheduledTaskRowConnector';
 const columns = [
   {
     name: 'name',
-    get label() {
+    label: () => translate('Name'),
-      return translate('Name');
-    },
     isVisible: true
   },
   {
     name: 'interval',
-    get label() {
+    label: () => translate('Interval'),
-      return translate('Interval');
-    },
     isVisible: true
   },
   {
     name: 'lastExecution',
-    get label() {
+    label: () => translate('LastExecution'),
-      return translate('LastExecution');
-    },
     isVisible: true
   },
   {
     name: 'lastDuration',
-    get label() {
+    label: () => translate('LastDuration'),
-      return translate('LastDuration');
-    },
     isVisible: true
   },
   {
     name: 'nextExecution',
-    get label() {
+    label: () => translate('NextExecution'),
-      return translate('NextExecution');
-    },
     isVisible: true
   },
   {