mirror
/
Radarr
mirror of https://github.com/Radarr/Radarr
1
0
Fork 0
Code Issues Releases Wiki Activity

Fixed: Update Mono version check now minimum is 5.20

This commit is contained in:
ta264 2021-01-19 21:26:29 +00:00
parent d210082dad
commit 8428de7a00
2 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/NzbDrone.Core.Test/HealthCheck/Checks/MonoVersionCheckFixture.cs
View File

@ -28,9 +28,9 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks
.Returns(new Version(version));
}
[TestCase("5.18")]
[TestCase("5.20")]
[TestCase("6.4")]
[TestCase("6.12")]
public void should_return_ok(string version)
{
GivenOutput(version);
@ -71,6 +71,7 @@ namespace NzbDrone.Core.Test.HealthCheck.Checks
[TestCase("5.12")]
[TestCase("5.14")]
[TestCase("5.16")]
[TestCase("5.18")]
public void should_return_error(string version)
{
GivenOutput(version);

16
src/NzbDrone.Core/HealthCheck/Checks/MonoVersionCheck.cs
View File

@ -26,19 +26,9 @@ namespace NzbDrone.Core.HealthCheck.Checks
var monoVersion = _platformInfo.Version;
// Known buggy Mono versions
if (monoVersion == new Version("4.4.0") || monoVersion == new Version("4.4.1"))
{
_logger.Debug("Mono version {0}", monoVersion);
return new HealthCheck(GetType(),
HealthCheckResult.Error,
$"Currently installed Mono version {monoVersion} has a bug that causes issues connecting to indexers/download clients. You should upgrade to a higher version",
"#currently_installed_mono_version_is_old_and_unsupported");
}
// Currently best stable Mono version (5.18 gets us .net 4.7.2 support)
var bestVersion = new Version("5.20");
var targetVersion = new Version("5.18");
var targetVersion = new Version("5.20");
if (monoVersion >= targetVersion)
{
_logger.Debug("Mono version is {0} or better: {1}", targetVersion, monoVersion);
@ -46,7 +36,7 @@ namespace NzbDrone.Core.HealthCheck.Checks
}
// Stable Mono versions
var stableVersion = new Version("5.18");
var stableVersion = new Version("5.20");
if (monoVersion >= stableVersion)
{
_logger.Debug("Mono version is {0} or better: {1}", stableVersion, monoVersion);
@ -56,7 +46,7 @@ namespace NzbDrone.Core.HealthCheck.Checks
"#currently_installed_mono_version_is_supported_but_upgrading_is_recommended");
}
var oldVersion = new Version("5.4");
var oldVersion = new Version("5.20");
if (monoVersion >= oldVersion)
{
return new HealthCheck(GetType(),