mirror/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2025-02-24 07:10:57 +00:00
Code Issues Releases Wiki Activity

New: Even More Mono Cleaning

Browse source
This commit is contained in:
Qstick 2021-06-28 18:53:58 -04:00
parent cc572729ff
commit 92c4c50e1c
24 changed files with 6 additions and 232 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frontend/src/System/Status/About/About.js
View file

@ -20,7 +20,6 @@ class About extends Component {
packageVersion,
packageAuthor,
isNetCore,
isMono,
isDocker,
runtimeVersion,
migrationVersion,
@ -48,14 +47,6 @@ class About extends Component {
/>
}
{
isMono &&
<DescriptionListItem
title={translate('MonoVersion')}
data={runtimeVersion}
/>
}
{
isNetCore &&
<DescriptionListItem
@ -114,7 +105,6 @@ About.propTypes = {
packageVersion: PropTypes.string,
packageAuthor: PropTypes.string,
isNetCore: PropTypes.bool.isRequired,
isMono: PropTypes.bool.isRequired,
runtimeVersion: PropTypes.string.isRequired,
isDocker: PropTypes.bool.isRequired,
migrationVersion: PropTypes.number.isRequired,

38
src/NzbDrone.Common.Test/DiskTests/DiskTransferServiceFixture.cs
View file

@ -436,24 +436,6 @@ public void CopyFolder_should_detect_caseinsensitive_folder()
Assert.Throws<IOException>(() => Subject.TransferFolder(source.FullName, destination.FullName, TransferMode.Copy));
}
[Test]
public void CopyFolder_should_not_copy_casesensitive_folder()
{
MonoOnly();
WithRealDiskProvider();
var original = GetFilledTempFolder();
var root = new DirectoryInfo(GetTempFilePath());
var source = new DirectoryInfo(root.FullName + "A/series");
var destination = new DirectoryInfo(root.FullName + "A/Series");
Subject.TransferFolder(original.FullName, source.FullName, TransferMode.Copy);
// Note: Although technically possible top copy to different case, we're not allowing it
Assert.Throws<IOException>(() => Subject.TransferFolder(source.FullName, destination.FullName, TransferMode.Copy));
}
[Test]
public void CopyFolder_should_ignore_nfs_temp_file()
{
@ -539,26 +521,6 @@ public void MoveFolder_should_rename_caseinsensitive_folder()
source.FullName.GetActualCasing().Should().Be(destination.FullName);
}
[Test]
public void MoveFolder_should_rename_casesensitive_folder()
{
MonoOnly();
WithRealDiskProvider();
var original = GetFilledTempFolder();
var root = new DirectoryInfo(GetTempFilePath());
var source = new DirectoryInfo(root.FullName + "A/series");
var destination = new DirectoryInfo(root.FullName + "A/Series");
Subject.TransferFolder(original.FullName, source.FullName, TransferMode.Copy);
Subject.TransferFolder(source.FullName, destination.FullName, TransferMode.Move);
Directory.Exists(source.FullName).Should().Be(false);
Directory.Exists(destination.FullName).Should().Be(true);
}
[Test]
public void should_throw_if_destination_is_readonly()
{

5
src/NzbDrone.Common.Test/Http/HttpClientFixture.cs
View file

@ -251,11 +251,6 @@ public void should_not_follow_redirects()
[Test]
public void should_follow_redirects_to_https()
{
if (typeof(TDispatcher) == typeof(ManagedHttpDispatcher) && PlatformInfo.IsMono)
{
Assert.Ignore("Will fail on tls1.2 via managed dispatcher, ignore.");
}
var request = new HttpRequestBuilder($"https://{_httpBinHost}/redirect-to")
.AddQueryParam("url", $"https://radarr.video/")
.Build();

2
src/NzbDrone.Common.Test/ProcessProviderFixture.cs
View file

@ -170,7 +170,7 @@ private Process StartDummyProcess()
var processStarted = new ManualResetEventSlim();
string suffix;
if (OsInfo.IsWindows || PlatformInfo.IsMono)
if (OsInfo.IsWindows)
{
suffix = ".exe";
}

40
src/NzbDrone.Common/EnvironmentInfo/PlatformInfo.cs
View file

@ -1,6 +1,4 @@
using System;
using System.Reflection;
using System.Text.RegularExpressions;
using System;
using Microsoft.Win32;
namespace NzbDrone.Common.EnvironmentInfo
@ -19,8 +17,6 @@ public interface IPlatformInfo
public class PlatformInfo : IPlatformInfo
{
private static readonly Regex MonoVersionRegex = new Regex(@"(?<=\W|^)(?<version>\d+\.\d+(\.\d+)?(\.\d+)?)(?=\W)", RegexOptions.Compiled | RegexOptions.IgnoreCase);
private static PlatformType _platform;
private static Version _version;
@ -31,7 +27,6 @@ static PlatformInfo()
}
public static PlatformType Platform => _platform;
public static bool IsMono => Platform == PlatformType.Mono;
public static bool IsDotNet => Platform == PlatformType.DotNet;
public static bool IsNetCore => Platform == PlatformType.NetCore;
@ -43,10 +38,6 @@ public static string PlatformName
{
return ".NET";
}
else if (IsMono)
{
return "Mono";
}
else
{
return ".NET Core";
@ -61,35 +52,6 @@ public static Version GetVersion()
return _version;
}
private static Version GetMonoVersion()
{
try
{
var type = Type.GetType("Mono.Runtime");
if (type != null)
{
var displayNameMethod = type.GetMethod("GetDisplayName", BindingFlags.NonPublic | BindingFlags.Static);
if (displayNameMethod != null)
{
var displayName = displayNameMethod.Invoke(null, null).ToString();
var versionMatch = MonoVersionRegex.Match(displayName);
if (versionMatch.Success)
{
return new Version(versionMatch.Groups["version"].Value);
}
}
}
}
catch (Exception ex)
{
Console.WriteLine("Couldnt get Mono version: " + ex.ToString());
}
return new Version();
}
private static Version GetDotNetVersion()
{
try

10
src/NzbDrone.Common/Instrumentation/GlobalExceptionHandlers.cs
View file

@ -44,16 +44,6 @@ private static void HandleAppDomainException(object sender, UnhandledExceptionEv
return;
}
if (PlatformInfo.IsMono)
{
if ((exception is TypeInitializationException && exception.InnerException is DllNotFoundException) ||
exception is DllNotFoundException)
{
Logger.Debug(exception, "Minor Fail: " + exception.Message);
return;
}
}
Console.WriteLine("EPIC FAIL: {0}", exception);
Logger.Fatal(exception, "EPIC FAIL.");
}

15
src/NzbDrone.Common/Instrumentation/Sentry/SentryTarget.cs
View file

@ -106,13 +106,6 @@ public SentryTarget(string dsn)
o.Debug = false;
o.DiagnosticsLevel = SentryLevel.Debug;
o.Release = BuildInfo.Release;
if (PlatformInfo.IsMono)
{
// Mono 6.0 broke GzipStream.WriteAsync
// TODO: Check specific version
o.RequestBodyCompressionLevel = System.IO.Compression.CompressionLevel.NoCompression;
}
o.BeforeSend = x => SentryCleanser.CleanseEvent(x);
o.BeforeBreadcrumb = x => SentryCleanser.CleanseBreadcrumb(x);
o.Environment = BuildInfo.Branch;
@ -154,14 +147,6 @@ public void UpdateScope(IOsInfo osInfo)
SentrySdk.ConfigureScope(scope =>
{
scope.SetTag("is_docker", $"{osInfo.IsDocker}");
if (osInfo.Name != null && PlatformInfo.IsMono)
{
// Sentry auto-detection of non-Windows platforms isn't that accurate on certain devices.
scope.Contexts.OperatingSystem.Name = osInfo.Name.FirstCharToUpper();
scope.Contexts.OperatingSystem.RawDescription = osInfo.FullName;
scope.Contexts.OperatingSystem.Version = osInfo.Version.ToString();
}
});
}

5
src/NzbDrone.Common/Processes/ProcessProvider.cs
View file

@ -366,11 +366,6 @@ private List<Process> GetProcessesByName(string name)
private (string Path, string Args) GetPathAndArgs(string path, string args)
{
if (PlatformInfo.IsMono && path.EndsWith(".exe", StringComparison.InvariantCultureIgnoreCase))
{
return ("mono", $"--debug {path} {args}");
}
if (OsInfo.IsWindows && path.EndsWith(".bat", StringComparison.InvariantCultureIgnoreCase))
{
return ("cmd.exe", $"/c {path} {args}");

5
src/NzbDrone.Core.Test/MediaCoverTests/ImageResizerFixture.cs
View file

@ -16,11 +16,6 @@ public class ImageResizerFixture : CoreTest<MediaCover.ImageResizer>
[SetUp]
public void SetUp()
{
if (PlatformInfo.IsMono && PlatformInfo.GetVersion() < new Version(5, 8))
{
Assert.Inconclusive("Not supported on Mono < 5.8");
}
Mocker.GetMock<IDiskProvider>()
.Setup(v => v.FileExists(It.IsAny<string>()))
.Returns<string>(s => File.Exists(s));

17
src/NzbDrone.Core.Test/MediaFiles/ImportApprovedMoviesFixture.cs
View file

@ -347,23 +347,6 @@ public void should_get_relative_path_when_there_is_no_grandparent_windows()
Mocker.GetMock<IMediaFileService>().Verify(v => v.Add(It.Is<MovieFile>(c => c.OriginalFilePath == $"{name}.mkv".AsOsAgnostic())));
}
[Test]
public void should_get_relative_path_when_there_is_no_grandparent_mono()
{
MonoOnly();
var name = "Transformers.2007.720p.BluRay.x264-Radarr";
var outputPath = "/";
var localMovie = _approvedDecisions.First().LocalMovie;
localMovie.FolderMovieInfo = new ParsedMovieInfo { ReleaseTitle = name };
localMovie.Path = Path.Combine(outputPath, name + ".mkv");
Subject.Import(new List<ImportDecision> { _approvedDecisions.First() }, true, null);
Mocker.GetMock<IMediaFileService>().Verify(v => v.Add(It.Is<MovieFile>(c => c.OriginalFilePath == $"{name}.mkv".AsOsAgnostic())));
}
[Test]
public void should_get_relative_path_when_there_is_no_grandparent_for_UNC_path()
{

6
src/NzbDrone.Core/MediaCover/ImageResizer.cs
View file

@ -21,12 +21,6 @@ public ImageResizer(IDiskProvider diskProvider, IPlatformInfo platformInfo)
{
_diskProvider = diskProvider;
// Random segfaults on mono 5.0 and 5.4
if (PlatformInfo.IsMono && platformInfo.Version < new System.Version(5, 8))
{
return;
}
_enabled = true;
// More conservative memory allocation

8
src/NzbDrone.Integration.Test/ApiTests/DownloadClientFixture.cs
View file

@ -11,8 +11,6 @@ public class DownloadClientFixture : IntegrationTest
[Order(0)]
public void add_downloadclient_without_name_should_return_badrequest()
{
IgnoreOnMonoVersions("5.12", "5.14");
EnsureNoDownloadClient();
var schema = DownloadClients.Schema().First(v => v.Implementation == "UsenetBlackhole");
@ -28,8 +26,6 @@ public void add_downloadclient_without_name_should_return_badrequest()
[Order(0)]
public void add_downloadclient_without_nzbfolder_should_return_badrequest()
{
IgnoreOnMonoVersions("5.12", "5.14");
EnsureNoDownloadClient();
var schema = DownloadClients.Schema().First(v => v.Implementation == "UsenetBlackhole");
@ -45,8 +41,6 @@ public void add_downloadclient_without_nzbfolder_should_return_badrequest()
[Order(0)]
public void add_downloadclient_without_watchfolder_should_return_badrequest()
{
IgnoreOnMonoVersions("5.12", "5.14");
EnsureNoDownloadClient();
var schema = DownloadClients.Schema().First(v => v.Implementation == "UsenetBlackhole");
@ -101,8 +95,6 @@ public void get_downloadclient_by_id()
[Test]
public void get_downloadclient_by_unknown_id_should_return_404()
{
IgnoreOnMonoVersions("5.12", "5.14");
var result = DownloadClients.InvalidGet(1000000);
}

6
src/NzbDrone.Integration.Test/ApiTests/MovieFixture.cs
View file

@ -33,8 +33,6 @@ public void add_movie_with_tags_should_store_them()
[Order(0)]
public void add_movie_without_profileid_should_return_badrequest()
{
IgnoreOnMonoVersions("5.12", "5.14");
EnsureNoMovie(680, "Pulp Fiction");
var movie = Movies.Lookup("imdb:tt0110912").Single();
@ -48,8 +46,6 @@ public void add_movie_without_profileid_should_return_badrequest()
[Order(0)]
public void add_movie_without_path_should_return_badrequest()
{
IgnoreOnMonoVersions("5.12", "5.14");
EnsureNoMovie(680, "Pulp Fiction");
var movie = Movies.Lookup("imdb:tt0110912").Single();
@ -126,8 +122,6 @@ public void get_movie_by_id()
[Test]
public void get_movie_by_unknown_id_should_return_404()
{
IgnoreOnMonoVersions("5.12", "5.14");
var result = Movies.InvalidGet(1000000);
}

10
src/NzbDrone.Integration.Test/ApiTests/NamingConfigFixture.cs
View file

@ -35,8 +35,6 @@ public void should_be_able_to_update()
[Test]
public void should_get_bad_request_if_standard_format_is_empty()
{
IgnoreOnMonoVersions("5.12", "5.14");
var config = NamingConfig.GetSingle();
config.RenameMovies = true;
config.StandardMovieFormat = "";
@ -48,8 +46,6 @@ public void should_get_bad_request_if_standard_format_is_empty()
[Test]
public void should_get_bad_request_if_standard_format_doesnt_contain_title()
{
IgnoreOnMonoVersions("5.12", "5.14");
var config = NamingConfig.GetSingle();
config.RenameMovies = true;
config.StandardMovieFormat = "{quality}";
@ -61,8 +57,6 @@ public void should_get_bad_request_if_standard_format_doesnt_contain_title()
[Test]
public void should_not_require_format_when_rename_episodes_is_false()
{
IgnoreOnMonoVersions("5.12", "5.14");
var config = NamingConfig.GetSingle();
config.RenameMovies = false;
config.StandardMovieFormat = "";
@ -74,8 +68,6 @@ public void should_not_require_format_when_rename_episodes_is_false()
[Test]
public void should_require_format_when_rename_episodes_is_true()
{
IgnoreOnMonoVersions("5.12", "5.14");
var config = NamingConfig.GetSingle();
config.RenameMovies = true;
config.StandardMovieFormat = "";
@ -87,8 +79,6 @@ public void should_require_format_when_rename_episodes_is_true()
[Test]
public void should_get_bad_request_if_movie_folder_format_does_not_contain_movie_title()
{
IgnoreOnMonoVersions("5.12", "5.14");
var config = NamingConfig.GetSingle();
config.RenameMovies = true;
config.MovieFolderFormat = "This and That";

2
src/NzbDrone.Integration.Test/ApiTests/RootFolderFixture.cs
View file

@ -42,8 +42,6 @@ public void should_add_and_delete_root_folders()
[Test]
public void invalid_path_should_return_bad_request()
{
IgnoreOnMonoVersions("5.12", "5.14");
var rootFolder = new RootFolderResource
{
Path = "invalid_path"

4
src/NzbDrone.Integration.Test/GenericApiFixture.cs
View file

@ -1,4 +1,4 @@
using System.Net;
using System.Net;
using FluentAssertions;
using NUnit.Framework;
using RestSharp;
@ -33,8 +33,6 @@ public void should_get_json_with_accept_header(string header)
[TestCase("application/junk")]
public void should_get_unacceptable_with_accept_header(string header)
{
IgnoreOnMonoVersions("5.12", "5.14");
var request = new RestRequest("system/status")
{
RequestFormat = DataFormat.None

2
src/NzbDrone.Integration.Test/HttpLogFixture.cs
View file

@ -11,8 +11,6 @@ public class HttpLogFixture : IntegrationTest
[Test]
public void should_log_on_error()
{
IgnoreOnMonoVersions("5.12", "5.14");
var config = HostConfig.Get(1);
config.LogLevel = "Trace";
HostConfig.Put(config);

16
src/NzbDrone.Integration.Test/IntegrationTestBase.cs
View file

@ -155,22 +155,6 @@ public async Task IntegrationTearDown()
}
}
protected void IgnoreOnMonoVersions(params string[] version_strings)
{
if (!PlatformInfo.IsMono)
{
return;
}
var current = PlatformInfo.GetVersion();
var versions = version_strings.Select(x => new Version(x)).ToList();
if (versions.Any(x => x.Major == current.Major && x.Minor == current.Minor))
{
throw new IgnoreException($"Ignored on mono {PlatformInfo.GetVersion()}");
}
}
public string GetTempDirectory(params string[] args)
{
var path = Path.Combine(TempDirectory, Path.Combine(args));

5
src/NzbDrone.Mono.Test/DiskProviderTests/FreeSpaceFixture.cs
View file

@ -10,11 +10,6 @@ namespace NzbDrone.Mono.Test.DiskProviderTests
[Platform(Exclude = "Win")]
public class FreeSpaceFixture : FreeSpaceFixtureBase<DiskProvider>
{
public FreeSpaceFixture()
{
PosixOnly();
}
[SetUp]
public void Setup()
{

13
src/NzbDrone.Mono.Test/DiskProviderTests/SymlinkResolverFixture.cs
View file

@ -1,11 +1,5 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using FluentAssertions;
using Mono.Posix;
using Mono.Unix;
using NUnit.Framework;
using NzbDrone.Mono.Disk;
@ -14,14 +8,9 @@
namespace NzbDrone.Mono.Test.DiskProviderTests
{
[TestFixture]
[Platform("Mono")]
[Platform(Exclude = "Win")]
public class SymbolicLinkResolverFixture : TestBase<SymbolicLinkResolver>
{
public SymbolicLinkResolverFixture()
{
MonoOnly();
}
[Test]
public void should_follow_nested_symlinks()
{

4
src/NzbDrone.Test.Common/NzbDroneRunner.cs
View file

@ -44,10 +44,6 @@ public void Start()
{
consoleExe = "Radarr.Console.exe";
}
else if (PlatformInfo.IsMono)
{
consoleExe = "Radarr.exe";
}
else
{
consoleExe = "Radarr";

8
src/NzbDrone.Test.Common/TestBase.cs
View file

@ -166,14 +166,6 @@ protected void PosixOnly()
}
}
protected void MonoOnly()
{
if (!PlatformInfo.IsMono)
{
throw new IgnoreException("mono specific test");
}
}
protected void NotBsd()
{
if (OsInfo.Os == Os.Bsd)

1
src/Radarr.Api.V3/System/SystemModule.cs
View file

@ -61,7 +61,6 @@ private object GetStatus()
OsName = _osInfo.Name,
OsVersion = _osInfo.Version,
IsNetCore = PlatformInfo.IsNetCore,
IsMono = PlatformInfo.IsMono,
IsLinux = OsInfo.IsLinux,
IsOsx = OsInfo.IsOsx,
IsWindows = OsInfo.IsWindows,

6
src/Radarr.Http/Extensions/Pipelines/GZipPipeline.cs
View file

@ -1,11 +1,10 @@
using System;
using System;
using System.IO;
using System.IO.Compression;
using System.Linq;
using Nancy;
using Nancy.Bootstrapper;
using NLog;
using NzbDrone.Common.EnvironmentInfo;
namespace Radarr.Http.Extensions.Pipelines
{
@ -21,8 +20,7 @@ public GzipCompressionPipeline(Logger logger)
{
_logger = logger;
// On Mono GZipStream/DeflateStream leaks memory if an exception is thrown, use an intermediate buffer in that case.
_writeGZipStream = PlatformInfo.IsMono ? WriteGZipStreamMono : (Action<Action<Stream>, Stream>)WriteGZipStream;
_writeGZipStream = (Action<Action<Stream>, Stream>)WriteGZipStream;
}
public void Register(IPipelines pipelines)