From bb60510515fcc9283ba0c7bff0c49ef8c1dbca66 Mon Sep 17 00:00:00 2001
From: Mark McDowall <mark@mcdowall.ca>
Date: Fri, 4 Nov 2022 14:16:11 -0700
Subject: [PATCH] Added react-hooks lint rules

(cherry picked from commit 381d64259396582de8d63ada99333e42cf5e3189)
---
 frontend/.eslintrc.js                         | 5 ++++-
 frontend/src/Components/Modal/ConfirmModal.js | 2 +-
 frontend/src/Settings/PendingChangesModal.js  | 2 +-
 package.json                                  | 1 +
 yarn.lock                                     | 5 +++++
 5 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/frontend/.eslintrc.js b/frontend/.eslintrc.js
index b087037f4..06695aac2 100644
--- a/frontend/.eslintrc.js
+++ b/frontend/.eslintrc.js
@@ -39,6 +39,7 @@ module.exports = {
   plugins: [
     'filenames',
     'react',
+    'react-hooks',
     'simple-import-sort',
     'import'
   ],
@@ -308,7 +309,9 @@ module.exports = {
     'react/react-in-jsx-scope': 2,
     'react/self-closing-comp': 2,
     'react/sort-comp': 2,
-    'react/jsx-wrap-multilines': 2
+    'react/jsx-wrap-multilines': 2,
+    'react-hooks/rules-of-hooks': 'error',
+    'react-hooks/exhaustive-deps': 'error'
   },
   overrides: [
     {
diff --git a/frontend/src/Components/Modal/ConfirmModal.js b/frontend/src/Components/Modal/ConfirmModal.js
index a6eaf6bd7..c129f29b3 100644
--- a/frontend/src/Components/Modal/ConfirmModal.js
+++ b/frontend/src/Components/Modal/ConfirmModal.js
@@ -33,7 +33,7 @@ function ConfirmModal(props) {
 
       return () => unbindShortcut('enter', onConfirm);
     }
-  }, [isOpen, onConfirm]);
+  }, [bindShortcut, unbindShortcut, isOpen, onConfirm]);
 
   return (
     <Modal
diff --git a/frontend/src/Settings/PendingChangesModal.js b/frontend/src/Settings/PendingChangesModal.js
index 288a3dc08..4cb83e8f6 100644
--- a/frontend/src/Settings/PendingChangesModal.js
+++ b/frontend/src/Settings/PendingChangesModal.js
@@ -20,7 +20,7 @@ function PendingChangesModal(props) {
 
   useEffect(() => {
     bindShortcut('enter', onConfirm);
-  }, [onConfirm]);
+  }, [bindShortcut, onConfirm]);
 
   return (
     <Modal
diff --git a/package.json b/package.json
index 89feae305..1eb41254e 100644
--- a/package.json
+++ b/package.json
@@ -107,6 +107,7 @@
     "eslint-plugin-import": "2.25.4",
     "eslint-plugin-json": "3.1.0",
     "eslint-plugin-react": "7.29.4",
+    "eslint-plugin-react-hooks": "4.6.0",
     "eslint-plugin-simple-import-sort": "7.0.0",
     "esprint": "3.3.0",
     "file-loader": "6.2.0",
diff --git a/yarn.lock b/yarn.lock
index 94b7b5ae3..549b60abb 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2980,6 +2980,11 @@ eslint-plugin-json@3.1.0:
     lodash "^4.17.21"
     vscode-json-languageservice "^4.1.6"
 
+eslint-plugin-react-hooks@4.6.0:
+  version "4.6.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-4.6.0.tgz#4c3e697ad95b77e93f8646aaa1630c1ba607edd3"
+  integrity sha512-oFc7Itz9Qxh2x4gNHStv3BqJq54ExXmfC+a1NjAta66IAN87Wu0R/QArgIS9qKzX3dXKPI9H5crl9QchNMY9+g==
+
 eslint-plugin-react@7.29.4:
   version "7.29.4"
   resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.29.4.tgz#4717de5227f55f3801a5fd51a16a4fa22b5914d2"