From bfff736cfc8b9a52c55ed759e673d022c3cbaca4 Mon Sep 17 00:00:00 2001
From: Bogdan <mynameisbogdan@users.noreply.github.com>
Date: Sun, 28 Jan 2024 14:50:57 +0200
Subject: [PATCH] Translations and some cleanup for extra files and movie
 editor tables

---
 .../MovieFile/Editor/MovieFileEditorTableContent.js   |  3 ++-
 .../Editor/MovieFileEditorTableContentConnector.js    |  8 +++-----
 .../src/MovieFile/Extras/ExtraFileTableContent.js     |  2 +-
 .../Extras/ExtraFileTableContentConnector.js          | 11 ++---------
 src/NzbDrone.Core/Localization/Core/en.json           |  2 ++
 5 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/frontend/src/MovieFile/Editor/MovieFileEditorTableContent.js b/frontend/src/MovieFile/Editor/MovieFileEditorTableContent.js
index 225b57024..259f8c935 100644
--- a/frontend/src/MovieFile/Editor/MovieFileEditorTableContent.js
+++ b/frontend/src/MovieFile/Editor/MovieFileEditorTableContent.js
@@ -2,6 +2,7 @@ import PropTypes from 'prop-types';
 import React, { Component } from 'react';
 import Table from 'Components/Table/Table';
 import TableBody from 'Components/Table/TableBody';
+import translate from 'Utilities/String/translate';
 import MovieFileEditorRow from './MovieFileEditorRow';
 import styles from './MovieFileEditorTableContent.css';
 
@@ -22,7 +23,7 @@ class MovieFileEditorTableContent extends Component {
         {
           !items.length &&
             <div className={styles.blankpad}>
-              No movie files to manage.
+              {translate('NoMovieFilesToManage')}
             </div>
         }
 
diff --git a/frontend/src/MovieFile/Editor/MovieFileEditorTableContentConnector.js b/frontend/src/MovieFile/Editor/MovieFileEditorTableContentConnector.js
index 59763222d..b3e190228 100644
--- a/frontend/src/MovieFile/Editor/MovieFileEditorTableContentConnector.js
+++ b/frontend/src/MovieFile/Editor/MovieFileEditorTableContentConnector.js
@@ -23,9 +23,7 @@ function createMapStateToProps() {
     ) => {
       const languages = languageProfiles.items;
       const qualities = getQualities(qualityProfiles.schema.items);
-      const filesForMovie = movieFiles.items.filter((obj) => {
-        return obj.movieId === movieId;
-      });
+      const filesForMovie = movieFiles.items.filter((file) => file.movieId === movieId);
 
       return {
         items: filesForMovie,
@@ -42,11 +40,11 @@ function createMapStateToProps() {
 
 function createMapDispatchToProps(dispatch, props) {
   return {
-    dispatchFetchQualityProfileSchema(name, path) {
+    dispatchFetchQualityProfileSchema() {
       dispatch(fetchQualityProfileSchema());
     },
 
-    dispatchFetchLanguages(name, path) {
+    dispatchFetchLanguages() {
       dispatch(fetchLanguages());
     },
 
diff --git a/frontend/src/MovieFile/Extras/ExtraFileTableContent.js b/frontend/src/MovieFile/Extras/ExtraFileTableContent.js
index ae560d5d8..308ac18ec 100644
--- a/frontend/src/MovieFile/Extras/ExtraFileTableContent.js
+++ b/frontend/src/MovieFile/Extras/ExtraFileTableContent.js
@@ -46,7 +46,7 @@ class ExtraFileTableContent extends Component {
         {
           !items.length &&
             <div className={styles.blankpad}>
-              No extra files to manage.
+              {translate('NoExtraFilesToManage')}
             </div>
         }
 
diff --git a/frontend/src/MovieFile/Extras/ExtraFileTableContentConnector.js b/frontend/src/MovieFile/Extras/ExtraFileTableContentConnector.js
index 0454bb3f5..aec7925a4 100644
--- a/frontend/src/MovieFile/Extras/ExtraFileTableContentConnector.js
+++ b/frontend/src/MovieFile/Extras/ExtraFileTableContentConnector.js
@@ -14,9 +14,7 @@ function createMapStateToProps() {
       movieId,
       extraFiles
     ) => {
-      const filesForMovie = extraFiles.items.filter((obj) => {
-        return obj.movieId === movieId;
-      });
+      const filesForMovie = extraFiles.items.filter((file) => file.movieId === movieId);
 
       return {
         items: filesForMovie,
@@ -26,11 +24,6 @@ function createMapStateToProps() {
   );
 }
 
-function createMapDispatchToProps(dispatch, props) {
-  return {
-  };
-}
-
 class ExtraFileTableContentConnector extends Component {
 
   //
@@ -53,4 +46,4 @@ ExtraFileTableContentConnector.propTypes = {
   movieId: PropTypes.number.isRequired
 };
 
-export default connect(createMapStateToProps, createMapDispatchToProps)(ExtraFileTableContentConnector);
+export default connect(createMapStateToProps, null)(ExtraFileTableContentConnector);
diff --git a/src/NzbDrone.Core/Localization/Core/en.json b/src/NzbDrone.Core/Localization/Core/en.json
index 11a34da91..e572283c2 100644
--- a/src/NzbDrone.Core/Localization/Core/en.json
+++ b/src/NzbDrone.Core/Localization/Core/en.json
@@ -910,6 +910,7 @@
   "NoCollections": "No collections found, to get started you'll want to add a new movie, or import some existing ones",
   "NoDownloadClientsFound": "No download clients found",
   "NoEventsFound": "No events found",
+  "NoExtraFilesToManage": "No extra files to manage.",
   "NoHistory": "No history",
   "NoHistoryBlocklist": "No history blocklist",
   "NoHistoryFound": "No history found",
@@ -924,6 +925,7 @@
   "NoMatchFound": "No match found!",
   "NoMinimumForAnyRuntime": "No minimum for any runtime",
   "NoMoveFilesSelf": " No, I'll Move the Files Myself",
+  "NoMovieFilesToManage": "No movie files to manage.",
   "NoMoviesExist": "No movies found, to get started you'll want to add a new movie or import some existing ones.",
   "NoResultsFound": "No results found",
   "NoTagsHaveBeenAddedYet": "No tags have been added yet",