mirror
/
Radarr
mirror of https://github.com/Radarr/Radarr
1
0
Fork 0
Code Issues Releases Wiki Activity

Use MinBy and MaxBy instead of OrderBy + First 

Co-Authored-By: Stepan Goremykin <25577658+goremykin@users.noreply.github.com>
This commit is contained in:
Qstick 2023-04-22 20:10:04 -05:00
parent e0ad573e7f
commit cc285fab45
4 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/NzbDrone.Common/Disk/DiskProviderBase.cs
View File

@ -483,12 +483,11 @@ namespace NzbDrone.Common.Disk
return mounts.Where(drive => drive.RootDirectory.PathEquals(path) ||
drive.RootDirectory.IsParentPath(path))
.OrderByDescending(drive => drive.RootDirectory.Length)
.FirstOrDefault();
.MaxBy(drive => drive.RootDirectory.Length);
}
catch (Exception ex)
{
Logger.Debug(ex, string.Format("Failed to get mount for path {0}", path));
Logger.Debug(ex, $"Failed to get mount for path {path}");
return null;
}
}

3
src/NzbDrone.Core/Download/Pending/PendingReleaseService.cs
View File

@ -239,8 +239,7 @@ namespace NzbDrone.Core.Download.Pending
var movieReleases = GetPendingReleases(movieId);
return movieReleases.Select(r => r.RemoteMovie)
.OrderByDescending(p => p.Release.AgeHours)
.FirstOrDefault();
.MaxBy(p => p.Release.AgeHours);
}
private List<PendingRelease> GetPendingReleases()

8
src/NzbDrone.Core/History/HistoryRepository.cs
View File

@ -37,9 +37,7 @@ namespace NzbDrone.Core.History
public MovieHistory MostRecentForDownloadId(string downloadId)
{
return FindByDownloadId(downloadId)
.OrderByDescending(h => h.Date)
.FirstOrDefault();
return FindByDownloadId(downloadId).MaxBy(h => h.Date);
}
public List<MovieHistory> FindByDownloadId(string downloadId)
@ -90,9 +88,7 @@ namespace NzbDrone.Core.History
public MovieHistory MostRecentForMovie(int movieId)
{
return Query(x => x.MovieId == movieId)
.OrderByDescending(h => h.Date)
.FirstOrDefault();
return Query(x => x.MovieId == movieId).MaxBy(h => h.Date);
}
public List<MovieHistory> Since(DateTime date, MovieHistoryEventType? eventType)

4
src/NzbDrone.Core/RootFolders/RootFolderService.cs
View File

@ -182,9 +182,7 @@ namespace NzbDrone.Core.RootFolders
public string GetBestRootFolderPath(string path)
{
var possibleRootFolder = All().Where(r => r.Path.IsParentPath(path))
.OrderByDescending(r => r.Path.Length)
.FirstOrDefault();
var possibleRootFolder = All().Where(r => r.Path.IsParentPath(path)).MaxBy(r => r.Path.Length);
if (possibleRootFolder == null)
{