mirror/Radarr
1
0
Fork 0
mirror of https://github.com/Radarr/Radarr synced 2025-02-21 13:57:02 +00:00
Code Issues Releases Wiki Activity

Fixed: Resource leakage inside ManagedHttpDispatcher.

Browse source
This commit is contained in:
Leonardo Galli 2018-12-01 16:45:09 +01:00
parent 42015d5d95
commit eb077b043e
1 changed files with 73 additions and 61 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/NzbDrone.Common/Http/Dispatchers/ManagedHttpDispatcher.cs
View file

@ -20,7 +20,11 @@ public ManagedHttpDispatcher(IHttpProxySettingsProvider proxySettingsProvider, I
public HttpResponse GetResponse(HttpRequest request, CookieContainer cookies)
{
var webRequest = (HttpWebRequest)WebRequest.Create((Uri)request.Url);
HttpWebResponse httpWebResponse = null;
HttpWebRequest webRequest = null;
try
{
webRequest = (HttpWebRequest) WebRequest.Create((Uri) request.Url);
// Deflate is not a standard and could break depending on implementation.
// we should just stick with the more compatible Gzip
@ -28,7 +32,9 @@ public HttpResponse GetResponse(HttpRequest request, CookieContainer cookies)
webRequest.AutomaticDecompression = DecompressionMethods.GZip;
webRequest.Method = request.Method.ToString();
webRequest.UserAgent = request.UseSimplifiedUserAgent ? UserAgentBuilder.UserAgentSimplified : UserAgentBuilder.UserAgent;
webRequest.UserAgent = request.UseSimplifiedUserAgent
? UserAgentBuilder.UserAgentSimplified
: UserAgentBuilder.UserAgent;
webRequest.KeepAlive = request.ConnectionKeepAlive;
webRequest.AllowAutoRedirect = false;
webRequest.CookieContainer = cookies;
@ -54,8 +60,6 @@ public HttpResponse GetResponse(HttpRequest request, CookieContainer cookies)
}
}
HttpWebResponse httpWebResponse;
try
{
httpWebResponse = (HttpWebResponse) webRequest.GetResponse();
@ -85,7 +89,15 @@ public HttpResponse GetResponse(HttpRequest request, CookieContainer cookies)
}
}
return new HttpResponse(request, new HttpHeader(httpWebResponse.Headers), data, httpWebResponse.StatusCode);
return new HttpResponse(request, new HttpHeader(httpWebResponse.Headers), data,
httpWebResponse.StatusCode);
}
finally
{
webRequest = null;
httpWebResponse?.Dispose();
httpWebResponse = null;
}
}
protected virtual void AddProxy(HttpWebRequest webRequest, HttpRequest request)