New: Health check for AppData and Startup folder conflict

src/NzbDrone.Core.Test/HealthCheck/Checks/AppDataLocationFixture.cs

@@ -0,0 +1,54 @@
+using NUnit.Framework;
+using NzbDrone.Common.EnvironmentInfo;
+using NzbDrone.Core.HealthCheck.Checks;
+using NzbDrone.Core.Test.Framework;
+using NzbDrone.Test.Common;
+
+namespace NzbDrone.Core.Test.HealthCheck.Checks
+{
+    [TestFixture]
+    public class AppDataLocationFixture : CoreTest<AppDataLocationCheck>
+    {
+        [Test]
+        public void should_return_warning_when_app_data_is_child_of_startup_folder()
+        {
+            Mocker.GetMock<IAppFolderInfo>()
+                  .Setup(s => s.StartUpFolder)
+                  .Returns(@"C:\NzbDrone".AsOsAgnostic());
+
+            Mocker.GetMock<IAppFolderInfo>()
+                  .Setup(s => s.AppDataFolder)
+                  .Returns(@"C:\NzbDrone\AppData".AsOsAgnostic());
+
+            Subject.Check().ShouldBeWarning();
+        }
+
+        [Test]
+        public void should_return_warning_when_app_data_is_same_as_startup_folder()
+        {
+            Mocker.GetMock<IAppFolderInfo>()
+                  .Setup(s => s.StartUpFolder)
+                  .Returns(@"C:\NzbDrone".AsOsAgnostic());
+
+            Mocker.GetMock<IAppFolderInfo>()
+                  .Setup(s => s.AppDataFolder)
+                  .Returns(@"C:\NzbDrone".AsOsAgnostic());
+
+            Subject.Check().ShouldBeWarning();
+        }
+
+        [Test]
+        public void should_return_ok_when_no_conflict()
+        {
+            Mocker.GetMock<IAppFolderInfo>()
+                  .Setup(s => s.StartUpFolder)
+                  .Returns(@"C:\NzbDrone".AsOsAgnostic());
+
+            Mocker.GetMock<IAppFolderInfo>()
+                  .Setup(s => s.AppDataFolder)
+                  .Returns(@"C:\ProgramData\NzbDrone".AsOsAgnostic());
+
+            Subject.Check().ShouldBeOk();
+        }
+    }
+}

src/NzbDrone.Core.Test/HealthCheck/Checks/UpdateCheckFixture.cs

@@ -1,10 +1,9 @@
 using System;
-using FluentAssertions;
 using Moq;
 using NUnit.Framework;
 using NzbDrone.Common.Disk;
 using NzbDrone.Common.EnvironmentInfo;
-using NzbDrone.Core.HealthCheck;
+using NzbDrone.Core.Configuration;
 using NzbDrone.Core.HealthCheck.Checks;
 using NzbDrone.Core.Test.Framework;
 
@@ -28,5 +27,25 @@ public void should_return_error_when_app_folder_is_write_protected()
 
             Subject.Check().ShouldBeError();
         }
+
+        [Test]
+        public void should_return_error_when_app_folder_is_write_protected_and_update_automatically_is_enabled()
+        {
+            MonoOnly();
+
+            Mocker.GetMock<IConfigFileProvider>()
+                  .Setup(s => s.UpdateAutomatically)
+                  .Returns(true);
+
+            Mocker.GetMock<IAppFolderInfo>()
+                  .Setup(s => s.StartUpFolder)
+                  .Returns(@"/opt/nzbdrone");
+
+            Mocker.GetMock<IDiskProvider>()
+                  .Setup(s => s.WriteAllText(It.IsAny<String>(), It.IsAny<String>()))
+                  .Throws<Exception>();
+
+            Subject.Check().ShouldBeError();
+        }
     }
 }

src/NzbDrone.Core.Test/NzbDrone.Core.Test.csproj

@@ -126,6 +126,7 @@
     <Compile Include="Framework\CoreTest.cs" />
     <Compile Include="Framework\DbTest.cs" />
     <Compile Include="Framework\NBuilderExtensions.cs" />
+    <Compile Include="HealthCheck\Checks\AppDataLocationFixture.cs" />
     <Compile Include="HealthCheck\Checks\RootFolderCheckFixture.cs" />
     <Compile Include="HealthCheck\Checks\DownloadClientCheckFixture.cs" />
     <Compile Include="HealthCheck\Checks\ImportMechanismCheckFixture.cs" />

src/NzbDrone.Core/HealthCheck/Checks/AppDataLocationCheck.cs

@@ -0,0 +1,34 @@
+using NzbDrone.Common;
+using NzbDrone.Common.EnvironmentInfo;
+
+namespace NzbDrone.Core.HealthCheck.Checks
+{
+    public class AppDataLocationCheck : HealthCheckBase
+    {
+        private readonly IAppFolderInfo _appFolderInfo;
+
+        public AppDataLocationCheck(IAppFolderInfo appFolderInfo)
+        {
+            _appFolderInfo = appFolderInfo;
+        }
+        
+        public override HealthCheck Check()
+        {
+            if (_appFolderInfo.StartUpFolder.IsParentPath(_appFolderInfo.AppDataFolder) ||
+                _appFolderInfo.StartUpFolder.PathEquals(_appFolderInfo.AppDataFolder))
+            {
+                return new HealthCheck(GetType(), HealthCheckResult.Warning, "Updating will not be possible to prevent deleting AppData on Update");
+            }
+
+            return new HealthCheck(GetType());
+        }
+
+        public override bool CheckOnConfigChange
+        {
+            get
+            {
+                return false;
+            }
+        }
+    }
+}

src/NzbDrone.Core/HealthCheck/Checks/UpdateCheck.cs

@@ -2,6 +2,7 @@
 using System.IO;
 using NzbDrone.Common.Disk;
 using NzbDrone.Common.EnvironmentInfo;
+using NzbDrone.Core.Configuration;
 using NzbDrone.Core.Update;
 
 namespace NzbDrone.Core.HealthCheck.Checks
@@ -11,19 +12,22 @@ public class UpdateCheck : HealthCheckBase
         private readonly IDiskProvider _diskProvider;
         private readonly IAppFolderInfo _appFolderInfo;
         private readonly ICheckUpdateService _checkUpdateService;
+        private readonly IConfigFileProvider _configFileProvider;
 
-        public UpdateCheck(IDiskProvider diskProvider, IAppFolderInfo appFolderInfo, ICheckUpdateService checkUpdateService)
+        public UpdateCheck(IDiskProvider diskProvider,
+                           IAppFolderInfo appFolderInfo,
+                           ICheckUpdateService checkUpdateService,
+                           IConfigFileProvider configFileProvider)
         {
             _diskProvider = diskProvider;
             _appFolderInfo = appFolderInfo;
             _checkUpdateService = checkUpdateService;
+            _configFileProvider = configFileProvider;
         }
         
-
         public override HealthCheck Check()
         {
-            //TODO: Check on mono as well
+            if (OsInfo.IsWindows || (OsInfo.IsMono && _configFileProvider.UpdateAutomatically))
-            if (OsInfo.IsWindows)
             {
                 try
                 {

src/NzbDrone.Core/NzbDrone.Core.csproj

@@ -285,6 +285,7 @@
     <Compile Include="Exceptions\NzbDroneClientException.cs" />
     <Compile Include="Exceptions\StatusCodeToExceptions.cs" />
     <Compile Include="HealthCheck\CheckHealthCommand.cs" />
+    <Compile Include="HealthCheck\Checks\AppDataLocationCheck.cs" />
     <Compile Include="HealthCheck\Checks\DownloadClientCheck.cs" />
     <Compile Include="HealthCheck\Checks\ImportMechanismCheck.cs" />
     <Compile Include="HealthCheck\Checks\MonoVersionCheck.cs" />

src/NzbDrone.Core/Update/InstallUpdateService.cs

@@ -60,6 +60,8 @@ public void InstallUpdate(UpdatePackage updatePackage)
         {
             try
             {
+                EnsureAppDataSafety();
+
                 var updateSandboxFolder = _appFolderInfo.GetUpdateSandboxFolder();
 
                 var packageDestination = Path.Combine(updateSandboxFolder, updatePackage.FileName);
@@ -139,6 +141,15 @@ private string GetUpdaterArgs(string updateSandboxFolder)
             return String.Join(" ", processId, updateSandboxFolder.TrimEnd(Path.DirectorySeparatorChar).WrapInQuotes(), executingApplication.WrapInQuotes());
         }
 
+        private void EnsureAppDataSafety()
+        {
+            if (_appFolderInfo.StartUpFolder.IsParentPath(_appFolderInfo.AppDataFolder) ||
+                _appFolderInfo.StartUpFolder.PathEquals(_appFolderInfo.AppDataFolder))
+            {
+                throw new NotSupportedException("Update will cause AppData to be deleted, correct you configuration before proceeding");
+            }
+        }
+
         public void Execute(ApplicationUpdateCommand message)
         {
             _logger.ProgressDebug("Checking for updates");