From f704ab151267bd81b18798ede4e5c9ec875d8f4c Mon Sep 17 00:00:00 2001 From: Mark McDowall Date: Tue, 23 Feb 2021 18:39:24 -0800 Subject: [PATCH] Improve messaging if release is in queue because all movies in release were not imported Sync with upstream (cherry picked from commit 2728bf79ca41bc372de515cb09e1034a8c006c2b) --- .../Store/Actions/interactiveImportActions.js | 2 ++ .../Download/CompletedDownloadService.cs | 20 ++++++++++++------- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/frontend/src/Store/Actions/interactiveImportActions.js b/frontend/src/Store/Actions/interactiveImportActions.js index 6cf7484b2..16c848b58 100644 --- a/frontend/src/Store/Actions/interactiveImportActions.js +++ b/frontend/src/Store/Actions/interactiveImportActions.js @@ -56,6 +56,8 @@ export const defaultState = { }; export const persistState = [ + 'interactiveImport.sortKey', + 'interactiveImport.sortDirection', 'interactiveImport.recentFolders', 'interactiveImport.importMode' ]; diff --git a/src/NzbDrone.Core/Download/CompletedDownloadService.cs b/src/NzbDrone.Core/Download/CompletedDownloadService.cs index 267e3f15f..c0ee0df27 100644 --- a/src/NzbDrone.Core/Download/CompletedDownloadService.cs +++ b/src/NzbDrone.Core/Download/CompletedDownloadService.cs @@ -155,6 +155,8 @@ namespace NzbDrone.Core.Download if (importResults.Empty()) { trackedDownload.Warn("No files found are eligible for import in {0}", outputPath); + + return; } if (importResults.Count == 1) @@ -176,14 +178,18 @@ namespace NzbDrone.Core.Download if (importResults.Any(c => c.Result != ImportResultType.Imported)) { - statusMessages.AddRange(importResults - .Where(v => v.Result != ImportResultType.Imported && v.ImportDecision.LocalMovie != null) - .Select(v => new TrackedDownloadStatusMessage(Path.GetFileName(v.ImportDecision.LocalMovie.Path), v.Errors))); + statusMessages.AddRange( + importResults + .Where(v => v.Result != ImportResultType.Imported && v.ImportDecision.LocalMovie != null) + .OrderBy(v => v.ImportDecision.LocalMovie.Path) + .Select(v => + new TrackedDownloadStatusMessage(Path.GetFileName(v.ImportDecision.LocalMovie.Path), + v.Errors))); + } - if (statusMessages.Any()) - { - trackedDownload.Warn(statusMessages.ToArray()); - } + if (statusMessages.Any()) + { + trackedDownload.Warn(statusMessages.ToArray()); } }