From fd76d67bae94fc85006886ddddeafd04075e9f8d Mon Sep 17 00:00:00 2001 From: Bogdan Date: Thu, 18 May 2023 20:44:05 +0300 Subject: [PATCH] Remove empty constructors --- .../Messaging/Commands/CommandExecutorFixture.cs | 6 +----- src/NzbDrone.Core/Download/DownloadsProcessedEvent.cs | 3 --- .../MediaBrowser/MediaBrowserMetadataSettings.cs | 3 --- .../Metadata/Consumers/Roksbox/RoksboxMetadataSettings.cs | 3 --- .../Metadata/Consumers/Wdtv/WdtvMetadataSettings.cs | 3 --- .../Metadata/Consumers/Xbmc/XbmcMetadataSettings.cs | 3 --- .../ImportLists/CouchPotato/CouchPotatoParser.cs | 4 ---- src/NzbDrone.Core/ImportLists/Plex/PlexParser.cs | 4 ---- .../ImportLists/RadarrList/RadarrListParser.cs | 4 ---- .../ImportLists/RadarrList2/IMDb/IMDbListSettings.cs | 6 +----- src/NzbDrone.Core/ImportLists/StevenLu/StevenLuParser.cs | 4 ---- .../TMDb/Company/TMDbCompanyRequestGenerator.cs | 6 +----- .../TMDb/Keyword/TMDbKeywordRequestGenerator.cs | 4 ---- .../ImportLists/TMDb/List/TMDbListRequestGenerator.cs | 4 ---- .../ImportLists/TMDb/Person/TMDbPersonRequestGenerator.cs | 6 +----- src/NzbDrone.Core/ImportLists/TMDb/TMDbSettings.cs | 8 +------- .../ImportLists/TMDb/User/TMDbUserRequestGenerator.cs | 4 ---- .../ImportLists/Trakt/List/TraktListSettings.cs | 4 ---- src/NzbDrone.Core/ImportLists/Trakt/TraktParser.cs | 4 ---- .../TorrentPotato/TorrentPotatoRequestGenerator.cs | 4 ---- .../MediaFiles/Commands/RenameMovieCommand.cs | 4 ---- .../Notifications/Synology/SynologyIndexerSettings.cs | 5 +---- src/Radarr.Api.V3/Credits/CreditResource.cs | 4 ---- src/Radarr.Api.V3/Movies/AlternativeTitleResource.cs | 4 ---- src/Radarr.Http/ApiInfoController.cs | 4 ---- 25 files changed, 6 insertions(+), 102 deletions(-) diff --git a/src/NzbDrone.Core.Test/Messaging/Commands/CommandExecutorFixture.cs b/src/NzbDrone.Core.Test/Messaging/Commands/CommandExecutorFixture.cs index 7e22f6f85..e0f633266 100644 --- a/src/NzbDrone.Core.Test/Messaging/Commands/CommandExecutorFixture.cs +++ b/src/NzbDrone.Core.Test/Messaging/Commands/CommandExecutorFixture.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Threading; using Moq; using NUnit.Framework; @@ -210,10 +210,6 @@ namespace NzbDrone.Core.Test.Messaging.Commands public class CommandB : Command { - public CommandB() - { - } - public override string CompletionMessage => null; } } diff --git a/src/NzbDrone.Core/Download/DownloadsProcessedEvent.cs b/src/NzbDrone.Core/Download/DownloadsProcessedEvent.cs index 2dea12b8d..feaaf90d9 100644 --- a/src/NzbDrone.Core/Download/DownloadsProcessedEvent.cs +++ b/src/NzbDrone.Core/Download/DownloadsProcessedEvent.cs @@ -4,8 +4,5 @@ namespace NzbDrone.Core.Download { public class DownloadsProcessedEvent : IEvent { - public DownloadsProcessedEvent() - { - } } } diff --git a/src/NzbDrone.Core/Extras/Metadata/Consumers/MediaBrowser/MediaBrowserMetadataSettings.cs b/src/NzbDrone.Core/Extras/Metadata/Consumers/MediaBrowser/MediaBrowserMetadataSettings.cs index fd64deb61..b3e647ab9 100644 --- a/src/NzbDrone.Core/Extras/Metadata/Consumers/MediaBrowser/MediaBrowserMetadataSettings.cs +++ b/src/NzbDrone.Core/Extras/Metadata/Consumers/MediaBrowser/MediaBrowserMetadataSettings.cs @@ -7,9 +7,6 @@ namespace NzbDrone.Core.Extras.Metadata.Consumers.MediaBrowser { public class MediaBrowserSettingsValidator : AbstractValidator { - public MediaBrowserSettingsValidator() - { - } } public class MediaBrowserMetadataSettings : IProviderConfig diff --git a/src/NzbDrone.Core/Extras/Metadata/Consumers/Roksbox/RoksboxMetadataSettings.cs b/src/NzbDrone.Core/Extras/Metadata/Consumers/Roksbox/RoksboxMetadataSettings.cs index ea4c7c7a5..3dd5f54f4 100644 --- a/src/NzbDrone.Core/Extras/Metadata/Consumers/Roksbox/RoksboxMetadataSettings.cs +++ b/src/NzbDrone.Core/Extras/Metadata/Consumers/Roksbox/RoksboxMetadataSettings.cs @@ -7,9 +7,6 @@ namespace NzbDrone.Core.Extras.Metadata.Consumers.Roksbox { public class RoksboxSettingsValidator : AbstractValidator { - public RoksboxSettingsValidator() - { - } } public class RoksboxMetadataSettings : IProviderConfig diff --git a/src/NzbDrone.Core/Extras/Metadata/Consumers/Wdtv/WdtvMetadataSettings.cs b/src/NzbDrone.Core/Extras/Metadata/Consumers/Wdtv/WdtvMetadataSettings.cs index ef82c3d0b..9cd64cb2e 100644 --- a/src/NzbDrone.Core/Extras/Metadata/Consumers/Wdtv/WdtvMetadataSettings.cs +++ b/src/NzbDrone.Core/Extras/Metadata/Consumers/Wdtv/WdtvMetadataSettings.cs @@ -7,9 +7,6 @@ namespace NzbDrone.Core.Extras.Metadata.Consumers.Wdtv { public class WdtvSettingsValidator : AbstractValidator { - public WdtvSettingsValidator() - { - } } public class WdtvMetadataSettings : IProviderConfig diff --git a/src/NzbDrone.Core/Extras/Metadata/Consumers/Xbmc/XbmcMetadataSettings.cs b/src/NzbDrone.Core/Extras/Metadata/Consumers/Xbmc/XbmcMetadataSettings.cs index ea4e0b5d3..589feb7fe 100644 --- a/src/NzbDrone.Core/Extras/Metadata/Consumers/Xbmc/XbmcMetadataSettings.cs +++ b/src/NzbDrone.Core/Extras/Metadata/Consumers/Xbmc/XbmcMetadataSettings.cs @@ -8,9 +8,6 @@ namespace NzbDrone.Core.Extras.Metadata.Consumers.Xbmc { public class XbmcSettingsValidator : AbstractValidator { - public XbmcSettingsValidator() - { - } } public class XbmcMetadataSettings : IProviderConfig diff --git a/src/NzbDrone.Core/ImportLists/CouchPotato/CouchPotatoParser.cs b/src/NzbDrone.Core/ImportLists/CouchPotato/CouchPotatoParser.cs index f6d805c53..f772836fc 100644 --- a/src/NzbDrone.Core/ImportLists/CouchPotato/CouchPotatoParser.cs +++ b/src/NzbDrone.Core/ImportLists/CouchPotato/CouchPotatoParser.cs @@ -12,10 +12,6 @@ namespace NzbDrone.Core.ImportLists.CouchPotato { private ImportListResponse _importListResponse; - public CouchPotatoParser() - { - } - public IList ParseResponse(ImportListResponse importListResponse) { _importListResponse = importListResponse; diff --git a/src/NzbDrone.Core/ImportLists/Plex/PlexParser.cs b/src/NzbDrone.Core/ImportLists/Plex/PlexParser.cs index 5da2d6833..64c38858d 100644 --- a/src/NzbDrone.Core/ImportLists/Plex/PlexParser.cs +++ b/src/NzbDrone.Core/ImportLists/Plex/PlexParser.cs @@ -14,10 +14,6 @@ namespace NzbDrone.Core.ImportLists.Plex { private ImportListResponse _importResponse; - public PlexParser() - { - } - public virtual IList ParseResponse(ImportListResponse importResponse) { List items; diff --git a/src/NzbDrone.Core/ImportLists/RadarrList/RadarrListParser.cs b/src/NzbDrone.Core/ImportLists/RadarrList/RadarrListParser.cs index c778e555b..25e011fe5 100644 --- a/src/NzbDrone.Core/ImportLists/RadarrList/RadarrListParser.cs +++ b/src/NzbDrone.Core/ImportLists/RadarrList/RadarrListParser.cs @@ -9,10 +9,6 @@ namespace NzbDrone.Core.ImportLists.RadarrList { public class RadarrListParser : IParseImportListResponse { - public RadarrListParser() - { - } - public IList ParseResponse(ImportListResponse importListResponse) { var importResponse = importListResponse; diff --git a/src/NzbDrone.Core/ImportLists/RadarrList2/IMDb/IMDbListSettings.cs b/src/NzbDrone.Core/ImportLists/RadarrList2/IMDb/IMDbListSettings.cs index 6308f2049..74936473c 100644 --- a/src/NzbDrone.Core/ImportLists/RadarrList2/IMDb/IMDbListSettings.cs +++ b/src/NzbDrone.Core/ImportLists/RadarrList2/IMDb/IMDbListSettings.cs @@ -1,4 +1,4 @@ -using FluentValidation; +using FluentValidation; using NzbDrone.Core.Annotations; using NzbDrone.Core.ThingiProvider; using NzbDrone.Core.Validation; @@ -19,10 +19,6 @@ namespace NzbDrone.Core.ImportLists.RadarrList2.IMDbList { private static readonly IMDbSettingsValidator Validator = new IMDbSettingsValidator(); - public IMDbListSettings() - { - } - [FieldDefinition(1, Label = "List/User ID", HelpText = "IMDb list ID (e.g ls12345678), IMDb user ID (e.g. ur12345678), 'top250' or 'popular'")] public string ListId { get; set; } diff --git a/src/NzbDrone.Core/ImportLists/StevenLu/StevenLuParser.cs b/src/NzbDrone.Core/ImportLists/StevenLu/StevenLuParser.cs index 5be54a240..cd6fa9686 100644 --- a/src/NzbDrone.Core/ImportLists/StevenLu/StevenLuParser.cs +++ b/src/NzbDrone.Core/ImportLists/StevenLu/StevenLuParser.cs @@ -11,10 +11,6 @@ namespace NzbDrone.Core.ImportLists.StevenLu { private ImportListResponse _importResponse; - public StevenLuParser() - { - } - public IList ParseResponse(ImportListResponse importResponse) { _importResponse = importResponse; diff --git a/src/NzbDrone.Core/ImportLists/TMDb/Company/TMDbCompanyRequestGenerator.cs b/src/NzbDrone.Core/ImportLists/TMDb/Company/TMDbCompanyRequestGenerator.cs index 121ae13cf..e9fce48a0 100644 --- a/src/NzbDrone.Core/ImportLists/TMDb/Company/TMDbCompanyRequestGenerator.cs +++ b/src/NzbDrone.Core/ImportLists/TMDb/Company/TMDbCompanyRequestGenerator.cs @@ -1,4 +1,4 @@ -using System.Collections.Generic; +using System.Collections.Generic; using Newtonsoft.Json; using NLog; using NzbDrone.Common.Http; @@ -13,10 +13,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.Company public Logger Logger { get; set; } public int MaxPages { get; set; } - public TMDbCompanyRequestGenerator() - { - } - public virtual ImportListPageableRequestChain GetMovies() { var pageableRequests = new ImportListPageableRequestChain(); diff --git a/src/NzbDrone.Core/ImportLists/TMDb/Keyword/TMDbKeywordRequestGenerator.cs b/src/NzbDrone.Core/ImportLists/TMDb/Keyword/TMDbKeywordRequestGenerator.cs index 4bc5f48df..3e8ab6402 100644 --- a/src/NzbDrone.Core/ImportLists/TMDb/Keyword/TMDbKeywordRequestGenerator.cs +++ b/src/NzbDrone.Core/ImportLists/TMDb/Keyword/TMDbKeywordRequestGenerator.cs @@ -13,10 +13,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.Keyword public Logger Logger { get; set; } public int MaxPages { get; set; } - public TMDbKeywordRequestGenerator() - { - } - public virtual ImportListPageableRequestChain GetMovies() { var pageableRequests = new ImportListPageableRequestChain(); diff --git a/src/NzbDrone.Core/ImportLists/TMDb/List/TMDbListRequestGenerator.cs b/src/NzbDrone.Core/ImportLists/TMDb/List/TMDbListRequestGenerator.cs index 65b96c5fd..3d7f5e685 100644 --- a/src/NzbDrone.Core/ImportLists/TMDb/List/TMDbListRequestGenerator.cs +++ b/src/NzbDrone.Core/ImportLists/TMDb/List/TMDbListRequestGenerator.cs @@ -13,10 +13,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.List public Logger Logger { get; set; } public int MaxPages { get; set; } - public TMDbListRequestGenerator() - { - } - public virtual ImportListPageableRequestChain GetMovies() { var pageableRequests = new ImportListPageableRequestChain(); diff --git a/src/NzbDrone.Core/ImportLists/TMDb/Person/TMDbPersonRequestGenerator.cs b/src/NzbDrone.Core/ImportLists/TMDb/Person/TMDbPersonRequestGenerator.cs index 09ca6164a..fa7cba3dc 100644 --- a/src/NzbDrone.Core/ImportLists/TMDb/Person/TMDbPersonRequestGenerator.cs +++ b/src/NzbDrone.Core/ImportLists/TMDb/Person/TMDbPersonRequestGenerator.cs @@ -1,4 +1,4 @@ -using System.Collections.Generic; +using System.Collections.Generic; using NLog; using NzbDrone.Common.Http; @@ -11,10 +11,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.Person public IHttpRequestBuilderFactory RequestBuilder { get; set; } public Logger Logger { get; set; } - public TMDbPersonRequestGenerator() - { - } - public virtual ImportListPageableRequestChain GetMovies() { var pageableRequests = new ImportListPageableRequestChain(); diff --git a/src/NzbDrone.Core/ImportLists/TMDb/TMDbSettings.cs b/src/NzbDrone.Core/ImportLists/TMDb/TMDbSettings.cs index 72b84eaf4..39da0f830 100644 --- a/src/NzbDrone.Core/ImportLists/TMDb/TMDbSettings.cs +++ b/src/NzbDrone.Core/ImportLists/TMDb/TMDbSettings.cs @@ -1,4 +1,4 @@ -using FluentValidation; +using FluentValidation; using NzbDrone.Core.ThingiProvider; using NzbDrone.Core.Validation; @@ -7,18 +7,12 @@ namespace NzbDrone.Core.ImportLists.TMDb public class TMDbSettingsBaseValidator : AbstractValidator where TSettings : TMDbSettingsBase { - public TMDbSettingsBaseValidator() - { - } } public class TMDbSettingsBase : IProviderConfig where TSettings : TMDbSettingsBase { protected virtual AbstractValidator Validator => new TMDbSettingsBaseValidator(); - public TMDbSettingsBase() - { - } public NzbDroneValidationResult Validate() { diff --git a/src/NzbDrone.Core/ImportLists/TMDb/User/TMDbUserRequestGenerator.cs b/src/NzbDrone.Core/ImportLists/TMDb/User/TMDbUserRequestGenerator.cs index 6838af1b9..74ea6da66 100644 --- a/src/NzbDrone.Core/ImportLists/TMDb/User/TMDbUserRequestGenerator.cs +++ b/src/NzbDrone.Core/ImportLists/TMDb/User/TMDbUserRequestGenerator.cs @@ -15,10 +15,6 @@ namespace NzbDrone.Core.ImportLists.TMDb.User public int MaxPages { get; set; } - public TMDbUserRequestGenerator() - { - } - public virtual ImportListPageableRequestChain GetMovies() { var pageableRequests = new ImportListPageableRequestChain(); diff --git a/src/NzbDrone.Core/ImportLists/Trakt/List/TraktListSettings.cs b/src/NzbDrone.Core/ImportLists/Trakt/List/TraktListSettings.cs index 0e2438730..1474a3e70 100644 --- a/src/NzbDrone.Core/ImportLists/Trakt/List/TraktListSettings.cs +++ b/src/NzbDrone.Core/ImportLists/Trakt/List/TraktListSettings.cs @@ -17,10 +17,6 @@ namespace NzbDrone.Core.ImportLists.Trakt.List { protected override AbstractValidator Validator => new TraktListSettingsValidator(); - public TraktListSettings() - { - } - [FieldDefinition(1, Label = "Username", Privacy = PrivacyLevel.UserName, HelpText = "Username for the List to import from")] public string Username { get; set; } diff --git a/src/NzbDrone.Core/ImportLists/Trakt/TraktParser.cs b/src/NzbDrone.Core/ImportLists/Trakt/TraktParser.cs index 8864a597a..2917a97c6 100644 --- a/src/NzbDrone.Core/ImportLists/Trakt/TraktParser.cs +++ b/src/NzbDrone.Core/ImportLists/Trakt/TraktParser.cs @@ -12,10 +12,6 @@ namespace NzbDrone.Core.ImportLists.Trakt { private ImportListResponse _importResponse; - public TraktParser() - { - } - public virtual IList ParseResponse(ImportListResponse importResponse) { _importResponse = importResponse; diff --git a/src/NzbDrone.Core/Indexers/TorrentPotato/TorrentPotatoRequestGenerator.cs b/src/NzbDrone.Core/Indexers/TorrentPotato/TorrentPotatoRequestGenerator.cs index 1879a8933..a8d8eeb1d 100644 --- a/src/NzbDrone.Core/Indexers/TorrentPotato/TorrentPotatoRequestGenerator.cs +++ b/src/NzbDrone.Core/Indexers/TorrentPotato/TorrentPotatoRequestGenerator.cs @@ -10,10 +10,6 @@ namespace NzbDrone.Core.Indexers.TorrentPotato { public TorrentPotatoSettings Settings { get; set; } - public TorrentPotatoRequestGenerator() - { - } - public virtual IndexerPageableRequestChain GetRecentRequests() { var pageableRequests = new IndexerPageableRequestChain(); diff --git a/src/NzbDrone.Core/MediaFiles/Commands/RenameMovieCommand.cs b/src/NzbDrone.Core/MediaFiles/Commands/RenameMovieCommand.cs index ca1f3a49f..0f8cb2693 100644 --- a/src/NzbDrone.Core/MediaFiles/Commands/RenameMovieCommand.cs +++ b/src/NzbDrone.Core/MediaFiles/Commands/RenameMovieCommand.cs @@ -9,9 +9,5 @@ namespace NzbDrone.Core.MediaFiles.Commands public override bool SendUpdatesToClient => true; public override bool RequiresDiskAccess => true; - - public RenameMovieCommand() - { - } } } diff --git a/src/NzbDrone.Core/Notifications/Synology/SynologyIndexerSettings.cs b/src/NzbDrone.Core/Notifications/Synology/SynologyIndexerSettings.cs index 7b1084570..58b4322e8 100644 --- a/src/NzbDrone.Core/Notifications/Synology/SynologyIndexerSettings.cs +++ b/src/NzbDrone.Core/Notifications/Synology/SynologyIndexerSettings.cs @@ -1,4 +1,4 @@ -using FluentValidation; +using FluentValidation; using NzbDrone.Core.Annotations; using NzbDrone.Core.ThingiProvider; using NzbDrone.Core.Validation; @@ -7,9 +7,6 @@ namespace NzbDrone.Core.Notifications.Synology { public class SynologyIndexerSettingsValidator : AbstractValidator { - public SynologyIndexerSettingsValidator() - { - } } public class SynologyIndexerSettings : IProviderConfig diff --git a/src/Radarr.Api.V3/Credits/CreditResource.cs b/src/Radarr.Api.V3/Credits/CreditResource.cs index 7ade5d148..192bae637 100644 --- a/src/Radarr.Api.V3/Credits/CreditResource.cs +++ b/src/Radarr.Api.V3/Credits/CreditResource.cs @@ -8,10 +8,6 @@ namespace Radarr.Api.V3.Credits { public class CreditResource : RestResource { - public CreditResource() - { - } - public string PersonName { get; set; } public string CreditTmdbId { get; set; } public int PersonTmdbId { get; set; } diff --git a/src/Radarr.Api.V3/Movies/AlternativeTitleResource.cs b/src/Radarr.Api.V3/Movies/AlternativeTitleResource.cs index 1456ee888..366ff4bac 100644 --- a/src/Radarr.Api.V3/Movies/AlternativeTitleResource.cs +++ b/src/Radarr.Api.V3/Movies/AlternativeTitleResource.cs @@ -8,10 +8,6 @@ namespace Radarr.Api.V3.Movies { public class AlternativeTitleResource : RestResource { - public AlternativeTitleResource() - { - } - // Todo: Sorters should be done completely on the client // Todo: Is there an easy way to keep IgnoreArticlesWhenSorting in sync between, Series, History, Missing? // Todo: We should get the entire Profile instead of ID and Name separately diff --git a/src/Radarr.Http/ApiInfoController.cs b/src/Radarr.Http/ApiInfoController.cs index d9590212e..840abc346 100644 --- a/src/Radarr.Http/ApiInfoController.cs +++ b/src/Radarr.Http/ApiInfoController.cs @@ -5,10 +5,6 @@ namespace Radarr.Http { public class ApiInfoController : Controller { - public ApiInfoController() - { - } - [HttpGet("/api")] [Produces("application/json")] public ApiInfoResource GetApiInfo()