mirror
/
Sonarr
mirror of https://github.com/Sonarr/Sonarr
1
0
Fork 0
Code Issues Releases Wiki Activity

Testing ExceptionVerification Inconclusive logic

This commit is contained in:
kay.one 2011-10-16 20:32:57 -07:00
parent 1d97455e9f
commit 77b867d65e
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NzbDrone.Core.Test/Framework/AutoMoq/TestBaseTests.cs
View File

@ -55,7 +55,7 @@ namespace NzbDrone.Core.Test.Framework.AutoMoq
public void Test_should_pass_when_exception_type_is_ignored() public void Test_should_pass_when_exception_type_is_ignored()
{ {
Logger.ErrorException("bad exception", new WebException("Test")); Logger.ErrorException("bad exception", new WebException("Test"));
ExceptionVerification.MarkForInconclusive(typeof(WebException)); ExceptionVerification.MarkInconclusive(typeof(WebException));
} }
} }
} }

22
NzbDrone.Core.Test/Framework/ExceptionVerification.cs
View File

@ -11,7 +11,6 @@ namespace NzbDrone.Core.Test.Framework
public class ExceptionVerification : Target public class ExceptionVerification : Target
{ {
private static List<LogEventInfo> _logs = new List<LogEventInfo>(); private static List<LogEventInfo> _logs = new List<LogEventInfo>();
private static List<Type> _inconclusive = new List<Type>();
protected override void Write(LogEventInfo logEvent) protected override void Write(LogEventInfo logEvent)
{ {
@ -24,7 +23,6 @@ namespace NzbDrone.Core.Test.Framework
internal static void Reset() internal static void Reset()
{ {
_logs = new List<LogEventInfo>(); _logs = new List<LogEventInfo>();
_inconclusive = new List<Type>();
} }
internal static void AssertNoUnexcpectedLogs() internal static void AssertNoUnexcpectedLogs()
@ -74,16 +72,23 @@ namespace NzbDrone.Core.Test.Framework
Ignore(LogLevel.Error); Ignore(LogLevel.Error);
} }
internal static void MarkForInconclusive(Type exception) internal static void MarkInconclusive(Type exception)
{ {
_inconclusive.Add(exception); var inconclusiveLogs = _logs.Where(l => l.Exception.GetType() == exception).ToList();
if (inconclusiveLogs.Count != 0)
{
inconclusiveLogs.ForEach(c => _logs.Remove(c));
Assert.Inconclusive(GetLogsString(inconclusiveLogs));
}
} }
private static void Excpected(LogLevel level, int count) private static void Excpected(LogLevel level, int count)
{ {
var inconclusiveLogs = _logs.Where(l => _inconclusive.Any(c => c == l.Exception.GetType())).ToList();
var levelLogs = _logs.Except(inconclusiveLogs).Where(l => l.Level == level).ToList();
var levelLogs = _logs.Where(l => l.Level == level).ToList();
if (levelLogs.Count != count) if (levelLogs.Count != count)
{ {
@ -98,11 +103,6 @@ namespace NzbDrone.Core.Test.Framework
Assert.Fail(message); Assert.Fail(message);
} }
if (inconclusiveLogs.Count != 0)
{
Assert.Inconclusive(GetLogsString(inconclusiveLogs));
}
levelLogs.ForEach(c => _logs.Remove(c)); levelLogs.ForEach(c => _logs.Remove(c));
} }