mirror
/
Sonarr
mirror of https://github.com/Sonarr/Sonarr
1
0
Fork 0
Code Issues Releases Wiki Activity

Groups must contain multiple qualities

This commit is contained in:
Mark McDowall 2019-02-19 18:48:54 -08:00
parent 05e7b90aab
commit e32e6e0bec
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Sonarr.Api.V3/Profiles/Quality/QualityItemsValidator.cs
View File

@ -13,7 +13,7 @@ namespace Sonarr.Api.V3.Profiles.Quality
ruleBuilder.SetValidator(new NotEmptyValidator(null));
ruleBuilder.SetValidator(new AllowedValidator<T>());
ruleBuilder.SetValidator(new QualityNameValidator<T>());
ruleBuilder.SetValidator(new EmptyItemGroupNameValidator<T>());
ruleBuilder.SetValidator(new GroupItemValidator<T>());
ruleBuilder.SetValidator(new ItemGroupIdValidator<T>());
ruleBuilder.SetValidator(new UniqueIdValidator<T>());
ruleBuilder.SetValidator(new UniqueQualityIdValidator<T>());
@ -47,10 +47,10 @@ namespace Sonarr.Api.V3.Profiles.Quality
}
}
public class EmptyItemGroupNameValidator<T> : PropertyValidator
public class GroupItemValidator<T> : PropertyValidator
{
public EmptyItemGroupNameValidator()
: base("Groups must not be empty")
public GroupItemValidator()
: base("Groups must contain multiple qualities")
{
}
@ -59,7 +59,7 @@ namespace Sonarr.Api.V3.Profiles.Quality
{
var items = context.PropertyValue as IList<QualityProfileQualityItemResource>;
if (items.Any(i => i.Name.IsNotNullOrWhiteSpace() && i.Items.Empty()))
if (items.Any(i => i.Name.IsNotNullOrWhiteSpace() && i.Items.Count <= 1))
{
return false;
}

2
src/Sonarr.Api.V3/Profiles/Quality/QualityProfileModule.cs
View File

@ -13,8 +13,6 @@ namespace Sonarr.Api.V3.Profiles.Quality
{
_profileService = profileService;
SharedValidator.RuleFor(c => c.Name).NotEmpty();
// TODO: Need to validate the cutoff is allowed and the ID/quality ID exists
// TODO: Need to validate the Items to ensure groups have names and at no item has no name, no items and no quality
SharedValidator.RuleFor(c => c.Cutoff).ValidCutoff();
SharedValidator.RuleFor(c => c.Items).ValidItems();