Commit Graph

584 Commits

Author SHA1 Message Date
Qstick 2b79fe833b Use Contains(char) instead of Contains(string) for performance 2023-03-15 19:24:48 -05:00
Qstick e8aff90582 Use span-based string.Concat to avoid unnecessary allocation
Calling Substring produces a copy of the extracted substring. By using AsSpan instead of Substring and calling the overload of string.Concat that accepts spans, you can eliminate the unnecessary string allocation.
2023-03-15 19:24:48 -05:00
Qstick f928ee7cad Use Environment.ProcessPath instead of GetCurrentProcess().MainModule.FileName
GetCurrentProcess().MainModule.FileName is expensive, Environment.ProcessPath added in net6
2023-03-15 19:24:48 -05:00
Qstick 7521579bca Use Apend(char) instead of Apend(string) for performance
When calling StringBuilder.Append with a unit length string, consider using a const char rather than a unit length const string to improve performance.
2023-03-15 19:24:48 -05:00
Qstick 4fe9daec03 Use Any() in place of Count() to prevent enumerating
This rule flags the Count and LongCount LINQ method calls used to check if the collection has at least one element. These method calls require enumerating the entire collection to compute the count. The same check is faster with the Any method as it avoids enumerating the collection.
2023-03-15 19:24:48 -05:00
Qstick 0ed8ba828d Avoid unnecessary zero-length array allocations 2023-03-15 19:24:48 -05:00
Qstick 08ee2f7e32 Remove unnecessary assignments to default type value
The .NET runtime initializes all fields of reference types to their default values before running the constructor. In most cases, explicitly initializing a field to its default value in a constructor is redundant, adding maintenance costs and potentially degrading performance
2023-03-15 19:24:48 -05:00
Mark McDowall bd3816dac9 Handle null for parent name with clean path is empty 2023-02-20 17:20:07 -08:00
Mark McDowall 95a8f59a32 Fixed: Don't handle images in metadata folder as Roksbox images 2023-02-20 16:42:57 -08:00
Mark McDowall 75378f7bde Fixed: USB drives mounted to folders are treated as different mounts
Closes #4147
2023-02-16 17:05:39 -08:00
Mark McDowall 303fc5d786 New: Return static response to requests while app is starting
Closes #5402
2023-02-07 17:31:54 -08:00
Mark McDowall 40ce54e165 Upgrade Newtonsoft.Json 2022-12-23 22:33:39 -08:00
Qstick fd98a179ab New: Improve IPAddress.IsLocal method
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-12-07 23:03:59 -06:00
Mark McDowall 1b90fbcf7d New: IPv6 support for connections/indexers/download clients
Closes #4149
2022-12-06 23:11:59 -08:00
Mark McDowall 6bdeafcf8c Fixed: Improve Bind Address validation and help text
Closes #622
2022-12-06 23:11:59 -08:00
Bruno Garcia de3cb07c57
Sentry SDK v3.23.1
Co-authored-by: Bruno Garcia <bruno@Brunos-MacBook-Pro.local>
2022-11-26 14:06:08 -08:00
Qstick 08b677ca7d Enforce comment spacing with Stylecop 2022-11-21 16:58:07 -08:00
Qstick 237e7556c2 Bump Newtonsoft to 13.0.1 2022-11-19 17:17:56 -06:00
Qstick 173f456683 Remove Unity (No longer maintained) 2022-11-19 17:01:57 -06:00
luz paz 209a250079 Fix various typos
Found via `codespell -q 3`
2022-11-06 08:19:07 -08:00
Mark McDowall 26eab7d821 Fixed: Re-downloading of series images
Closes #5209
2022-10-26 17:06:53 -07:00
Chris d1f2a8a948
Fixed: Cleanse Discord Webhook URLs
Closes #5169
2022-10-16 07:42:33 -08:00
Qstick a645681cc8 Clean dual target code 2022-10-15 10:54:38 -05:00
Mark McDowall 6eed7c8fed Handle redirects for 308 redirects 2022-09-17 17:43:33 -07:00
Qstick fa0fc3158b New: MediaInfo -> FFProbe
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:24:38 -07:00
Qstick a4232549cb Fix Tray App and Windows Server Restart
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:24:38 -07:00
Qstick e65aebdcf8 New: Use native .NET6 socks proxy
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:24:37 -07:00
Qstick 4c0fe62dda Use modern HttpClient
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:24:37 -07:00
ta264 bff1fe7890 Update to nugets with osx-arm64 runtimes 2022-08-07 15:24:37 -07:00
Qstick 1169741c54 New: Use ASP.NET Core instead of Nancy
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:24:37 -07:00
Qstick f50b54b3f6 New: Use System.Text.Json for Nancy and SignalR
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:24:36 -07:00
Qstick 2e953a0eb1 Dapper and STJson
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:24:36 -07:00
Qstick 1c22a1ec0d StyleCop 2022-08-07 15:24:35 -07:00
Qstick 878d1561aa Build Sonarr on Net6
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:04:46 -07:00
Qstick 4d007855bc Bump NLog to 4.7.14 2022-08-07 15:04:43 -07:00
Qstick e263331880 Fixed: Remove obsolete HttpProvider
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:04:43 -07:00
Qstick d740e995a3 Cleanup OAuth Dep
Co-Authored-By: ta264 <ta264@users.noreply.github.com>
2022-08-07 15:04:42 -07:00
Qstick f7c771f467 Use Sqlite from Servarr 2022-08-07 15:04:42 -07:00
Qstick 52d2a5010a Purge Logentries 2022-08-07 15:04:42 -07:00
Qstick b819246655 Revert "New: Updated MediaInfo to 21.09, Sqlite to 3.32.1.0 and added support for mac osx arm64 arch. Deprecated osx x86."
This reverts commit 201004113e.
2022-08-07 15:04:42 -07:00
Kevin Richter 8ab040f612
Fixed: Improve moving file to location where another one exists 2022-08-07 11:52:54 -07:00
Robin Dadswell 6c0f22a11e New: Added UDP syslog support
(cherry picked from commit 8d856b2edb8bf46a2b516d5f7644ae3fa1151323)
2022-06-12 09:36:43 -07:00
Mark McDowall fa9136c4d1 Fixed: Validation when testing indexers, import lists, connections and download clients 2022-03-28 17:34:19 -07:00
Taloth Saldono d899225509 Add response size to http responses 2022-03-20 22:19:06 +01:00
Alan Collins 52c6bc5549 Adjusted the Windows LongPath support check for valid segment lengths 2022-02-02 18:28:09 +01:00
bakerboy448 e6210aede6 Fixed: Better Cleansing of Tracker Announce Keys
Fixes: #4623
2022-01-23 13:00:59 -08:00
bakerboy448 ec866082d4
Fixed: Cleanse Notifiarr secret from URL in logs 2021-12-24 13:06:31 -08:00
Stevie Robinson d80565f6a9
Fixed: Convert Trakt list name to URL slug 2021-12-20 12:26:51 -08:00
Martin e2b16adec6
Use pattern matching instead of as expression type checking 2021-12-17 19:16:00 -08:00
Taloth Saldono 201004113e New: Updated MediaInfo to 21.09, Sqlite to 3.32.1.0 and added support for mac osx arm64 arch. Deprecated osx x86. 2021-12-16 15:54:19 +01:00
Mark McDowall 1d8b711eda Aria2 fixes
Fixed: Removing completed downloads from Aria2
Fixed: Return correct path for Aria2 downloads in a job folder
Fixed: Seeding torrents in Aria2 are treated as finished downloading
Closes #4648
2021-09-03 21:41:52 -07:00
Taloth Saldono fe8f319f7b Show User Agent in System->Tasks for externally triggered commands 2021-05-16 12:43:17 +02:00
Taloth Saldono 8fc68420c9 Fixed: Scene Info displaying mappings for wrong season
Fixed: Extraneous searches based on scene mappings
2021-05-08 01:03:47 +02:00
bakerboy448 44f9d45938
New: Date format in log files 2021-04-24 19:17:33 -07:00
Taloth Saldono 652d44722b Fixed: Qbittorrent api errors when only one of two seed criteria was configured
closes #4393
2021-03-19 21:32:42 +01:00
Taloth Saldono fa8b2f48e7 Don't ignore original wal/journal during v3 migration 2021-03-18 23:43:16 +01:00
Qstick 2746556ae2 Cleanup trailing space in HttpResponse 2021-03-06 17:49:14 +01:00
Taloth Saldono 24ca47356e Sentry logging exceptions and some trace logging 2021-03-06 13:57:11 +01:00
Mark McDowall cd28af98ee Fixed: Removal of previous service 2021-03-05 18:28:59 -08:00
Qstick d6cf370bcd Handle 303 and 307 redirects in Http Requests 2021-03-03 20:43:44 -08:00
bakerboy448 e67864fecb
Fixed: Cleanse Tracker Announce Keys from logs
Closes #4341
2021-02-25 00:22:58 +01:00
Taloth Saldono 23047623ee Cleanse more /home/username scenarios 2021-02-20 20:04:34 +01:00
Taloth Saldono d898f55660 Generalized RateLimit logic to all indexers based on indexer id 2021-02-08 00:09:59 +01:00
Taloth Saldono 29bc660cfb Fixed: Jackett indexer search performance 2021-02-07 19:50:04 +01:00
Taloth Saldono 6c17b4bb86 Fixed accounting for zero terminator in long path limitation
closes #4259
2021-01-16 02:49:48 +01:00
Taloth Saldono 0bc190e97e Fixed binary execute permissions for osx and Radarr 2020-11-22 17:10:29 +01:00
Taloth Saldono d88bb7f855 New: Displaying folder-based permissions in UI rather than file-based permissions and with selectable sane presets
Fixed: Preserve setgid when applying unix permissions
2020-11-20 15:42:23 +01:00
Mark McDowall 7b1876d0d8 Fixed: Cleanse account and passwd from Download Station URLs 2020-10-25 16:12:45 -07:00
ta264 1d02208316 New: Make Twitter NetStandard compatible 2020-10-18 16:26:59 -07:00
Taloth Saldono 465de11c90 Fixed: Regression causing updater to fail (manual update required if on 3.0.3.971, see forums) 2020-10-11 20:52:12 +02:00
Taloth Saldono 94a78eabe5 Fixed: Dataloss when moving series folder to root folder with only different casing 2020-10-11 16:20:03 +02:00
Mark McDowall 0c7743e786 Fixed: Parsing of URLs with double slashes in the path
Closes #4005
2020-10-10 13:43:08 -07:00
Taloth Saldono 6efee036a8 Fixed: Include extension when calculating maximum episode title length when renaming files
Fixed: Option to override max filename length with MAX_NAME environment variable

Closes #3888
2020-08-11 00:09:12 +02:00
Taloth Saldono f3101a1db2 Fixed: Exception when parsing Quality in release title with colon 2020-08-11 00:09:10 +02:00
Taloth Saldono 87a64cdacb Fixed: TheTVDB metadata images containing html content 2020-06-25 23:40:37 +02:00
Taloth Saldono 903aba5dee Fixed: Refreshing Plex Server series in high volume systems 2020-06-21 21:32:45 +02:00
Taloth Saldono 2c286f7b60 New: Fast copy using reflink on btrfs volumes 2020-06-21 21:26:21 +02:00
Taloth Saldono 0e7b404121 Fixed: Removed hardlink-based transactional file transfer logic (instead relying on explicit copy+delete for cifs) 2020-06-21 21:26:21 +02:00
Taloth Saldono 6a393ef6a2 Used ReflectionOnly and/or public types where possible to avoid loading related assemblies unnecessarily. 2020-06-09 14:14:58 +02:00
Taloth Saldono 5536f9925a Moved Windows-only Permission function to Sonarr.Windows 2020-06-07 22:48:28 +02:00
Arthur Bols 3b579900bb
New: Removed chown and simplified chmod options for linux/osx
Closes #3760
Closes #3752
2020-06-07 19:05:25 +02:00
Taloth Saldono 396caa52cf New: Replaced launcher on OSX Catalina so that individual permissions can be assigned (note, will ignore permissions previously assigned to sh) 2020-06-07 17:42:46 +02:00
Taloth Saldono 72b0f640f4 Added Plex url to cleanser 2020-06-06 22:28:08 +02:00
Taloth Saldono 57cca9fcdc Fixed typo in Cleanse IP 2020-06-03 18:33:00 +02:00
Taloth Saldono b3daa280c5 Cleanse remote IP Address from trace log file 2020-06-02 20:58:13 +02:00
Taloth Saldono 0c05236bee Support for Runtime Patches via Harmony 2020-06-02 20:57:20 +02:00
Taloth Saldono 5251db7224 Fixed recursion issue when emptying recycle bin 2020-05-16 19:22:47 +02:00
Taloth Saldono d3a22459ac Fixed: Performance issue when scanning large root folder 2020-05-13 21:27:39 +02:00
Taloth Saldono 686a14cdff Log Real IP on Authentication failure in case of a reverse proxy
closes #3711
2020-04-27 23:58:35 +02:00
Taloth Saldono 776191b3bd Improved error message when nzb download contains an newznab error instead 2020-04-17 00:14:05 +02:00
Mark McDowall ae7f8926f8 New: Ignore #recycle folders (Synology Recycle bin folder) 2020-03-10 23:56:09 -07:00
Петр Шургалин b19d665817 Fixed: RestClient does not use global proxy settings 2020-01-19 16:41:31 +01:00
gl3nni3 2d94857369 Fixed: Replace duplicate slashes from file names when importing
Fixes #3470
2020-01-04 17:52:45 -08:00
Taloth Saldono d421ff9736 Increased max redirects from 3 to 5
closes #3449
2019-12-24 11:27:58 +01:00
Taloth Saldono 4aaccb909f Cleanse getnzb url 2019-12-06 19:49:27 +01:00
Taloth Saldono 95d64208d0 Fixed: File imports on cloud drives slow due to transaction logic 2019-11-19 17:35:19 +01:00
Taloth Saldono e28b2e8328 Fixed: Corrupt image files when downloading from redirecting Url
closes #3401
2019-11-15 18:39:31 +01:00
Mark McDowall dd314e1741 Fixed: Deletion of empty episode sub folders when an episode file is deleted 2019-11-03 09:04:39 -08:00
Taloth Saldono dc7986dbad Fixed regression in container registration. Additional logging in case of integration test startup failures 2019-09-13 17:11:20 +02:00
Taloth Saldono 155c7c409b Moved Platform version determination to static 2019-09-13 12:26:27 +02:00