mirror/archivemail
1
0
Fork 0
mirror of https://git.code.sf.net/p/archivemail/code synced 2025-03-16 09:29:25 +00:00
Code Issues Releases Wiki Activity

Remove simple-minded security checks

Browse source 
Remove the checks if the mailbox is a symlink, and if the output directory is
world-writable.  Better no security than half-baked security.
This commit is contained in:
Nikolaus Schulz 2008-08-04 19:53:31 +02:00
parent a3276f8c68
commit 79bcf86860
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
archivemail.py
View file

@ -1121,9 +1121,6 @@ def archive(mailbox_name):
tempfile.tempdir = new_temp_dir
vprint("set tempfile directory to '%s'" % new_temp_dir)
if os.path.islink(mailbox_name):
unexpected_error("'%s' is a symbolic link -- I feel nervous!" %
mailbox_name)
is_imap = urlparse.urlparse(mailbox_name)[0] in ('imap', 'imaps')
if is_imap:
vprint("guessing mailbox is of type: imap(s)")
@ -1645,15 +1642,6 @@ def check_sane_destdir(dir):
user_error("output directory does not exist: '%s'" % dir)
if not os.access(dir, os.W_OK):
user_error("no write permission on output directory: '%s'" % dir)
if is_world_writable(dir):
unexpected_error(("output directory is world-writable: '%s' -- "
"I feel nervous!") % dir)
def is_world_writable(path):
"""Return true if the path is world-writable, false otherwise"""
assert(path)
return (os.stat(path)[stat.ST_MODE] & stat.S_IWOTH)
def nice_size_str(size):