From 2c47b4596f5f7a5e091330498d15c54119e6fbdf Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Thu, 12 Apr 2018 23:35:38 +0200 Subject: [PATCH] update msgpack requirement, fixes #3753 (cherry picked from commit 5be756a0c6d526fc513fa0ad08767b127b941e90) --- setup.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/setup.py b/setup.py index 29087067f..f8321dc3e 100644 --- a/setup.py +++ b/setup.py @@ -51,9 +51,15 @@ cpu_threads = multiprocessing.cpu_count() if multiprocessing else 1 on_rtd = os.environ.get('READTHEDOCS') install_requires = [ - # msgpack pure python data corruption was fixed in 0.4.6. - # msgpack 0.5.0 was a bit of a troublemaker. - 'msgpack-python>=0.4.6,!=0.5.0,<0.6.0', + # we are rather picky about msgpack versions, because a good working msgpack is + # very important for borg, see https://github.com/borgbackup/borg/issues/3753 + # best versions seem to be 0.4.6, 0.4.7, 0.4.8 and 0.5.6: + 'msgpack-python >=0.4.6, <=0.5.6, !=0.5.0, !=0.5.1, !=0.5.2, !=0.5.3, !=0.5.4, !=0.5.5', + # if you can't satisfy the above requirement, these are versions that might + # also work ok, IF you make sure to use the COMPILED version of msgpack-python, + # NOT the PURE PYTHON fallback implementation: ==0.5.1, ==0.5.4 + # using any other version is not supported by borg development, feel free to + # do it on your own risk (and after own testing). 'pyzmq', ]