From 38e6ff0a5427063d66979f315655a3710d271f61 Mon Sep 17 00:00:00 2001 From: Manu Date: Wed, 30 Jan 2019 11:30:31 +0800 Subject: [PATCH] Quit with error message when no config key is provided. Fixes #4223 --- src/borg/archiver.py | 4 ++++ src/borg/testsuite/archiver.py | 2 ++ 2 files changed, 6 insertions(+) diff --git a/src/borg/archiver.py b/src/borg/archiver.py index 57b4f33cb..838d28760 100644 --- a/src/borg/archiver.py +++ b/src/borg/archiver.py @@ -1807,6 +1807,10 @@ class Archiver: print('%s = %s' % (key, value)) if not args.list: + if args.name is None: + self.print_error('No config key name was provided.') + return self.exit_code + try: section, name = args.name.split('.') except ValueError: diff --git a/src/borg/testsuite/archiver.py b/src/borg/testsuite/archiver.py index 95d0f7b67..a47cd86e6 100644 --- a/src/borg/testsuite/archiver.py +++ b/src/borg/testsuite/archiver.py @@ -2804,6 +2804,8 @@ id: 2 / e29442 3506da 4e1ea7 / 25f62a 5a3d41 - 02 self.cmd('config', '--delete', self.repository_location, cfg_key) self.cmd('config', self.repository_location, cfg_key, exit_code=1) self.cmd('config', '--list', '--delete', self.repository_location, exit_code=2) + self.cmd('config', self.repository_location, exit_code=2) + self.cmd('config', self.repository_location, 'invalid-option', exit_code=1) requires_gnutar = pytest.mark.skipif(not have_gnutar(), reason='GNU tar must be installed for this test.') requires_gzip = pytest.mark.skipif(not shutil.which('gzip'), reason='gzip must be installed for this test.')